Fixed
Status Update
No update yet.
Comments
al...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
al...@google.com
al...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
al...@google.com
We certainly can.
// Register packaged output for use by AGP's AIDL in other projects.
project.configurations.findByName(targetConfig)?.outgoing?.variants { variants ->
variants.allNamed(ARTIFACT_TYPE_AIDL) { variant ->
variant.artifact(packagedDir) { artifact ->
artifact.type = ARTIFACT_TYPE_AIDL
artifact.builtBy(taskProvider)
}
}
}
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f193de77b36ca339b6b872f1df7f0ce52c29d19f
Author: Alan Viverette <alanv@google.com>
Date: Wed Apr 05 13:52:19 2023
Export stable AIDL definitions to dependent projects
Migrates versionedparcelable, media2-session, and app-automotive to use
Stable AIDL.
Upgrades media2-common to depend on tip-of-tree versionedparcelable so it
can access stable AIDL files.
Relnote: Export stable AIDL definitions to dependent projects
Fixes: 277084531
Test: ./gradlew updateReleaseAidlApi
Change-Id: I473cbc23b15505b8493a00766248fcd1d8a10a96
M car/app/app-automotive/build.gradle
D car/app/app-automotive/src/main/aidl/androidx/car/app/activity/renderer/surface/ISurfaceControl.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/ICarAppActivity.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IInsetsListener.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IProxyInputConnection.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IRendererCallback.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IRendererService.aidl
A car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/surface/ISurfaceControl.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/surface/ISurfaceListener.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/content/ComponentName.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/content/Intent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/graphics/Insets.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/os/Bundle.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/KeyEvent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/MotionEvent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/CompletionInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/CorrectionInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/EditorInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/ExtractedText.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/ExtractedTextRequest.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareHost.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareResult.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareResultTypes.aidl
M car/app/app-projected/build.gradle
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareHost.aidl
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareResult.aidl
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareResultTypes.aidl
A car/app/app-projected/src/main/stableAidlImports/android/os/IBinder.aidl
A media2/media2-common/api/aidlRelease/current/androidx/media2/common/ParcelImplListSlice.aidl
M media2/media2-common/build.gradle
D media2/media2-common/src/main/aidl/androidx/media2/common/ParcelImplListSlice.aidl
A media2/media2-common/src/main/stableAidl/androidx/media2/common/ParcelImplListSlice.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaController.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaSession.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaSessionService.aidl
M media2/media2-session/build.gradle
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaController.aidl
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaSession.aidl
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaSessionService.aidl
A media2/media2-session/src/main/stableAidlImports/android/net/Uri.aidl
A media2/media2-session/src/main/stableAidlImports/android/os/Bundle.aidl
A media2/media2-session/src/main/stableAidlImports/android/view/Surface.aidl
M settings.gradle
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/StableAidlPlugin.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/StableAidlTasks.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/tasks/StableAidlCheckApi.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/tasks/StableAidlCompile.kt
M stableaidl/stableaidl-gradle-plugin/src/test/java/androidx/stableaidl/tasks/StableAidlCheckApiTest.kt
M stableaidl/stableaidl-gradle-plugin/src/test/java/androidx/stableaidl/tasks/StableAidlCompileTest.kt
A versionedparcelable/versionedparcelable/api/aidlRelease/current/androidx/versionedparcelable/ParcelImpl.aidl
M versionedparcelable/versionedparcelable/build.gradle
D versionedparcelable/versionedparcelable/src/main/aidl/androidx/versionedparcelable/ParcelImpl.aidl
A versionedparcelable/versionedparcelable/src/main/stableAidl/androidx/versionedparcelable/ParcelImpl.aidl
https://android-review.googlesource.com/2529183
Branch: androidx-main
commit f193de77b36ca339b6b872f1df7f0ce52c29d19f
Author: Alan Viverette <alanv@google.com>
Date: Wed Apr 05 13:52:19 2023
Export stable AIDL definitions to dependent projects
Migrates versionedparcelable, media2-session, and app-automotive to use
Stable AIDL.
Upgrades media2-common to depend on tip-of-tree versionedparcelable so it
can access stable AIDL files.
Relnote: Export stable AIDL definitions to dependent projects
Fixes: 277084531
Test: ./gradlew updateReleaseAidlApi
Change-Id: I473cbc23b15505b8493a00766248fcd1d8a10a96
M car/app/app-automotive/build.gradle
D car/app/app-automotive/src/main/aidl/androidx/car/app/activity/renderer/surface/ISurfaceControl.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/ICarAppActivity.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IInsetsListener.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IProxyInputConnection.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IRendererCallback.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/IRendererService.aidl
A car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/surface/ISurfaceControl.aidl
M car/app/app-automotive/src/main/stableAidl/androidx/car/app/activity/renderer/surface/ISurfaceListener.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/content/ComponentName.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/content/Intent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/graphics/Insets.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/os/Bundle.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/KeyEvent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/MotionEvent.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/CompletionInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/CorrectionInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/EditorInfo.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/ExtractedText.aidl
A car/app/app-automotive/src/main/stableAidlImports/android/view/inputmethod/ExtractedTextRequest.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareHost.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareResult.aidl
A car/app/app-projected/api/aidlRelease/current/androidx/car/app/hardware/ICarHardwareResultTypes.aidl
M car/app/app-projected/build.gradle
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareHost.aidl
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareResult.aidl
M car/app/app-projected/src/main/stableAidl/androidx/car/app/hardware/ICarHardwareResultTypes.aidl
A car/app/app-projected/src/main/stableAidlImports/android/os/IBinder.aidl
A media2/media2-common/api/aidlRelease/current/androidx/media2/common/ParcelImplListSlice.aidl
M media2/media2-common/build.gradle
D media2/media2-common/src/main/aidl/androidx/media2/common/ParcelImplListSlice.aidl
A media2/media2-common/src/main/stableAidl/androidx/media2/common/ParcelImplListSlice.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaController.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaSession.aidl
A media2/media2-session/api/aidlRelease/current/androidx/media2/session/IMediaSessionService.aidl
M media2/media2-session/build.gradle
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaController.aidl
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaSession.aidl
M media2/media2-session/src/main/stableAidl/androidx/media2/session/IMediaSessionService.aidl
A media2/media2-session/src/main/stableAidlImports/android/net/Uri.aidl
A media2/media2-session/src/main/stableAidlImports/android/os/Bundle.aidl
A media2/media2-session/src/main/stableAidlImports/android/view/Surface.aidl
M settings.gradle
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/StableAidlPlugin.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/StableAidlTasks.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/tasks/StableAidlCheckApi.kt
M stableaidl/stableaidl-gradle-plugin/src/main/java/androidx/stableaidl/tasks/StableAidlCompile.kt
M stableaidl/stableaidl-gradle-plugin/src/test/java/androidx/stableaidl/tasks/StableAidlCheckApiTest.kt
M stableaidl/stableaidl-gradle-plugin/src/test/java/androidx/stableaidl/tasks/StableAidlCompileTest.kt
A versionedparcelable/versionedparcelable/api/aidlRelease/current/androidx/versionedparcelable/ParcelImpl.aidl
M versionedparcelable/versionedparcelable/build.gradle
D versionedparcelable/versionedparcelable/src/main/aidl/androidx/versionedparcelable/ParcelImpl.aidl
A versionedparcelable/versionedparcelable/src/main/stableAidl/androidx/versionedparcelable/ParcelImpl.aidl
Description