Wear Compose Chip does not set Button Role [277326264]

Fixed

Bug

Status Update

No update yet.

Description

yu...@schimke.ee

created issue #1

Apr 8, 2023 05:32PM

Component used: Wear Compose Version used: 1.2.0-alpha08

println(rule.onNodeWithText("Refresh").printToString())

with alpha07

Printing with useUnmergedTree = 'false'
Node #23 at (l=20.0, t=259.0, r=422.0, b=363.0)px
Role = 'Button'
Focused = 'false'
Text = '[Refresh]'
Actions = [OnClick, RequestFocus, GetTextLayoutResult]
MergeDescendants = 'true'

with alpha08

Printing with useUnmergedTree = 'false'
Node #23 at (l=20.0, t=259.0, r=422.0, b=363.0)px
Focused = 'false'
Text = '[Refresh]'
Actions = [OnClick, RequestFocus, GetTextLayoutResult]
MergeDescendants = 'true'

Comments

ys...@google.com <ys...@google.com> #2Apr 17, 2023 08:47AM

@stevebower not sure how critical this is, maybe it's purely secondary metadata. But just in case it does break A11y, flagging.

st...@google.com <st...@google.com> Apr 18, 2023 03:50PM

Assigned to st...@google.com.

st...@google.com <st...@google.com> Apr 19, 2023 05:39PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Apr 19, 2023 05:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit c663bd737d522f962e0403e3cfb8c028bf1c0f1b
Author: stevebower <stevebower@google.com>
Date: Wed Apr 19 12:34:36 2023

Add missing semantic Button role for Chip and CompactChip

Restore the Button role for Chip and CompactChip, which was provided when calling the base Chip implementation in earlier versions, but was missing following refactoring to material-core.

Test: androidx.wear.compose.material tests
Bug: 277326264
Relnote: "We have fixed a bug in Chip and CompactChip where the semantic role was no longer being set to Role.Button."
Change-Id: I93f91a670052b94387349e6ac9e1373353c1e4e2

M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/ChipTest.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Chip.kt
M wear/compose/compose-material3/src/androidAndroidTest/kotlin/androidx/wear/compose/material3/ButtonTest.kt

https://android-review.googlesource.com/2547170

st...@google.com <st...@google.com> #4Apr 19, 2023 05:39PM

See aosp/2547170 for fix

na...@google.com <na...@google.com> #5May 10, 2023 07:08PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material:1.2.0-alpha10
androidx.wear.compose:compose-material3:1.0.0-alpha04

Issue 277326264