BasicTextField2 draft APIs [277380808]

Fixed

Project

Status Update

No update yet.

Description

kl...@google.com

created issue #1

Apr 7, 2023 10:05PM

Tracking bug for CLs related to the TextField API rewrite project.

Ideally, we would have tagged this bug on all related CLs, but we didn't think of doing that until now so I'll just list the ones up to the time of filing here. Future CLs should tag this bug with:

Bug: b/277380808

Comments

kl...@google.com <kl...@google.com> #2Apr 7, 2023 10:25PM

Thanks! This looks like a bug, thank you for reporting!

ap...@google.com <ap...@google.com> #3Apr 8, 2023 02:25AM

I would also recommend setting the value to 10%. When you do that, the behavior is wild.

Dragging up to 10% or between 50% and 90% will cause it to snap back to the start anchor.
Dragging between 10% and 50% or past 90% will cause it to snap to the end anchor.

ap...@google.com <ap...@google.com> #4Apr 11, 2023 08:27AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3278651

Update AnchoredDraggable target calculation logic

Expand for full commit details

Update AnchoredDraggable target calculation logic

We were previously relying on currentValue and the next closest anchor in the drag direction, but the simpler and more reliable way is to look at the left and right anchors as the window.

Relnote: Fixed a bug where positional thresholds passed to AnchoredDraggableDefaults.flingBehavior were not considered correctly in some scenarios.
Test: anchoredDraggable_fling_offsetPastHalfwayBetweenAnchors_beforePosThreshold_doesntAdvance
Bug: 367660226
Bug: 366003852
Change-Id: Ifdf0dfcf3d7ff8288affee56e7092bbed473d6ab

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt
D compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableTestState.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

Hash: eff53304942e9fd4fa5382e0cf487a734c5b8d28
Date: Thu Sep 19 16:24:55 2024

ap...@google.com <ap...@google.com> #5Apr 11, 2023 07:54PM

Any estimate on when will this release?

ap...@google.com <ap...@google.com> #6Apr 11, 2023 07:54PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha04
androidx.compose.foundation:foundation-android:1.8.0-alpha04
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha04

ap...@google.com <ap...@google.com> #7Apr 11, 2023 09:42PM

Using the new version 1.8.0-alpha04 does not seem to resolve the issue for me. I tested with the same setting as the reported issue:

            // it doesn't matter what you put here a the multiplier, the positionalThreshold is always 50%
            positionalThreshold = { d -> d * 0.9f },
            velocityThreshold = { Float.POSITIVE_INFINITY },

ap...@google.com <ap...@google.com> #8Apr 12, 2023 05:38PM

Same. I've run this again on 1.8.0-alpha04. When using

positionalThreshold = { d -> d * 0.1f }

Dragging up to 10% or between 50% and 90% will cause it to snap back to the start anchor. Dragging between 10% and 50% or past 90% will cause it to snap to the end anchor.

I would expect It to only return if dragged less than or equal to 10% and snap to the end if dragged greater than 10%.

When using

positionalThreshold = { d -> d * 0.9f }

It acts as if the threshold has been set to 50%.

From what I can tell, nothing has changed about the behavior.

ap...@google.com <ap...@google.com> #9Apr 12, 2023 07:17PM

Thanks, we will investigate and update this issue.

ap...@google.com <ap...@google.com> #10Apr 12, 2023 09:09PM

I can confirm that with version 1.8.0-alpha04. No matter what you pass to AnchoredDraggableDefaults.flingBehavior(positionalThreshold = {}) it is not respected.

ap...@google.com <ap...@google.com> #11Apr 12, 2023 10:41PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3343747

Update AnchoredDraggable target calculation logic

Expand for full commit details

Update AnchoredDraggable target calculation logic 
 
There was a missed case when the velocity was negative. 
 
Test: New tests with more parameter permutations 
Fixes: 367660226 
Bug: 376931805 
Relnote: "Follow-up fix for an issue in AnchoredDraggable's target calculation where it could settle at the wrong anchor for specific swipes." 
Change-Id: I23b8773d3a694aa3c8de6a8f34b9d7fb54cfe560

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

Hash: 6a23aa4ee37ba171475e4155db0d24c90b358c7e
Date: Fri Nov 08 14:11:31 2024

ap...@google.com <ap...@google.com> #12Apr 13, 2023 12:23AM

What is the fix version?

lo...@gmail.com <lo...@gmail.com> #13May 4, 2023 05:53PM

We will comment on the issue when it has been included in a release. Until then, you can try the snapshot versions from androidx.dev.

ap...@google.com <ap...@google.com> #14Jun 27, 2023 06:33PM