IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date:   Mon Jan 02 15:27:40 2023

    fix: tab row crashes when only 1 tab is added
   
    Bug: b/264018028
   
    Test: Added unit test
   
    Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M       tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M       tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

Project: platform/frameworks/support
Branch: androidx-main

commit 1d34c1131045ecfad3a6b4e2697d169ab1789618
Author: Halil Ozercan <halilibo@google.com>
Date:   Tue Apr 11 17:13:03 2023

    Re-show keyboard when clicked on already focused BasicTextField2
   
    Bug: b/277380808
   
    Test: BasicTextField2Test
    Change-Id: Iac78062a8f62fc647c3c5c0fc99cc1ce5852f25d

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt

https://android-review.googlesource.com/2531361

Project: platform/frameworks/support
Branch: androidx-main

commit b5bab9536501b06bbd7c3ca6f0db97b8ce0ced61
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Tue Apr 11 12:29:15 2023

    Rename TextFieldState.value property to text.
   
    Bug: b/277380808
    Test: n/a, just a rename
    Relnote: n/a
    Change-Id: I02b1210db4004b1dfe8c86d752359367aa7bd977

M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/DecorationBoxDemos.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2SemanticsTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/DecorationBoxTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldCursorTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldKeyEventTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldScrollTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldStateRestorationTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputAdapterTest.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicTextField2.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldState.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputAdapter.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldCoreModifier.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextPreparedSelection.kt
M       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text2/input/TextFieldStateSaverTest.kt
M       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text2/input/TextFieldStateTest.kt

https://android-review.googlesource.com/2531861

Project: platform/frameworks/support
Branch: androidx-main

commit 5896bd6496949a7f042ae812b59244401c455dba
Author: Halil Ozercan <halilibo@google.com>
Date:   Wed Apr 12 03:09:14 2023

    Apply SingleLineCodepointTransformation to SingleLine BasicTextField2
   
    Bug: b/277380808
   
    When BasicTextField2 receives `TextFieldLineLimits.SingleLine`, it implies a generic behavior for single line configuration, extending beyond scroll and layout. One implication is that the content inside single line BasicTextField2 should override LINE_FEED and CARRIAGE_RETURN characters to always present it on a single line since scroll is only allowed horizontally.
   
    This change adds a singleton `SingleLineCodepointTransformation` that's applied on BasicTextField2 if no other CodepointTransformation is specified (including `CodepointTransformation.None`). This `CodepointTransformation` replaces LINE_FEED(\n) and CARRIAGE_RETURN(\r) characters with WHITESPACE(' ') and ZERO_WIDTH_NO_BREAK(U+FEFF) respectively.
   
    Test: TextFieldCodepointTransformationTest
    Change-Id: I331791831d5d64add740d244922a94953aa58cd3

M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldCodepointTransformationTest.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicTextField2.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/CodepointTransformation.kt

https://android-review.googlesource.com/2531131

Project: platform/frameworks/support
Branch: androidx-main

commit c7d5297dc486756de986852df12f177c58864d81
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Tue Apr 11 14:04:55 2023

    Add extensions to TextFieldState for observing changes.
   
    forEachTextValue is intended to be a more simple and discoverable
    way to observe state changes from outside of Composables than requiring
    the knowledge and use of low-level Snapshot APIs.
   
    Also annotates TextFieldState as @Stable and adds a bunch of samples and
    docs.
   
    Bug: b/277380808
    Test: TextFieldStateTest
    Relnote: n/a
    Change-Id: I8bf0f6d4c60d431744dfa134feb37e4a2cdbe2f4

M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicTextField2Samples.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldState.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/EditProcessor.kt
M       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text2/input/TextFieldStateTest.kt

https://android-review.googlesource.com/2532241

Project: platform/frameworks/support
Branch: androidx-main

commit 896cb13251c8f135b3a2a2d058d3024c382268d8
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Wed Apr 12 11:42:05 2023

    Polish the documentation for BasicTextField2.
   
    Bug: b/277380808
    Test: n/a
    Relnote: n/a
    Change-Id: Ida2413908b80bd45c8ca2bf885462a07ccf78f94

M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditFilter.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditResult.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldBuffer.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldBufferWithSelection.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldCharSequence.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldLineLimits.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldState.kt

https://android-review.googlesource.com/2533841

Project: platform/frameworks/support
Branch: androidx-main

commit a33f98c60601b1b62c685c41df2b70b834a5e910
Author: Halil Ozercan <halilibo@google.com>
Date:   Wed Apr 12 20:51:48 2023

    BasicTextField2 further docs polish
   
    Bug: b/277380808
    Test: N/A
    Change-Id: Ia0ee67d5077b784631bff9ef63ce212926f792f5

M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicSecureTextField.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicTextField2.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditFilter.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextEditResult.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldBuffer.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldBufferWithSelection.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldLineLimits.kt

https://android-review.googlesource.com/2534419

Project: platform/frameworks/support
Branch: androidx-main

commit a3c2042a21930d2e820f06fa5db63865b41e33d9
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Wed Apr 12 15:48:34 2023

    Add a demo of building a custom PIN input with BasicTextField2.
   
    Also added TextFieldState.clearText().
   
    Screencast: http://screencast/cast/NjI0OTUxODk2MzA5NzYwMHw5NDQ3NTgyMC00Mg
   
    Bug: b/277380808
    Test: n/a
    Relnote: n/a
    Change-Id: I71876e87dd4aee62cd91980c3ec6bf43e17f508c

M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/BasicTextField2CustomPinFieldDemo.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/TextFieldState.kt

https://android-review.googlesource.com/2534243

Project: platform/frameworks/support
Branch: androidx-main

commit 0d92f9936b46c7f380d4114c1334f1eca5e2818f
Author: Zach Klippenstein <klippenstein@google.com>
Date:   Fri Mar 10 14:27:30 2023

    Rewrite PlatformTextInput* to be more session-oriented.
   
    This completely changes how text input clients interact with the
    PlatformTextInput system. Instead of reading a composition local to get
    the registry, and then asking the registry for the adapter for their
    plugin, they now must implement a Modifier.Node that implements the
    PlatformTextInputModifierNode interface. Such nodes have access to a
    suspend function that will show the keyboard and ask the system to start
    a new input session. The function takes platform-specific input that
    specifies how to wire up to the platform APIs. The lifetime of the
    coroutine is tied to the lifetime of the input session: the function
    will suspend the calling coroutine until the session is closed, and
    cancelling the coroutine early will close the session. When the last
    session is closed the keyboard will automatically be hidden.
   
    See go/platform-text-input for more info.
   
    PlatformTextInput APIs were originally introduced in aosp/2406439.
   
    Fixes: b/274661182
    Fixes: b/267235947
    Bug: b/277380808
    Test: AndroidTextInputSessionRequestTest
    Test: AndroidPlatformTextInputSessionTest
    Test: NullableInputConnectionWrapperTest
    Test: SessionMutexTest
    Test: PlatformTextInputViewIntegrationTest
    Test: DesktopTextInputSessionTest
    Relnote: "Completely redesigned `PlatformTextInput*` API."
    Change-Id: I6c93a1111561b5cb55c6a34e2fc3738be3c8941d

M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/PlatformTextInputAdapterDemo.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/BasicTextField2Demos.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2ImmIntegrationTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/BasicTextField2Test.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/TextFieldKeyboardActionsTest.kt
D       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputAdapterTest.kt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputSessionTest.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/BasicTextField2.kt
D       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputAdapter.kt
D       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputPlugin.kt
A       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/AndroidTextInputSession.android.kt
M       compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text2/input/internal/TextFieldDecoratorModifier.kt
D       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text2/input/internal/TextInputCommandExecutorTest.kt
M       compose/ui/ui-text/api/current.txt
M       compose/ui/ui-text/api/restricted_current.txt
D       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputAdapter.android.kt
A       compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputMethodRequest.android.kt
D       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputAdapter.kt
A       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputMethodRequest.kt
M       compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
D       compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputAdapter.desktop.kt
A       compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/input/PlatformTextInputMethodRequest.desktop.kt
M       compose/ui/ui/api/current.ignore
M       compose/ui/ui/api/current.txt
M       compose/ui/ui/api/restricted_current.ignore
M       compose/ui/ui/api/restricted_current.txt
A       compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/PlatformTextInputModifierNodeSample.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/Helpers.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/LocalSoftwareKeyboardControllerTest.kt
A       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/AndroidPlatformTextInputSessionTest.kt
A       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/PlatformTextInputAdapterRegistryTest.kt
D       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/PlatformTextInputEditTextIntegrationTest.kt
M       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/PlatformTextInputViewIntegrationTest.kt
A       compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/text/input/TestInputMethodRequest.kt
M       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
A       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidPlatformTextInputSession.kt
A       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/PlatformTextInputSession.android.kt
D       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/AndroidTextInputServicePlugin.kt
A       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.kt
M       compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/AtomicReference.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/SessionMutex.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
A       compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/PlatformTextInputModifierNode.kt
M       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeLayer.desktop.kt
M       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopPlatformInput.desktop.kt
A       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputSession.kt
M       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformComponent.desktop.kt
A       compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/PlatformTextInputSession.desktop.kt
A       compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/DesktopTextInputSessionTest.kt
A       compose/ui/ui/src/jvmMain/kotlin/androidx/compose/ui/AtomicReference.jvm.kt
M       compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/PlatformInput.skiko.kt
M       compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaBasedOwner.skiko.kt
A       compose/ui/ui/src/test/kotlin/androidx/compose/ui/SessionMutexTest.kt
M       compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M       compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/ModifierLocalConsumerEntityTest.kt
M       compose/ui/ui/src/test/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroidCommandDebouncingTest.kt
M       development/build_log_simplifier/messages.ignore

https://android-review.googlesource.com/2607868

Project: platform/frameworks/support
Branch: androidx-main

commit c7d007e2d42935c757bdb47677781f06cf5629ef
Author: Halil Ozercan <halilibo@google.com>
Date:   Sat Apr 01 07:23:46 2023

    KeyboardActions Demos for BTF2
   
    Bug: b/277380808
   
    Test: just a demo change
    Change-Id: I9878ddd81196040f0d8a5bcd53ccc236e081588f

M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text2/KeyboardActionsDemos.kt

https://android-review.googlesource.com/2518875