Remove the deprecation in PlatformTextStyle that includes includeFontPadding [277703184]

Fixed

Feature Request

Status Update

No update yet.

Description

st...@google.com

created issue #1

Apr 11, 2023 08:35AM

PlatformTextStyle API with the option to switch includeFontPadding true/false was introduced back in compose UI 1.2.0-alpha07 (feature request). The method is deprecated to signal this is a compatibility API but this is confusing for devs, as they see this deprecation and believe they should not be using this API/they try to find an alternative one.

We should remove this deprecation as a first step to encourage usage of this API, and potentially bring back once we flip the switch.

Comments

si...@google.com <si...@google.com> Apr 13, 2023 05:33PM

Accepted by si...@google.com.

ap...@google.com <ap...@google.com> #2Apr 14, 2023 06:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 040485696a1bb5f543344c62b69eca3de65d5f46
Author: siyamed <siyamed@google.com>
Date: Thu Apr 13 10:20:06 2023

un-deprecate includeFontPadding

RelNote: "PlatformTextStyle.includeFontPadding is
undeprecated. Our original intent was to remove the
field, however the feedback shows that developers
need this configuration option. Therefore removing
deprecation from the field"

Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 277703184
Change-Id: I98e96222691d8e5d023cd22b899f0dfbae2a1e1d

M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt

https://android-review.googlesource.com/2534105

si...@google.com <si...@google.com> Apr 14, 2023 10:33PM

Marked as fixed.

na...@google.com <na...@google.com> #3May 10, 2023 07:08PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui-text:1.5.0-alpha04

ju...@google.com <ju...@google.com> #4May 24, 2023 07:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui-text-android:1.5.0-beta01

Issue 277703184