Remove the deprecation in PlatformTextStyle that includes includeFontPadding [277703184]

Fixed

Feature Request

Status Update

No update yet.

Description

st...@google.com

created issue #1

Apr 11, 2023 08:35AM

PlatformTextStyle API with the option to switch includeFontPadding true/false was introduced back in compose UI 1.2.0-alpha07 (feature request). The method is deprecated to signal this is a compatibility API but this is confusing for devs, as they see this deprecation and believe they should not be using this API/they try to find an alternative one.

We should remove this deprecation as a first step to encourage usage of this API, and potentially bring back once we flip the switch.

Comments

si...@google.com <si...@google.com> Apr 13, 2023 05:33PM

Accepted by si...@google.com.

ap...@google.com <ap...@google.com> #2Apr 14, 2023 06:32PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

si...@google.com <si...@google.com> Apr 14, 2023 10:33PM

Marked as fixed.

na...@google.com <na...@google.com> #3May 10, 2023 07:08PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ju...@google.com <ju...@google.com> #4May 24, 2023 07:36PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

Issue 277703184