SwipeToDismissNavHost should apply HierarchicalFocusControl [277852486]

Fixed

Bug

Status Update

No update yet.

Description

yu...@schimke.ee

created issue #1

Apr 12, 2023 09:03AM

Component used: wear compose-navigation Version used:1.2.0-alpha07 Devices/Android versions reproduced on:

Should SwipeDismissableNavHost control the focus automatically? Or SwipeToDismissBox.

For example wrap content with the following

@Composable
internal fun FocusedDestination(content: @Composable () -> Unit) {
    val lifecycle = LocalLifecycleOwner.current.lifecycle
    val focused =
        remember { mutableStateOf(lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)) }

    DisposableEffect(lifecycle) {
        val listener = LifecycleEventObserver { _, _ ->
            focused.value = lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)
        }
        lifecycle.addObserver(listener)
        onDispose {
            lifecycle.removeObserver(listener)
        }
    }

    HierarchicalFocusCoordinator(requiresFocus = { focused.value }) {
        content()
    }
}

Comments

st...@google.com <st...@google.com> Apr 17, 2023 09:25AM

Assigned to ss...@google.com.

ap...@google.com <ap...@google.com> #2Jul 5, 2023 01:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit c2357da0e6357c2b865904e64785529ea8781292
Author: Sergio Sancho <ssancho@google.com>
Date: Thu Jun 22 12:17:12 2023

Improve focus handling using the HierarchicalFocusCoordinator

* Added support for HFC in SwipeToDismissBox, so while doing a swipe
gesture only the screen on top (and not the background screen) can
have the focus.
* Minor fix to the the demo app to work better with HFC.

Bug: 277852486
Relnote: "Improve focus handling using the HierarchicalFocusCoordinator"
Test: Manual + Added

Change-Id: I45362046141d2460c65f392650000c9b86aef6a5

M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/SwipeToDismissBoxTest.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/SwipeToDismissBox.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/DemoApp.kt

https://android-review.googlesource.com/2617451

ss...@google.com <ss...@google.com> Jul 5, 2023 01:18PM

Marked as fixed.

na...@google.com <na...@google.com> #3Jul 26, 2023 05:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-foundation:1.3.0-alpha02

Issue 277852486

Description

Issue summary

Comments

st...@google.com <st...@google.com> Apr 17, 2023 09:25AM

ap...@google.com <ap...@google.com> #2Jul 5, 2023 01:18PM

ss...@google.com <ss...@google.com> Jul 5, 2023 01:18PM

na...@google.com <na...@google.com> #3Jul 26, 2023 05:21PM

Add comment

Issue metadata