Fixed
Status Update
Comments
ss...@google.com <ss...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
https://android-review.googlesource.com/1114511
https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
pr...@google.com <pr...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
https://android-review.googlesource.com/1123398
https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
Description
See the attached video for examples of this (specifically, circle -> circle and Alice (irregular triangle) -> Alice