AGP model building fails with nested gradle composite builds [278096743]

Fixed

Bug

Status Update

No update yet.

Description

ka...@gmail.com

created issue #1

Apr 15, 2023 01:41AM

DESCRIBE THE ISSUE IN DETAIL:
AGP failed during syncing project, where there is composite build (includeBuild) of project with, in order, another composite build (i.e. nested composite build).

STEPS TO REPRODUCE:

Create android application project "root/app", and two android library projects: "root/lib1" and "root/lib2"
In "root/app/settings.gradle.kts" includeBuild("../lib1")
In "root/lib1/settings.gradle.kts" includeBuild("../lib2")
sync project app failed with error "Failed to get Gradle name for :"

Full example is attached.

Studio Build: Android Studio Giraffe | 2022.3.1 Canary 11 (Build #AI-223.8836.35.2231.9848316, built on March 30, 2023)
Version of Gradle Plugin: 8.1.0-alpha11
Version of Gradle: 8.0
Version of Java: JetBrains Runtime version 17.0.6
OS: Windows 11

The cause of problem is in com.android.build.gradle.internal.ide.v2.ModelBuilder.
Look into method getBuildName(). There is condition

it.projectDir == currentGradle.rootProject.projectDir

According to Gradle docs, nested composite build structure is flattened, i.e. all the included (and syb-included) projects have same root. See Gradle updated docs in https://github.com/gradle/gradle/pull/24469/files#diff-07fc669ece55f938ee36f360129142a0576f95381ffe9c7f737ce6fe69499993

So when executing on sub-included project (lib2) the condition above will be false, because
parentGradle will be app instead of lib1
parentGradle.includedBuilds will be lib1 instead of lib2
As a result, it.projectDir === lib1, when currentGradle.rootProject.projectDir === lib2

So it is needed to fix getBuildName to solve the problem.

example.zip

171 KB

Download

Comments

em...@google.com <em...@google.com> Apr 17, 2023 11:08PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Apr 25, 2023 04:33AM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Jul 27, 2023 05:05PM

Marked as fixed.

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

ka...@gmail.com <ka...@gmail.com> #3Feb 11, 2024 04:59PM

the fractional part of the location data is exactly the same.

Message last modified on Feb 11, 2024 04:59PM

ga...@google.com <ga...@google.com> #4Feb 12, 2024 10:42AM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

ka...@gmail.com <ka...@gmail.com> #5Feb 12, 2024 01:27PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

ga...@google.com <ga...@google.com> #6Feb 12, 2024 02:36PM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please