AGP model building fails with nested gradle composite builds [278096743]

Fixed

Bug

Status Update

No update yet.

Description

ka...@gmail.com

created issue #1

Apr 15, 2023 01:41AM

DESCRIBE THE ISSUE IN DETAIL:
AGP failed during syncing project, where there is composite build (includeBuild) of project with, in order, another composite build (i.e. nested composite build).

STEPS TO REPRODUCE:

Create android application project "root/app", and two android library projects: "root/lib1" and "root/lib2"
In "root/app/settings.gradle.kts" includeBuild("../lib1")
In "root/lib1/settings.gradle.kts" includeBuild("../lib2")
sync project app failed with error "Failed to get Gradle name for :"

Full example is attached.

Studio Build: Android Studio Giraffe | 2022.3.1 Canary 11 (Build #AI-223.8836.35.2231.9848316, built on March 30, 2023)
Version of Gradle Plugin: 8.1.0-alpha11
Version of Gradle: 8.0
Version of Java: JetBrains Runtime version 17.0.6
OS: Windows 11

The cause of problem is in com.android.build.gradle.internal.ide.v2.ModelBuilder.
Look into method getBuildName(). There is condition

it.projectDir == currentGradle.rootProject.projectDir

According to Gradle docs, nested composite build structure is flattened, i.e. all the included (and syb-included) projects have same root. See Gradle updated docs in https://github.com/gradle/gradle/pull/24469/files#diff-07fc669ece55f938ee36f360129142a0576f95381ffe9c7f737ce6fe69499993

So when executing on sub-included project (lib2) the condition above will be false, because
parentGradle will be app instead of lib1
parentGradle.includedBuilds will be lib1 instead of lib2
As a result, it.projectDir === lib1, when currentGradle.rootProject.projectDir === lib2

So it is needed to fix getBuildName to solve the problem.

example.zip

171 KB

Download

Comments

em...@google.com <em...@google.com> Apr 17, 2023 11:08PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Apr 25, 2023 04:33AM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Jul 27, 2023 05:05PM

Marked as fixed.

Thanks for reporting this issue. I've verified that it is fixed in AGP 8.2.0-alpha14 as there were some changes around composite build support in Gradle 8.x.

Change id: I019829a162008678bfefa120d26419555e028326

ka...@gmail.com <ka...@gmail.com> #3Feb 11, 2024 04:59PM

Still is reproducible in AGP 8.2.2

Message last modified on Feb 11, 2024 04:59PM

ga...@google.com <ga...@google.com> #4Feb 12, 2024 10:42AM

Using the example project from #1 (upgraded AGP to 8.2.2 and Gradle to 8.2) in Studio Jellyfish Canary 8 I was unable to reproduce the project.

Can you please share a Studio version that reproduces the issue for you or a new sample project?

ka...@gmail.com <ka...@gmail.com> #5Feb 12, 2024 01:27PM

My bad.
In real project I still used com.android.tools.build:gradle:8.1.4
As only I have changed it to 8.2.2, all works fine :)

Thanks to the team for fix!

ga...@google.com <ga...@google.com> #6Feb 12, 2024 02:36PM

Great, thanks for confirmation!