GetterSetterNames API lint does not work for boolean constructor params [278505954]

In Progress

Bug

Status Update

No update yet.

Description

of...@google.com

created issue #1

Apr 17, 2023 08:58AM

CL is this https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2539851/5

Test androidx_incremental failing with error:

src/main/java/androidx/bluetooth/AdvertiseParams.kt:28: error: Getter for boolean property `shouldIncludeDeviceAddress` is named `getShouldIncludeDeviceAddress` but should match the property name. Use `@get:JvmName` to rename. [GetterSetterNames]
src/main/java/androidx/bluetooth/AdvertiseParams.kt:31: error: Getter for boolean property `shouldIncludeDeviceName` is named `getShouldIncludeDeviceName` but should match the property name. Use `@get:JvmName` to rename. [GetterSetterNames]

Artifact viewer for the test: https://android-build.googleplex.com/builds/pending/P54624719/androidx_incremental/latest/view/logs/build_error.log

I have added the requested flag @get:JvmName

    /* Whether the device address will be included in the advertisement packet. */
    @get:JvmName("shouldIncludeDeviceAddress")
    val shouldIncludeDeviceAddress: Boolean = false,

but running ./gradlew :bluetooth:bluetooth:updateApi :bluetooth:bluetooth:updateApiLintBaseline does NOT update the api txt files.

Comments

au...@google.com <au...@google.com> Apr 17, 2023 04:49PM

Reassigned to ju...@google.com.

of...@google.com <of...@google.com> #2Apr 18, 2023 01:02AM

After some googling I found

https://github.com/android/camera-samples/blob/master/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/utils/AutoFitPreviewBuilder.kt which does what I want. Would it be possible to fold this into the main library or at least make it configurable without the need for that class?

of...@google.com <of...@google.com> #3Apr 18, 2023 01:50AM

Hi Charcoal,

Are we getting a crop mode here? Thanks!

ju...@google.com <ju...@google.com> #4Apr 18, 2023 04:32PM

Hello,
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?

ap...@google.com <ap...@google.com> #5Apr 19, 2023 06:41PM

The captured image file is part of the image file that I've already attached (the right part).

I did not set anything on the Preview use case other than the lens facing.

```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())

cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)

surfaceTexture = it.surfaceTexture
updateTransform()
}

CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```

ap...@google.com <ap...@google.com> #6Apr 20, 2023 08:04PM

Would you also set the same TargetRotation to Preview at onOrientationChanged? Let me know if it works.

ap...@google.com <ap...@google.com> #7Apr 20, 2023 08:04PM

Hi There,

It's been just over a month and we are clearing out issues without response. If you have any feedback please feel free to reopen or file another issue. Thanks!

ju...@google.com <ju...@google.com> Apr 21, 2023 02:20PM

Reassigned to bu...@google.com.

bu...@google.com <bu...@google.com> #8Apr 21, 2023 02:20PM

Accepted by bu...@google.com.

This should be caused by same root cause of

https://b.corp.google.com/issues/148763432.
There is default aspect ratio custom set to ImageCapture use case but it is not updated to match the new target rotation value.

ap...@google.com <ap...@google.com> #9Aug 28, 2023 08:33PM

Project: platform/tools/metalava
Branch: metalava-main

commit 529c0bffb433cf7c23752eec0b86ab080e6b97f7
Author: Jinseong Jeon <jsjeon@google.com>
Date: Mon Aug 28 11:05:58 2023

Conditionally enable GetterSetterNames API Lint for constructor parameter

Bug: 278505954
Test: split into K1/K2 versions
Change-Id: Ideac68199681f82b6ca2f35833218afdfe9b2327

M src/main/java/com/android/tools/metalava/ApiLint.kt
M src/test/java/com/android/tools/metalava/ApiLintTest.kt
M src/test/java/com/android/tools/metalava/DriverTest.kt
M src/test/java/com/android/tools/metalava/UastTestBase.kt

https://android-review.googlesource.com/2729354

ap...@google.com <ap...@google.com> #10Aug 29, 2023 03:22PM

Project: platform/prebuilts/androidx/external
Branch: androidx-main

commit 8ba4b2392251ed318517d510ebdb9db296ac748d
Author: Jinseong Jeon <jsjeon@google.com>
Date: Mon Aug 28 16:30:44 2023

Update Metalava for build ID 10726547

$ ./development/importMaven/importMaven.sh \
--metalava-build-id 10726547
--redownload com.android.tools.metalava:metalava:1.0.0-alpha09

Bug: 278505954
Change-Id: I487fa0677e2a15007bf61019ed3f2894a59f4023

A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/LICENSE
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.jar
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.jar.md5
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.jar.sha1
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.module
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.module.md5
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.module.sha1
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.pom
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.pom.md5
A com/android/tools/metalava/metalava-model-psi/1.0.0-alpha09/metalava-model-psi-1.0.0-alpha09.pom.sha1
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.jar
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.jar.md5
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.jar.sha1
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.module
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.module.md5
M com/android/tools/metalava/metalava-model-text/1.0.0-alpha09/metalava-model-text-1.0.0-alpha09.module.sha1
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.jar
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.jar.md5
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.jar.sha1
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.module
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.module.md5
M com/android/tools/metalava/metalava-model/1.0.0-alpha09/metalava-model-1.0.0-alpha09.module.sha1
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.jar
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.jar.md5
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.jar.sha1
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.module
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.module.md5
M com/android/tools/metalava/metalava-reporter/1.0.0-alpha09/metalava-reporter-1.0.0-alpha09.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.jar
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.jar.md5
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.jar.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.module
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.module.md5
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.module.sha1
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.pom
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.pom.md5
M com/android/tools/metalava/metalava/1.0.0-alpha09/metalava-1.0.0-alpha09.pom.sha1

https://android-review.googlesource.com/2729339

ap...@google.com <ap...@google.com> #11Aug 29, 2023 03:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 12f96858e4b9f1a5e8b56555fa101a8ca30c7b3d
Author: Jinseong Jeon <jsjeon@google.com>
Date: Mon Aug 28 16:49:20 2023

Update API signature after Metalava build ID 10726547

which includes a partial enablement of SetterGetterNames API Lint
only for modules that are opt-in to use Metalava w/ K2 UAST.

For those modules, in particular, those that can benefit from
@get:JvmName as per

http://aosp/2722255, that API Lint found boolean
constructor property whose accessor names don't match. This commit
changes those accessors with @get:JvmName, and update APIs accordingly.

RelNote: N/A
Bug: 278505954
Test: ./gradlew checkApi
Change-Id: I80695aa085da7707fdd97438d40e136f73c28712

M benchmark/benchmark-common/api/1.2.0-beta05.txt
M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_1.2.0-beta05.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MicrobenchmarkConfig.kt
M health/connect/connect-client/api/current.txt
M health/connect/connect-client/api/restricted_current.txt
M health/connect/connect-client/src/main/java/androidx/health/connect/client/response/ChangesResponse.kt
M playground-common/playground.properties

https://android-review.googlesource.com/2729637

bu...@google.com <bu...@google.com> Jan 4, 2024 08:07PM

Assigned to ju...@google.com.

ju...@google.com <ju...@google.com> #12Jan 10, 2024 04:21PM

Reassigned to bu...@google.com.

Added b/271369023 as a blocker for fully reenabling the check (removing the flag from aosp/2729354)

bu...@google.com <bu...@google.com> #13Jan 10, 2024 04:22PM

Accepted by bu...@google.com.

Hi. I've received your bug, you didn't specify what to wait for so I will wait for

b/257444932

to be resolved and wait for

b/271369023

to be resolved and then assign the bug to juliamcclellan@google.com.

Bugjuggler:

b/257444932

b/271369023

-> assigned to juliamcclellan@google.com

bu...@google.com <bu...@google.com> Oct 26, 2024 12:36AM

Assigned to ju...@google.com.

ju...@google.com <ju...@google.com> Dec 19, 2024 05:45PM

Reassigned to bu...@google.com.

bu...@google.com <bu...@google.com> #14Dec 19, 2024 05:45PM

Accepted by bu...@google.com.

Hi. I've received your bug, you didn't specify what to wait for so I will wait for

b/257444932

to be resolved, wait for

b/271369023

to be resolved and wait for

b/385140979

to be resolved and then assign the bug to juliamcclellan@google.com.

Bugjuggler:

b/257444932

b/271369023

b/385140979

-> assigned to juliamcclellan@google.com

Issue 278505954

Description

Issue summary

Comments

au...@google.com <au...@google.com> Apr 17, 2023 04:49PM

of...@google.com <of...@google.com> #2Apr 18, 2023 01:02AM

of...@google.com <of...@google.com> #3Apr 18, 2023 01:50AM

ju...@google.com <ju...@google.com> #4Apr 18, 2023 04:32PM

ap...@google.com <ap...@google.com> #5Apr 19, 2023 06:41PM

ap...@google.com <ap...@google.com> #6Apr 20, 2023 08:04PM

ap...@google.com <ap...@google.com> #7Apr 20, 2023 08:04PM

ju...@google.com <ju...@google.com> Apr 21, 2023 02:20PM

bu...@google.com <bu...@google.com> #8Apr 21, 2023 02:20PM

ap...@google.com <ap...@google.com> #9Aug 28, 2023 08:33PM

ap...@google.com <ap...@google.com> #10Aug 29, 2023 03:22PM

ap...@google.com <ap...@google.com> #11Aug 29, 2023 03:22PM

bu...@google.com <bu...@google.com> Jan 4, 2024 08:07PM

ju...@google.com <ju...@google.com> #12Jan 10, 2024 04:21PM

bu...@google.com <bu...@google.com> #13Jan 10, 2024 04:22PM

bu...@google.com <bu...@google.com> Oct 26, 2024 12:36AM

ju...@google.com <ju...@google.com> Dec 19, 2024 05:45PM

bu...@google.com <bu...@google.com> #14Dec 19, 2024 05:45PM

Add comment

Issue metadata