IssueTracker

Okay. I tried a bunch of agp+android studio versions

The last working version was classpath("com.android.tools.build:gradle:7.4.0-alpha06")

once I moved to

classpath("com.android.tools.build:gradle:7.4.0-alpha07") then things start breaking on firebase app dist.

Scott, assigning to you as it seem to complain the zip is not aligned while packaging which is very puzzling considering the steps...

OP, when you build the APK with AGP, are you doing any post-processing on the APK and/or do you have any custom tasks that are modifying the APK?

Can you try to verify the alignment of your APK with zipalign locally (zipalign is included in build-tools):

zipalign -c -v 4 foo.apk

Not doing any post processing. No custom tasks. I will try to verify alignment now. Give me a sec.

Scenario 3:

built my apk with agp alpha09, with androidx.splash rc01
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification succesful"

Scenario 4:

built my apk with agp alpha09, with androidx.splash 1.0.0
/Users/idle/Library/Android/sdk/build-tools/31.0.0/zipalign -c -v 4 app-release.apk

"Verification FAILED"

In both failed cases if I do | grep BAD I get

 7216334 junit/runner/logo.gif (BAD - 2)
 7217354 junit/runner/smalllogo.gif (BAD - 2)

In the cases where zipalign verification fails, is the APK generated by a clean build (e.g., ./gradlew clean :app:assembleRelease)?

Does verification succeed if you add this to your build.gradle?

android {
    packagingOptions {
        exclude 'junit/runner/logo.gif'
        exclude 'junit/runner/smalllogo.gif'
    }
}

In the cases where zipalign verification fails, is the APK generated by a clean build (e.g., ./gradlew clean :app:assembleRelease)?

I clean before i generate the apk using the Android Studio menu for generating an apk

Does verification succeed if you add this to your build.gradle?

I assume it will, but let me try. Any reason why changing from androidx.splash 1.0.0-rc01 to 1.0.0 stable (which is 0 changes. all it changed was the dependency version) that it fails verification. It seems like something else is wrong that's a bit deeper than just adding these two exclude statements.

It seems like something else is wrong that's a bit deeper than just adding these two exclude statements.

I agree, but I'd like to find a workaround for you in the meantime.

I think I'll probably need a repro project to get to the bottom of it. In your other thread, it sounded like you weren't able to create a repro project... any luck since then?

I was not able to create a repro unfortunately. As soon as I started to prune things out of my project it started to succeed.

Similarly. firebase came out with a new version. and if i use that new version... then it also succeeds. 🤯

I'm glad to hear there is a workaround for now (and i learned something new about zipalign). I will try to create a repo project again later today when I have about an hour or so free to play around with it, but for now I will just commit the

android {
    packagingOptions {
        exclude 'junit/runner/logo.gif'
        exclude 'junit/runner/smalllogo.gif'
    }
}

to my codebase because that did the trick for me. Everything works. Thank you for your quick response and helpful debugging steps.

Thanks!

Thanks for looking into it!

I agree it's strange they have an implementation dependency on junit, and I'm glad they're removing it in okhttp 5+.

I'll go ahead and close this bug for now.

This is fixed by Change-Id: I12ec8785cd4dbb6e523c66b4620ed2388f448822, which will be in AGP 7.4.0-rc01 and 8.0.0-alpha08.

Thanks for filing the bug, OP. Your observation in comment #2 that alpha07 was the first broken version helped me find the root cause.

FUCK YEAH! Glad I was helpful! Appreciate you working through it with me here. Cheers. Once I update to alpha08 I will remove the workaround I added. cheers

This should be fixed in R8 4.0, 8.0, 8.1, and 8.2 now. It would be great if you could confirm if 8.1.39 works for you. Thanks.

I tested with 8.1.39 and it looks like it is fixed, thank you!

Any idea of what version of AGP this will ship with?

Good to hear! This should land in AGP 8.1 beta 2.