VerifyError: Verifier rejected class when using R8 with Kotlin 1.8.20 [278573402]

Verified

Bug

Status Update

No update yet.

Description

ey...@gmail.com

created issue #1

Apr 18, 2023 03:17AM

After updating Kotlin to 1.8.20 my app crashes in release mode with R8 enabled:

Fatal Exception: java.lang.VerifyError: Verifier rejected class rm3: void rm3.a() failed to verify: void rm3.a(): [0x11] 'this' argument 'Reference: java.lang.Object' not instance of 'Reference: android.content.Intent'

From the mapping, it appears that rm3 is androidx.profileinstaller.ProfileInstallerInitializer$Choreographer16Impl

We're using AGP 8.1.0-alpha11

Comments

ey...@gmail.com <ey...@gmail.com> #2Apr 18, 2023 03:30AM

Thank you for the report and the supplied dump with the reproduction. I can confirm that the NPE is also present on HEAD, and I will look into it.

Quite a few of the class files in the dump has malformed inner-class attribute, where R8 reports e.g.:

Info in /tmp/tmpo67ucguh/program.jar:ofifmwrrhhmodsc/ψξψξψξξ.class:
Malformed inner-class attribute:
	outerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ
	innerTypeInternal: ofifmwrrhhmodsc/ψξψξψξξ$ψξξψξξξ
	innerName: ψξψξψξξ$ψξξψξξξ

These are ignored, so they should not be the reason for the NPE, but something to also look into.

ri...@google.com <ri...@google.com> #3Apr 18, 2023 04:17AM

Reassigned to ri...@google.com.

Project: r8
Branch: main

commit e59500ca4445f5fb5d2ccc1114acbf66df11d196
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:55 2023

Insert patched frame instructions in the right place

Fixes:

b/274337639

Change-Id: Iae204ed529f9af5bf5fa3eaacba45128dfa6fd9e

M src/main/java/com/android/tools/r8/graph/LazyCfCode.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77390

ey...@gmail.com <ey...@gmail.com> #4Apr 18, 2023 04:43AM

Project: r8
Branch: main

commit 780c2e83c8c033e7594d61894fa1b3dbcad6630b
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 09:48:13 2023

Add reproduction of

b/274337639

Bug:

b/274337639

Change-Id: I7573883d6a649eed47b10d7bf0cdea2e11710268

M build.gradle
M src/main/java/com/android/tools/r8/cf/code/frame/UninitializedNew.java
A src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77389

ri...@google.com <ri...@google.com> #5Apr 18, 2023 05:29AM

I will backport this to the 8.0 and 4.0 branches.

ey...@gmail.com <ey...@gmail.com> #6
Restricted
Apr 18, 2023 07:35AM

Comment has been deleted.

deleted

Restricted

0 B

ey...@gmail.com <ey...@gmail.com> #7Apr 18, 2023 07:36AM

Project: r8
Branch: 4.0

commit 6edb00fb23e41b28d4794cfa69d706d5c5aa3fba
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:55:01 2023

Version 4.0.56

Bug:

b/274337639

Change-Id: I88a20fc922ce892d38fa3a34f9a3f1f4714354ae

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77447

ri...@google.com <ri...@google.com> #8Apr 18, 2023 09:20AM

Project: r8
Branch: 4.0

commit d9215af3b02f64d1207b9ebd63a6925229307b9d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:50 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77446

ey...@gmail.com <ey...@gmail.com> #9Apr 18, 2023 12:05PM

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

ri...@google.com <ri...@google.com> #10Apr 18, 2023 12:42PM

Project: r8
Branch: 8.0

commit 6686e7dffea83ea894438b496c065d0a18cda206
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:53:01 2023

Version 8.0.37

Bug:

b/274337639

Change-Id: I43a723a94638088d921cd3fb6e22ef6e41f07d5f

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77444

ey...@gmail.com <ey...@gmail.com> #11Apr 18, 2023 03:27PM

Project: r8
Branch: 8.0

commit 57f55fb70aa678a61f9c7ff1826fbc695faeac7d
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:52:27 2023

Insert patched frame instructions in the right place

Bug:

b/274337639

https://r8-review.googlesource.com/77443

ri...@google.com <ri...@google.com> #12Apr 18, 2023 03:28PM

Project: r8
Branch: 8.0

commit cd00c053222b06bb27fdd90bbed56af9c9ef0744
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:51:57 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77442

ey...@gmail.com <ey...@gmail.com> #13
Restricted
Apr 18, 2023 03:41PM

Comment has been deleted.

deleted

Restricted

0 B

deleted

Restricted

0 B

deleted

Restricted

0 B

ri...@google.com <ri...@google.com> #14Apr 19, 2023 09:03AM

Reassigned to ch...@google.com.

Project: r8
Branch: 4.0

commit 4fda9b9062c871ba0e31cb68d1518b13b993692f
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 16:54:33 2023

Add reproduction of

b/274337639

Bug:

b/274337639

https://r8-review.googlesource.com/77445

ap...@google.com <ap...@google.com> #15Apr 19, 2023 10:56AM

Answer to #comment6. This fix only addresses the NPE.

The malformed inner-class attributes is an issue with the input class files, and they where not related to the NPE. You will have to contact the supplier of the library where they are present if you would like to get rid of the "Info" messages (you will have to run ./gradlew --info ... to see them). From what I can see the issue is that the innerName: ψξψξψξξ$ψξξψξξξ should have been innerName: ψξξψξξξ.

ap...@google.com <ap...@google.com> #16Apr 19, 2023 12:09PM

Project: r8
Branch: 4.0

commit 49f738ff7377dacecf0fca39fec5146beb251ea3
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:14:15 2023

Version 4.0.57

Backport test to 4.0 test APIs.

Bug:

b/274337639

Change-Id: Iecf03a2ad9dcdbd53e6c572d2f08915248435682

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77450

ap...@google.com <ap...@google.com> #17Apr 19, 2023 12:36PM

Project: r8
Branch: 8.0

commit c11ddf096e58245c2c67514dc9e5a2098dd8f705
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Mar 21 18:16:54 2023

Version 8.0.38

Backport test to 8.0 test APIs.

Bug:

b/274337639

Change-Id: I35ae6d701fa92a6a7a734f9c0296d1383fed8e20

M src/main/java/com/android/tools/r8/Version.java
M src/test/java/com/android/tools/r8/cf/frames/InitBeforeNewInInstructionStreamTest.java

https://r8-review.googlesource.com/77451

ap...@google.com <ap...@google.com> #18Apr 19, 2023 12:36PM

deleted

ap...@google.com <ap...@google.com> #19Apr 19, 2023 12:36PM

deleted

ap...@google.com <ap...@google.com> #20Apr 19, 2023 03:06PM

deleted

ap...@google.com <ap...@google.com> #21Apr 19, 2023 03:06PM

Project: r8
Branch: 8.0

commit aa653f09ec2c293dfb1441c41ee3b23c14edbc14
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 19 14:27:02 2023

Ensure redundant array get elimination leads to narrowing

Bug:

b/278573402

Change-Id: I5f4fd4f491ddac40d4e720862ab711220c0be145

M src/main/java/com/android/tools/r8/ir/optimize/RedundantFieldLoadAndStoreElimination.java
M src/test/java/com/android/tools/r8/ir/optimize/redundantarraygetelimination/ArrayGetTypePromotionTest.java

https://r8-review.googlesource.com/78306

ap...@google.com <ap...@google.com> #22Apr 19, 2023 03:06PM

Project: r8
Branch: 8.0

commit 3c78b472e17ff4df1a4cbe7f779963f4551ceac7
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 19 14:26:09 2023

Reproduce VerifyError after redundant array get elimination

Bug:

b/278573402

Change-Id: Ia2c62ad8f7a4c5f2d9333a6514a71f7d8db8720c

A src/test/java/com/android/tools/r8/ir/optimize/redundantarraygetelimination/ArrayGetTypePromotionTest.java

https://r8-review.googlesource.com/78303

ap...@google.com <ap...@google.com> #23Apr 19, 2023 03:06PM

Project: r8
Branch: 4.0

commit 6847d39873c892ae31dd0a0051ede9c029a73e53
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 19 14:29:51 2023

Version 4.0.60

Bug:

b/278573402

Change-Id: I5c3e809529a800a2bd0cf393f12fafb86b9d27c1

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/78308

ap...@google.com <ap...@google.com> #24Apr 19, 2023 03:06PM

Project: r8
Branch: 4.0

commit 44f109564ca44b7457b0426ace67db36a5fbea3a
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 19 14:26:59 2023

Ensure redundant array get elimination leads to narrowing

Bug:

b/278573402

https://r8-review.googlesource.com/78305

ap...@google.com <ap...@google.com> #25Apr 19, 2023 03:06PM

Project: r8
Branch: 4.0

commit 5b029e66087245d269c4c484e553142b9d7dbb22
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Apr 19 14:26:11 2023

Reproduce VerifyError after redundant array get elimination

Bug:

b/278573402

Change-Id: Ia2c62ad8f7a4c5f2d9333a6514a71f7d8db8720c

A src/test/java/com/android/tools/r8/ir/optimize/redundantarraygetelimination/ArrayGetTypePromotionTest.java

https://r8-review.googlesource.com/78304

ap...@google.com <ap...@google.com> #26Apr 19, 2023 03:07PM

b/278573402

https://r8-review.googlesource.com/78306

ap...@google.com <ap...@google.com> #27Apr 19, 2023 03:07PM

b/278573402

Change-Id: Ia2c62ad8f7a4c5f2d9333a6514a71f7d8db8720c

A src/test/java/com/android/tools/r8/ir/optimize/redundantarraygetelimination/ArrayGetTypePromotionTest.java

https://r8-review.googlesource.com/78303

ch...@google.com <ch...@google.com> #28Apr 19, 2023 06:12PM

Verified by ch...@google.com.

This should be fixed in R8 4.0, 8.0, 8.1, and 8.2 now. It would be great if you could confirm if 8.1.39 works for you. Thanks.

ey...@gmail.com <ey...@gmail.com> #29Apr 19, 2023 06:32PM

I tested with 8.1.39 and it looks like it is fixed, thank you!

Any idea of what version of AGP this will ship with?

ch...@google.com <ch...@google.com> #30Apr 19, 2023 06:35PM

Good to hear! This should land in AGP 8.1 beta 2.

Issue 278573402

Description

Issue summary

Comments

ey...@gmail.com <ey...@gmail.com> #2Apr 18, 2023 03:30AM

ri...@google.com <ri...@google.com> #3Apr 18, 2023 04:17AM

ey...@gmail.com <ey...@gmail.com> #4Apr 18, 2023 04:43AM

ri...@google.com <ri...@google.com> #5Apr 18, 2023 05:29AM

ey...@gmail.com <ey...@gmail.com> #6 Restricted Apr 18, 2023 07:35AM

ey...@gmail.com <ey...@gmail.com> #7Apr 18, 2023 07:36AM

ri...@google.com <ri...@google.com> #8Apr 18, 2023 09:20AM

ey...@gmail.com <ey...@gmail.com> #9Apr 18, 2023 12:05PM

ri...@google.com <ri...@google.com> #10Apr 18, 2023 12:42PM

ey...@gmail.com <ey...@gmail.com> #11Apr 18, 2023 03:27PM

ri...@google.com <ri...@google.com> #12Apr 18, 2023 03:28PM

ey...@gmail.com <ey...@gmail.com> #13 Restricted Apr 18, 2023 03:41PM

ri...@google.com <ri...@google.com> #14Apr 19, 2023 09:03AM

ap...@google.com <ap...@google.com> #15Apr 19, 2023 10:56AM

ap...@google.com <ap...@google.com> #16Apr 19, 2023 12:09PM

ap...@google.com <ap...@google.com> #17Apr 19, 2023 12:36PM

ap...@google.com <ap...@google.com> #18Apr 19, 2023 12:36PM

ap...@google.com <ap...@google.com> #19Apr 19, 2023 12:36PM

ap...@google.com <ap...@google.com> #20Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #21Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #22Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #23Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #24Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #25Apr 19, 2023 03:06PM

ap...@google.com <ap...@google.com> #26Apr 19, 2023 03:07PM

ap...@google.com <ap...@google.com> #27Apr 19, 2023 03:07PM

ch...@google.com <ch...@google.com> #28Apr 19, 2023 06:12PM

ey...@gmail.com <ey...@gmail.com> #29Apr 19, 2023 06:32PM

ch...@google.com <ch...@google.com> #30Apr 19, 2023 06:35PM

Add comment

Issue metadata

ey...@gmail.com <ey...@gmail.com> #6
Restricted
Apr 18, 2023 07:35AM

ey...@gmail.com <ey...@gmail.com> #13
Restricted
Apr 18, 2023 03:41PM