Provide a TextFieldValue variant of androidx.compose.material3.SearchBar [278773336]

WAI

Feature Request

Status Update

No update yet.

Description

am...@gmail.com

created issue #1

Apr 18, 2023 09:23PM

Jetpack Compose version: 1.4.1
Jetpack Compose Material 3 version: 1.1.0-beta02
Jetpack Compose component used: androidx.compose.material3.SearchBar
Android Studio Build: #AI-222.4459.24.2221.9862592
Kotlin version: 1.8.20

Currently the query parameter of SearchBar component is only String, there is no TextFieldValue variant which would allow us to control the selection, etc.

Comments

am...@gmail.com <am...@gmail.com> #2Sep 3, 2023 06:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023

[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.

This enables standardBottomSheet to implement a fully Hidden state should the user choose to.

Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape

Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d

M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt

https://android-review.googlesource.com/2500395

am...@gmail.com <am...@gmail.com> #3Oct 3, 2023 11:08AM

Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.

am...@gmail.com <am...@gmail.com> #4Dec 25, 2023 11:49AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-beta02

ap...@google.com <ap...@google.com> #5Mar 28, 2024 06:00PM

I'm facing this issue again in the new version of material3 1.2.0.alpha-05, It was working fine until alpha-04 but the moment I change it to 05 the app crashes and I get this error. I am also facing this issue if I change the foundation version from 1.6.0-alpha02 to 1.6.0-alpha03

ma...@google.com <ma...@google.com> #6Mar 29, 2024 08:12PM

Status: Won't Fix (Intended Behavior)

Same here as described in #5 the issue seems back in 1.2.0-alpha05 and was working fine on 1.2.0-alpha04 and before. However, this time it doesn't seem to be working even with the defaults (which uses PartiallyExpanded as initialState internally). I've created a new bug ticket for this: b/296707223.

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

Crashing for me as well on `1.2.0-alpha06`

Issue 278773336