Status Update
Comments
vi...@gmail.com <vi...@gmail.com> #2
Tram, can you confirm that the behavior is correct if the modifier is moved to the composable inside the AnimatedPane?
jo...@google.com <jo...@google.com> #3
Hi Max, yes when the modifiers are moved to the composable inside the AnimatedPane, the PB animations are better than when the modifiers are in the AnimatedPane itself
jo...@google.com <jo...@google.com> #5
After some investigation, I can conclude this behavior is consistent with other animation "wrapper" composables, e.g. AnimatedVisibility
. Modifiers should indeed be applied to the children in order to properly participate in the animation.
64...@gmail.com <64...@gmail.com> #6
When I first started using it the modal sheet didn't have the windows insets option and thus it was bound to the scaffold limits instead of the screen limits. The BottomSheefScaffold
worked correctly so I assumed it was a purpose decision.
I do like that with the scaffold I can directly control the sheet state without having to have a different state for the overall hide/show but I also agree that is no longer necessary
jo...@google.com <jo...@google.com> #7
Makes sense, thank you! There is always a tradeoff between ease of use and maintainability of APIs. I'm going to close this ticket as the use cases are covered by existing APIs. Please file feedback like a missing window insets option though if you encounter similar issues in the future!
64...@gmail.com <64...@gmail.com> #8
Sounds good, thank you for listening for the feedback!
Description
Jetpack Compose version:
2023.04.01
Jetpack Compose component used:
material3:1.1.0-rc01
Android Studio Build:
#AI-223.8836.35.2231.98483161
Kotlin version:
1.8.20
The current
BottomSheetScaffold
uses internallyStandardBottomSheet
and doesn't give any options to change this. I think it would be really helpful if it would also support theModalBottomSheet
.