Exception (and crash) If we try to navigate from dialog to fragment via navigate() [279306628]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Apr 24, 2023 11:52AM

Component used: Navigation
Version used: 2.6.0-beta01
Devices/Android versions reproduced on: Everywhere

Crash stack trace
java.lang.IllegalArgumentException: The fragment BottomSheetFragment{6c59aad}
(a05692b2-965c-40c6-82ce-57991ab0e8d6 tag=b3f6ebd6-263b-402f-8ebe-7762287c5f6d) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager. (FragmentNavigator.kt:147)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)

You can reproduce crash in the attached project.
Project has 3 fragments.
1. StartFragment
2. BottomSheetDialog
3. SimpleFragment

Navigation flow looks like: StartFragment (click on button) -> Navigation opens BottomSheet dialog fragment (click on button) -> crash.

But in 2.6.0-alpha09 and below crash is not reproduced and all works fine (BottomSheet dialog disappears and SimpleFragment appears, back stack looks like StartFragment -> SimpleFragment)

Thanks.

NavigationIssue.zip

117 KB

Download

Comments

jb...@google.com <jb...@google.com> Apr 24, 2023 05:16PM

Assigned to cl...@google.com.

jb...@google.com <jb...@google.com> Apr 24, 2023 11:43PM

Reassigned to jb...@google.com.

tp...@gmail.com <tp...@gmail.com> #2Apr 25, 2023 10:52AM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. OPP1.170223.012)

Which device did you use to reproduce this issue?

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

jb...@google.com <jb...@google.com> #3Apr 25, 2023 03:56PM

Android version: T

Problem recurrence: Execute Antutu, and pay attention to the XML processing score

Phenomenon: replace the "name expected" in the KXmlParser.java file on the ssi side with a variable. After modification, the XML processing score of Angora Rabbit improved significantly.

Modify to: static final private String NAME_ EXPECTED = "name expected"; And use NAME_ EXPECTED for subsequent "name expected"

Thanks!

ap...@google.com <ap...@google.com> #4Apr 25, 2023 08:07PM

Thanks for the above information, please share the bug report as requested in comment#2.

jb...@google.com <jb...@google.com> #5Apr 25, 2023 10:31PM

Marked as fixed.

bugreport has upload. Thankds!

jb...@google.com <jb...@google.com> #6Apr 25, 2023 10:36PM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

tp...@gmail.com <tp...@gmail.com> #7Apr 26, 2023 07:35AM

Okay, thanks!

ma...@gmail.com <ma...@gmail.com> #8Apr 26, 2023 08:19AM

Can you tell us if you have the link to the benchmark tests and the scores BEFORE and AFTER applying this change?

na...@google.com <na...@google.com> #9May 10, 2023 07:08PM

The score change is mainly reflected in the data processing in Antutu (including xml and json)

About 45000 before modification

About 49000 after modification

Thanks!

za...@google.com <za...@google.com> #10Jun 14, 2023 07:38PM

Thanks for the above information, we have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ma...@zentity.com <ma...@zentity.com> #11Jun 29, 2023 12:48PM

Thanks again for the feedback! Our product and engineering teams have evaluated the request and responded:

However, I can't find the source codes of the Antutu benchmarks.

Here are my suggestions, and you can consider one of the following options:

Can you provide the source code of benchmark to reproduce the result? Particularly, why do you mention that it improves the performance of JSON parsing? It would be great that we can reproduce the result and runs the benchmark continuously if the benchmark result is important
If you know how to change the code, you can consider uploading a patch to AOSP directly at http://r.android.com/. We will review it and consider accepting it.

Message last modified on Jun 29, 2023 01:11PM

an...@gmail.com <an...@gmail.com> #12Aug 22, 2023 02:42PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

Message last modified on Aug 22, 2023 02:49PM

jb...@google.com <jb...@google.com> #13Aug 22, 2023 04:45PM

We are closing this issue since we didn't receive a response. If you are still facing this problem, please open a new issue and add the relevant information along with reference to this issue.

go...@gmail.com <go...@gmail.com> #14Dec 13, 2023 09:43AM

I also have this problem, version 2.7.5
I have a BottomNavigationView and I just quickly click on two elements asynchronously and within 1 minute it crashes
You probably have test projects, two fragments will be enough

jb...@google.com <jb...@google.com> #15Dec 13, 2023 03:38PM

We will need you to file a new bug with a minimal sample project that reproduces this issue.