Component used: androidx-core

Version used: 1.10.0

Devices/Android versions reproduced on: All

DisplayManagerCompat leaks the Context argument used for DisplayManagerCompat.getInstance(Context). This is easily seen from code inspection:

getInstance(Context) populates DisplayManagerCompat.sInstances, which is of type WeakHashMap<Context, DisplayManagerCompat>.

WeakHashMap has weak keys, not weak values. DisplayManagerCompat.mContext is a hard reference to the same (key) Context object, and therefore causes the entire DisplayManagerCompat instance to leak, including the Context. This circular behavior caveat is spelled out in the javadoc for WeakHashMap.

This issue was one of the root causes for https://issuetracker.google.com/issues/37137738