Crash when navigating in onResume when using Navigation 2.6.0-beta01 and latest 2.6.0-SNAPSHOT [279644470]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Apr 26, 2023 07:32AM

Component used: Navigation

Version used: 2.6.0-beta01, 2.6.0-SNAPSHOT

Devices/Android versions reproduced on: All devices

14:43:44.151 20993-20993 AndroidRuntime           E  FATAL EXCEPTION: main
	Process: com.example.navigationissue, PID: 20993
	java.lang.IllegalArgumentException: The fragment SimpleFragment{ea1a1bc} (d8278311-d056-4068-ac70-fccb783b0731 id=0x7f080132 tag=3509fe8d-2b8f-41d6-ac7c-b15ea21e5a4c) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
	at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:147)
	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7842)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Sample project to trigger the issue requested as attached. Fragment of interest here is SimpleFragment.kt

Project has 1 main graph that includes 3 sub nav graphs, each sub graph with a single fragment with a button.

main_graph
navigation_start
navigation_simple
navigation_second

Navigation flow.

Start -> Simple -> Second. Second pop back to Simple either by Android Back or button click.
Simple onResume will trigger a navigation back to Start by reacting to a state change.
Crash occurs with the exception above

Crash doesn't occur 2.6.0-alpha09 and below. Or if navigation doesn't happen within onResume callback by moving navigation call to button click.

Scenario is the top level fragment triggered a fragment result state back to bottom fragment after performing some business logics.

NavigationIssue.zip

994 KB

Download

Comments

il...@google.com <il...@google.com> Apr 26, 2023 05:15PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Apr 27, 2023 12:37AM

Dany, I believe this is fixed in a new release of safeargs ?

jb...@google.com <jb...@google.com> #3Apr 27, 2023 03:04AM

Safeargs still needs AndroidComponentsExtension to get the applicationID from the variants (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt;l=73). Did AGP 7.2.0-alpha05 remove the extension?

jb...@google.com <jb...@google.com> #4Apr 27, 2023 03:04AM

Marked as fixed.

it moved to a different package : com.android.build.api.variant

na...@google.com <na...@google.com> #5May 10, 2023 07:08PM

Safeargs still relies on AGP 4.2. We need some of the BaseVariant APIs to have replacements before we can upgrade to 7.0+ (https://issuetracker.google.com/203557189).

mo...@gmail.com <mo...@gmail.com> #6Jun 28, 2023 01:58AM

The BaseVariant API are deprecated but still available in 7.x, so you should be able to release a newer version that uses the new package and still relies on the old API you require. Or am I missing something ?

ah...@gmail.com <ah...@gmail.com> #7Jun 28, 2023 12:22PM

I'll try updating to the latest stable to see if we run into any issues. I can check to make sure changing the package name in 7.2.0-alpha05 works, but we would need it to be stable before we could do a release with this change.

Message last modified on Jun 28, 2023 12:27PM

il...@google.com <il...@google.com> #8Jun 28, 2023 04:07PM

FYI this also breaks the latest Studio (2021.1.1 Beta 5)/AGP (7.1.0-beta05) beta where com.android.build.api.extension.AndroidComponentsExtension has been removed.

Is there a particular reason why https://issuetracker.google.com/203557189 and this issues don't have a higher priority?

As it stands, no one can upgrade either AGP/Studio Beta or Canary and take advantage of fixes in the latest versions because Navigation still uses the old AGP APIs.

ma...@zentity.com <ma...@zentity.com> #9Jun 29, 2023 12:26PM

Was this fixed in Studio 2021.1.1 RC 1?

Message last modified on Jun 29, 2023 01:10PM

il...@google.com <il...@google.com> #10Jun 29, 2023 03:52PM

I do not think so https://developer.android.com/studio/releases/fixed-bugs/studio/2021.1.1#android-studio-bumblebee-rc-01-2021.1.1.19.

Pretty disappointing though.

ma...@zentity.com <ma...@zentity.com> #11Jun 30, 2023 08:03AM

This will be fixed in the Navigation Safe Args 2.5.0-alpha01 and 2.4.1 versions. You can follow the snapshot instructions and try this out with build id #8054565.

ti...@persgroep.net <ti...@persgroep.net> #12Jul 2, 2023 09:25AM

Thank you! 2.4.1 is at least two weeks out (possibly 4, if I'm not mistaken).

I applaud the AGPs team decision to stick to the new APIs though. Hopefully its not too long before Navigation fixes this.

Message last modified on Jul 2, 2023 09:30AM

pe...@gmail.com <pe...@gmail.com> #13Jul 5, 2023 03:07PM

So we are talking mid february ?

ma...@gmail.com <ma...@gmail.com> #14Aug 8, 2023 01:10PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Dolphin Canary 5 (2021.3.1.5)
Android Gradle Plugin 7.3.0-alpha05

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

il...@google.com <il...@google.com> #15Aug 14, 2023 10:48PM

Is this included in the Dolphin Beta 1 build? 7.3.0-beta01?

I'm able to consistent reproduce this when having the namespace field setup in my gradle file. Removing it (and adding the value back to the Manifest files) does not cause the issue. Not sure if the same case here, or a new one.

ma...@gmail.com <ma...@gmail.com> #16Aug 15, 2023 07:55AM

May be related to this one ? https://issuetracker.google.com/231704909

Message last modified on Aug 15, 2023 07:55AM

ap...@google.com <ap...@google.com> #17Sep 7, 2023 05:19PM

Right, the direct incompatibility between AGP and Safe Args is fixed, I believe, but there's another issue related to the use of applicationId vs namespace, tracking at http://issuetracker.google.com/232107688. Thanks!

na...@google.com <na...@google.com> #18Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3
androidx.navigation:navigation-runtime:2.7.3

pa...@gmail.com <pa...@gmail.com> #19Sep 22, 2023 10:10AM

Still facing this issue with 2.7.3

jb...@google.com <jb...@google.com> #20Sep 25, 2023 03:32PM

Please file an issue with a minimal sample project that reproduces your issue with 2.7.3.

pa...@gmail.com <pa...@gmail.com> #21Sep 25, 2023 04:07PM

Pls see 301887045, would be really nice if this could be addressed soon, since the crash makes updating to any newer version than 2.5.3 impossible.

be...@gmail.com <be...@gmail.com> #22Sep 30, 2023 04:04PM

Hallo,

dieser Fehler tritt bei mir auf wenn ich .beginTransaction().addToBackStack(null) hinzufüge.

Vielleicht hilft das bei der Fehlersuche.

Gruß Wauzi

sa...@googlemail.com <sa...@googlemail.com> #23Oct 16, 2023 07:47AM

Fixed with release 2.7.4

ro...@gmail.com <ro...@gmail.com> #24Oct 20, 2023 05:27PM

It's fixed for version 2.7.4. It works for me

lo...@gmail.com <lo...@gmail.com> #25Nov 19, 2023 06:27AM

Still facing this issue with 2.7.4

tp...@fundrise.com <tp...@fundrise.com> #26Nov 20, 2023 03:03PM

Seems to be fixed with 2.7.5 for us.

vi...@gmail.com <vi...@gmail.com> #27Nov 21, 2023 06:15PM

Issue still persists, reported on firebase.

ag...@gmail.com <ag...@gmail.com> #28Dec 21, 2023 06:44AM

I have the issue with version 2.7.5 also, based on Firebase.

ad...@gmail.com <ad...@gmail.com> #29Jan 3, 2024 06:48PM

I have same issue with version 2.7.6 also, based on Firebase.

na...@google.com <na...@google.com> #30Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.8.0-alpha01
androidx.navigation:navigation-runtime:2.8.0-alpha01

an...@nine-yi.com <an...@nine-yi.com> #31Feb 9, 2024 02:53PM

I have same issue with version 2.7.7 also when I navigate to FragmentB from FragmentA with Jetpack Compose UI.
ex : findNavController().navigate(HomeFragmentDirections.actionHomeFragmentToNavSearch())

Message last modified on Feb 9, 2024 02:55PM

ne...@novo.co <ne...@novo.co> #32Jun 8, 2024 10:47AM

Using the below library version and getting the same issue.

Fatal Exception: java.lang.IllegalArgumentException The fragment QuestionsFragment{c0772b4} (a73d416f-c5b6-444c-add0-8e1b5d151331 id=0x7f0a0cf4 tag=22f1b453-8116-4697-ae6b-3dffab63b52c) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.

androidx.navigation:navigation-fragment-ktx:2.7.7

androidx.navigation:navigation-ui-ktx:2.7.7

al...@gmail.com <al...@gmail.com> #33Jul 8, 2024 05:55AM

Is navigation 2.8.0 going to be released soon?

wr...@gmail.com <wr...@gmail.com> #34Oct 15, 2024 03:45AM