Crash when navigating in onResume when using Navigation 2.6.0-beta01 and latest 2.6.0-SNAPSHOT [279644470]

Fixed

Bug

Status Update

No update yet.

Description

tp...@gmail.com

created issue #1

Apr 26, 2023 07:32AM

Component used: Navigation

Version used: 2.6.0-beta01, 2.6.0-SNAPSHOT

Devices/Android versions reproduced on: All devices

14:43:44.151 20993-20993 AndroidRuntime           E  FATAL EXCEPTION: main
	Process: com.example.navigationissue, PID: 20993
	java.lang.IllegalArgumentException: The fragment SimpleFragment{ea1a1bc} (d8278311-d056-4068-ac70-fccb783b0731 id=0x7f080132 tag=3509fe8d-2b8f-41d6-ac7c-b15ea21e5a4c) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
	at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:147)
	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7842)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Sample project to trigger the issue requested as attached. Fragment of interest here is SimpleFragment.kt

Project has 1 main graph that includes 3 sub nav graphs, each sub graph with a single fragment with a button.

main_graph
navigation_start
navigation_simple
navigation_second

Navigation flow.

Start -> Simple -> Second. Second pop back to Simple either by Android Back or button click.
Simple onResume will trigger a navigation back to Start by reacting to a state change.
Crash occurs with the exception above

Crash doesn't occur 2.6.0-alpha09 and below. Or if navigation doesn't happen within onResume callback by moving navigation call to button click.

Scenario is the top level fragment triggered a fragment result state back to bottom fragment after performing some business logics.

NavigationIssue.zip

994 KB

Download

Comments

il...@google.com <il...@google.com> Apr 26, 2023 05:15PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Apr 27, 2023 12:37AM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

jb...@google.com <jb...@google.com> #3Apr 27, 2023 03:04AM

yea i'll take it.

jb...@google.com <jb...@google.com> #4Apr 27, 2023 03:04AM

Marked as fixed.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

na...@google.com <na...@google.com> #5May 10, 2023 07:08PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

mo...@gmail.com <mo...@gmail.com> #6Jun 28, 2023 01:58AM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

ah...@gmail.com <ah...@gmail.com> #7Jun 28, 2023 12:22PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

Message last modified on Jun 28, 2023 12:27PM

il...@google.com <il...@google.com> #8Jun 28, 2023 04:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

ma...@zentity.com <ma...@zentity.com> #9Jun 29, 2023 12:26PM

Still persist in 2.6.0. From Crashlytics report:

Fatal Exception: java.lang.IllegalArgumentException: The fragment MyFragment{e08e9e3} (ffd3a63d-e7c5-4d27-8836-9579f2aea852 id=0x7f0a03a2 tag=0dcc6840-37be-40d3-9aab-10a5381ca884) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
       at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:143)
       at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
       at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
       at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
       at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:201)
       at android.os.Looper.loop(Looper.java:288)
       at android.app.ActivityThread.main(ActivityThread.java:7879)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1009)

MyFragment is in main fragment for subgraph which is included to nav_graph.xml.

Message last modified on Jun 29, 2023 01:10PM

il...@google.com <il...@google.com> #10Jun 29, 2023 03:52PM

Re comment#9 - please file a new issue with a sample project that reproduces your issue.

ma...@zentity.com <ma...@zentity.com> #11Jun 30, 2023 08:03AM

Re comment#10 - We are not able to reproduce it, but started with version 2.6.0. Yesterday we released app on Google Play, and this crash occurred 69 times for 19 users (about 0.3% of users). I guess it's caused by some race condition.

ti...@persgroep.net <ti...@persgroep.net> #12Jul 2, 2023 09:25AM

Please re-open.
Issue still persists.

I can reproduce the issue in a private project.
Issue is introduced between 2.6.0-alpha09 and 2.6.0-beta01

We navigate using the navigator#navigate(route: String, navOptions: NavOptions? = null, navigatorExtras: Navigator.Extras? = null)

After a callback from BottomNavigationView#setOnItemSelectedListener { }

Message last modified on Jul 2, 2023 09:30AM

pe...@gmail.com <pe...@gmail.com> #13Jul 5, 2023 03:07PM

Please re-open.
Issue still persists.
Issue is introduced version 2.6.0
java.lang.IllegalArgumentException: The fragment Fragment{fc34355} (39232ee3-331e-46a0-af93-ba6b5333073c id=0x7f0a0080 tag=221aaf28-4a64-4790-8a9d-982050604bf8) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:143)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1845)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8757)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)

ma...@gmail.com <ma...@gmail.com> #14Aug 8, 2023 01:10PM

I have this problem as well in PreferenceScreen, when using 2.6.0, no problems in 2.5.3.

I expected it to be able to use "app:fragment=" parameter to navigate when clicking on the preference.While it showed this errors.

java.lang.IllegalArgumentException: The fragment LibrarySettingsNavFragment{e8a45e3} (e3ae8f01-4d4b-4f1f-8fd1-df0fb58c3764 id=0x7f0a040d) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.
                                                                                                    	at androidx.navigation.fragment.FragmentNavigator$onAttach$2.onBackStackChangeCommitted(FragmentNavigator.kt:143)
                                                                                                    	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1918)
                                                                                                    	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1839)
                                                                                                    	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1782)
                                                                                                    	at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:565)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:942)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:201)
                                                                                                    	at android.os.Looper.loop(Looper.java:288)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7872)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

il...@google.com <il...@google.com> #15Aug 14, 2023 10:48PM

Re comment#14 - if you are also seeing the warning message when you are not handling a click correctly, then this is working as intended: only the NavHostFragment's FragmentNavigator can add fragments to its FragmentManager.

You might consider using PreferenceHeaderFragmentCompat, which in addition to automatically giving you a two pane experience on larger screens, correctly implements OnPreferenceStartFragmentCallback to redirect click events to the right FragmentManager.

ma...@gmail.com <ma...@gmail.com> #16Aug 15, 2023 07:55AM

Re comment#15 - It does show the warning you have mentioned. (onPreferenceStartFragment is not implemented...)

I will consider the new approach you have brought up. Thanks for the reply and the information!

Message last modified on Aug 15, 2023 07:55AM

ap...@google.com <ap...@google.com> #17Sep 7, 2023 05:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit f61da31809827bfac89af629c88ad9b8423e88b6
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 06 14:14:11 2023

Fix entry not marked complete after view is destroyed

As part of a fix for

b/279644470

in aosp/2566210, when the fragment view is destroyed, we would mark the transitioning (outgoing) entry as complete only if the entry has also been removed from backstack. However, in the simple navigate() case where the outgoing entry is not popped and remains in the backstack, this entry is not marked complete and ends up in the visibleEntries even though the view has been destroyed.

Now the backstack check in ON_DESTROY is no longer necessary to fix the original

b/279644470

bug -- the view being destroyed should be the right signal for completing entries regardless of whether transitioning effects are used. So this check is removed.

Test: ./gradlew navigation:navigation-fragment:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 288520638
Change-Id: I5caa9af1b5bd7084e76d7daf9515f7430bf2489d

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2743918

na...@google.com <na...@google.com> #18Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3
androidx.navigation:navigation-runtime:2.7.3

pa...@gmail.com <pa...@gmail.com> #19Sep 22, 2023 10:10AM

Still facing this issue with 2.7.3

jb...@google.com <jb...@google.com> #20Sep 25, 2023 03:32PM

Please file an issue with a minimal sample project that reproduces your issue with 2.7.3.

pa...@gmail.com <pa...@gmail.com> #21Sep 25, 2023 04:07PM

Pls see 301887045, would be really nice if this could be addressed soon, since the crash makes updating to any newer version than 2.5.3 impossible.

be...@gmail.com <be...@gmail.com> #22Sep 30, 2023 04:04PM

Hallo,

dieser Fehler tritt bei mir auf wenn ich .beginTransaction().addToBackStack(null) hinzufüge.

Vielleicht hilft das bei der Fehlersuche.

Gruß Wauzi

sa...@googlemail.com <sa...@googlemail.com> #23Oct 16, 2023 07:47AM

Fixed with release 2.7.4

ro...@gmail.com <ro...@gmail.com> #24Oct 20, 2023 05:27PM

It's fixed for version 2.7.4. It works for me

lo...@gmail.com <lo...@gmail.com> #25Nov 19, 2023 06:27AM

Still facing this issue with 2.7.4

tp...@fundrise.com <tp...@fundrise.com> #26Nov 20, 2023 03:03PM

Seems to be fixed with 2.7.5 for us.

vi...@gmail.com <vi...@gmail.com> #27Nov 21, 2023 06:15PM

Issue still persists, reported on firebase.

ag...@gmail.com <ag...@gmail.com> #28Dec 21, 2023 06:44AM

I have the issue with version 2.7.5 also, based on Firebase.

ad...@gmail.com <ad...@gmail.com> #29Jan 3, 2024 06:48PM

I have same issue with version 2.7.6 also, based on Firebase.

na...@google.com <na...@google.com> #30Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.8.0-alpha01
androidx.navigation:navigation-runtime:2.8.0-alpha01

an...@nine-yi.com <an...@nine-yi.com> #31Feb 9, 2024 02:53PM

I have same issue with version 2.7.7 also when I navigate to FragmentB from FragmentA with Jetpack Compose UI.
ex : findNavController().navigate(HomeFragmentDirections.actionHomeFragmentToNavSearch())

Message last modified on Feb 9, 2024 02:55PM

ne...@novo.co <ne...@novo.co> #32Jun 8, 2024 10:47AM

Using the below library version and getting the same issue.

Fatal Exception: java.lang.IllegalArgumentException The fragment QuestionsFragment{c0772b4} (a73d416f-c5b6-444c-add0-8e1b5d151331 id=0x7f0a0cf4 tag=22f1b453-8116-4697-ae6b-3dffab63b52c) is unknown to the FragmentNavigator. Please use the navigate() function to add fragments to the FragmentNavigator managed FragmentManager.

androidx.navigation:navigation-fragment-ktx:2.7.7

androidx.navigation:navigation-ui-ktx:2.7.7

al...@gmail.com <al...@gmail.com> #33Jul 8, 2024 05:55AM

Is navigation 2.8.0 going to be released soon?

wr...@gmail.com <wr...@gmail.com> #34Oct 15, 2024 03:45AM