Status Update
Comments
lb...@gmail.com <lb...@gmail.com>
sa...@google.com <sa...@google.com>
je...@google.com <je...@google.com>
ml...@google.com <ml...@google.com> #2
Hi, thank you for the feedback.
This quick-fix redirects to documentation because it is a more complicated migration than can be handled automatically by a lint rule, especially the addition of KSP plugin.
In your case project is broken after following the instructions because glide has a different artifact name for ksp, you should also replace com.github.bumptech.glide:compiler
with com.github.bumptech.glide:ksp
, see the 'note' in
I appreciate the UX of this migration is currently not ideal, we continue working on it.
lb...@gmail.com <lb...@gmail.com> #3
1. Why call it "enable X", when it doesn't "enable X" and only goes to a place that explains how to "enable X" ? You need to change the text of it. Can be "Learn how to enable X", instead, for example. When you say "Enable X", I expect it to enable it or open something that will do it eventually, on its own.
2. It doesn't seem as as complicated as many other tools the IDE has, such as "AGP upgrade assistant" and the conversion to Kotlin. The only thing that seems to need more work is to tell us to reach each dependency and find what to use instead. It can do it already for some, such as of Firebase/Admbob/Google and as you mentioned, of Glide, too.
3. About the replacement, thank you. Has to replace "GlideApp" , too.
4. About Room, I had this before:
kapt {
arguments {
arg("room.schemaLocation", "$projectDir/schemas")
}
}
How come I can't find about this now, of what to use for ksp?
I tried what's on the docs, and it just doesn't let me build anymore. Is there perhaps a sample of using it there?
ml...@google.com <ml...@google.com> #4
- Agree, we need to change the text for this one.
- replacing kapt with ksp alternatives is easy and this we are doing if there is nothing else to be done. Adding new plugin (ksp) is not trivial as the right way to do it depends on the details of your project.
lb...@gmail.com <lb...@gmail.com> #5
Something like the AGP upgrade assistant?
Even manually, I can't find how to replace the Room schema part. It's not mentioned and I also get errors :
ml...@google.com <ml...@google.com> #6
Thank you for the feedback, yes, we continue working on this so it is really valuable.
For room migration, this seems to be what you are looking for?
lb...@gmail.com <lb...@gmail.com> #7
ml...@google.com <ml...@google.com> #8
We changed the text of the lint warning quickfix in case it only leads to the documentation. should be available in Giraffe-beta5 and Hedgehog-canary5.
I do not fully understand what problem you have with room argument. I just took your project example, added some room entities, replaced configuration as below and it built nicely, generating the schema...
ksp {
arg("room.schemaLocation", "$projectDir/schemas")
}
lb...@gmail.com <lb...@gmail.com> #9
The Room website talks about "RoomSchemaArgProvider" that needs to be declared, for example...
I don't see it mentioned in both of these websites:
Why isn't what you wrote mentioned there? For both before ksp and after migration to it?
Also I've found that on the website of migrating to ksp (
plugins {
id 'com.google.devtools.ksp' version '1.8.10-1.0.9' apply false
}
It should be below the "buildscript" region.
ml...@google.com <ml...@google.com> #10
I tried both ways 1) as it is specified in documentation with "RoomSchemaArgProvider" 2) as you say you used it before with `arg(key, value)`.
Both ways work for me generating the schema.
I do not know why in room documentation they only mention the "RoomSchemaArgProvider" way, in ksp plugin documentation key-value way is mentioned instead.
Anyway you already created
The matter of this bug with misleading lint warning text was now fixed so closing this bug.
lb...@gmail.com <lb...@gmail.com> #11
Also thank you for helping on Room. I hope the website gets updated.
Description
STEPS TO REPRODUCE:
1. Have this in build gradle file:
kapt "com.github.bumptech.glide:compiler:${GLIDE_VERSION}"
2. Notice that the IDE gives you a quick-fix to enable KSP.
3. Try it
The bug is that it doesn't do anything, and instead goes to a website that also doesn't help :
I even tried what's on the website, but even then it just reaches the point of this error:
"
e: [ksp] No providers found in processor classpath.
e: Error occurred in KSP, check log for detail
"
------------------
Studio Build:
Version of Gradle Plugin:
Version of Gradle:
Version of Java:
OS:
Android Studio Hedgehog | 2023.1.1 Canary 1
Build #AI-223.8836.35.2311.9976484, built on April 20, 2023
Runtime version: 17.0.6+0-b2043.56-9884540 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 3072M
Cores: 12
Registry:
external.system.auto.import.disabled=true
debugger.watches.in.variables=false
ide.text.editor.with.preview.show.floating.toolbar=false
ide.instant.shutdown=false
ide.images.show.chessboard=true
Non-Bundled Plugins:
com.intellij.marketplace (223.8836.56)
String Manipulation (9.7.1)
izhangzhihao.rainbow.brackets (2023.2.7)
net.aquadc.mike.plugin (0.28)
com.developerphil.adbidea (1.6.10)