Offer APIs to convert between compose ColorSpace and android ColorSpace [279979665]

Fixed

Bug

Status Update

No update yet.

Description

sa...@squareup.com

created issue #1

Apr 28, 2023 06:02AM

Jetpack Compose version: 1.4.2

I'm working on an image related library that accepts a ColorSpace, but I'm finding it difficult to safely convert it to and from android.graphics.ColorSpace. Can Compose UI offer APIs to do this?

My best attempt was to maintain these two functions but it'd be really nice if we had official APIs.

fun ColorSpace.toAndroidColorSpace(): AndroidColorSpace {
  return when {
    this == ColorSpaces.Srgb -> AndroidColorSpace.get(AndroidColorSpace.Named.SRGB)
    this == ColorSpaces.AdobeRgb -> AndroidColorSpace.get(AndroidColorSpace.Named.ADOBE_RGB)
    this == ColorSpaces.ExtendedSrgb -> AndroidColorSpace.get(AndroidColorSpace.Named.EXTENDED_SRGB)
    …
  }
}

fun AndroidColorSpace.toAndroidColorSpace(): ColorSpace {
  return when {
    this == AndroidColorSpace.get(AndroidColorSpace.Named.SRGB) -> ColorSpaces.Srgb
    …
  }
}

Comments

ae...@google.com <ae...@google.com> Apr 28, 2023 09:53PM

Reassigned to nj...@google.com.

nj...@google.com <nj...@google.com> #2May 1, 2023 07:00PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

sa...@saket.me <sa...@saket.me> #3May 1, 2023 07:08PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4May 1, 2023 08:49PM

Marked as fixed.

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ju...@google.com <ju...@google.com> #5May 24, 2023 07:37PM

deleted

Issue 279979665