Status Update
Comments
il...@google.com <il...@google.com> #2
To use
The issue is happening because, starting from LocalLifecycleOwner
has been moved from androidx.compose.ui
to lifecycle-runtime-compose
, as outlined in their respective release notes. For compatibility reasons, you must update both dependencies.
For context, note these changes were made to enable the utilization of its Compose-based helper APIs beyond Compose UI (such as in
If the issue persists even after updating your Compose UI, please let us know.
Edit: please see
sa...@google.com <sa...@google.com>
ap...@google.com <ap...@google.com> #3
If this change has made both libraries version dependent, it seems that guide them to the release note so that users will not experience difficulties :)
il...@google.com <il...@google.com> #4
lifecycle 2.8.0 is now stable but compose UI 1.7.0 is still in beta.
pr...@google.com <pr...@google.com> #5
Same problem here. Lifecycle 2.8.0
is now stable but Compose UI 1.7.0
is still beta. Of course our Dependabot didn't know about this relationship between dependencies 😬
ph...@gmail.com <ph...@gmail.com> #6
Something like that really shouldn't happen... 🤦🏻♂️
Description
Component used: androidx.lifecycle:lifecycle-viewmodel
Version used: 2.6.1
Devices/Android versions reproduced on: n/a
Current implementation of
addCloseable
doesn't have a check ofmCleared
, unlike ofputTagIfAbsent
. It may lead to memory leaks, because user can not add check ofmCleared
and close Closeable by its own. For example, if we start background task (thread, coroutine, rx-java chain), it is possible for this task to be active afteronClear
invocation (even this time is small) and add Closeable object afteronClear
. In this case,Closeable.close()
will not be invoked.Could be this check added to
addCloseable
implementation?