Closeable objects are not closing if they are added after 'onClear' [280294730]

Fixed

Bug

Status Update

No update yet.

Description

tr...@gmail.com

created issue #1

May 2, 2023 12:27PM

Component used: androidx.lifecycle:lifecycle-viewmodel

Version used: 2.6.1

Devices/Android versions reproduced on: n/a

Current implementation of addCloseable doesn't have a check of mCleared, unlike of putTagIfAbsent. It may lead to memory leaks, because user can not add check of mCleared and close Closeable by its own. For example, if we start background task (thread, coroutine, rx-java chain), it is possible for this task to be active after onClear invocation (even this time is small) and add Closeable object after onClear. In this case, Closeable.close() will not be invoked.

Could be this check added to addCloseable implementation?

Comments

il...@google.com <il...@google.com> #2May 8, 2023 06:29PM

Assigned to sa...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

sa...@google.com <sa...@google.com> Aug 23, 2023 04:08PM

Accepted by sa...@google.com.

ap...@google.com <ap...@google.com> #3Aug 24, 2023 06:45PM

Marked as fixed.

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

il...@google.com <il...@google.com> #4Aug 24, 2023 11:40PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

pr...@google.com <pr...@google.com> #5Sep 6, 2023 07:56PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

ph...@gmail.com <ph...@gmail.com> #6Mar 6, 2024 04:05PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

Issue 280294730