Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit b543cd768dbdee5a97c5d492f8e6525ed23559da
Author: Chet Haase <chet@google.com>
Date: Mon May 01 11:46:20 2023
Add rectangle shape function
This library was created with the original idea of making round rects
better, so it would be good to offer an easy way to get such shapes.
It is not hard to get a rectangular shape (rounded or not) from the
current APIs, but it is requires creating a vertex list since the
easier RoundedPolygon constructors create shapes with edges of
equal sizes.
This commit also changes the default number of vertices in circle()
to 8, from the previous 4, just to up the quality of the result for
this common shape.
The Compose and View integration tests were updated to include
examples of these shapes.
Bug: 280322189
Test: existing and new unit tests pass, manual testing with integration tests
RelNote: Added new RoundedPolygon.rectangle() function
Change-Id: I78e7ee609295c20680c5e6f1a3383421420674ff
M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/public_plus_experimental_current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/MainActivity.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeActivity.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeView.kt
https://android-review.googlesource.com/2573039
Branch: androidx-main
commit b543cd768dbdee5a97c5d492f8e6525ed23559da
Author: Chet Haase <chet@google.com>
Date: Mon May 01 11:46:20 2023
Add rectangle shape function
This library was created with the original idea of making round rects
better, so it would be good to offer an easy way to get such shapes.
It is not hard to get a rectangular shape (rounded or not) from the
current APIs, but it is requires creating a vertex list since the
easier RoundedPolygon constructors create shapes with edges of
equal sizes.
This commit also changes the default number of vertices in circle()
to 8, from the previous 4, just to up the quality of the result for
this common shape.
The Compose and View integration tests were updated to include
examples of these shapes.
Bug: 280322189
Test: existing and new unit tests pass, manual testing with integration tests
RelNote: Added new RoundedPolygon.rectangle() function
Change-Id: I78e7ee609295c20680c5e6f1a3383421420674ff
M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/public_plus_experimental_current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/MainActivity.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeActivity.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/ShapeView.kt
ch...@google.com <ch...@google.com>
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.graphics:graphics-shapes:1.0.0-alpha03
Description