SwipeToDismissBox swipe gesture only works on initial content [280392104]

Fixed

Bug

Status Update

No update yet.

Description

ys...@google.com

created issue #1

May 2, 2023 07:50AM

Component used: SwipeToDismissBox Version used: 1.2.0-alpha09 Devices/Android versions reproduced on: emulator

Uncommenting backgroundScrimColor in the sample is a hack to make it work again.

    val items = remember { mutableStateListOf(1, 2) }

    val current = items.last()
    val previous = items.dropLast(1).lastOrNull()

    val state = SwipeToDismissBoxState()
    SwipeToDismissBox(
        state = state,
        backgroundKey = previous ?: SwipeToDismissKeys.Background,
        contentKey = current,
        hasBackground = previous != null,
        onDismissed = { items.removeLastOrNull() },
//        backgroundScrimColor = if (current % 2 == 0) MaterialTheme.colors.background else MaterialTheme.colors.error
    ) { isBackground ->
        val item = if (isBackground) {
            previous
        } else {
            current
        }

        Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
            if (item != null) {
                StandardChip(label = "item $item", onClick = {
                    items.add(items.size + 1)
                })
            } else {
                Text("EmptyEmptyEmptyEmptyEmptyEmpty")
            }
        }
    }

Comments

ys...@google.com <ys...@google.com> May 2, 2023 07:56AM

working.mp4

1011 KB

Download

broken.mp4

280 KB

Download

ys...@google.com <ys...@google.com> #2May 11, 2023 02:02PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

st...@google.com <st...@google.com> #3May 11, 2023 03:26PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ys...@google.com <ys...@google.com> #4May 11, 2023 03:48PM

second page? The swipe to dismiss works once, then stops once you change the screen content. Basically if you implement a navigation stack without SwipeDismissableNavHost.

st...@google.com <st...@google.com> May 22, 2023 09:06AM

Assigned to ra...@google.com.

ra...@google.com <ra...@google.com> #5May 24, 2023 06:55AM

In SwipeToDismissBox - the translation and scale code is remembered under backgroundScrimColor and isRound boolean. Hence, when they aren't changing we can't see the swipe effect.

Code ref - https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/SwipeToDismissBox.kt;l=148

My suggestion would be to use isRound, backgroundKey, contentKey as keys of the remember codeblock.

Message last modified on May 24, 2023 07:43AM

ra...@google.com <ra...@google.com> May 25, 2023 06:36AM

Accepted by ra...@google.com.

ra...@google.com <ra...@google.com> #6May 29, 2023 03:40AM

CL - https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2606886

Message last modified on May 29, 2023 03:41AM

ap...@google.com <ap...@google.com> #7Jun 2, 2023 01:18PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9c913f364be2317ad46d820bec7e69d8e4fc1c42
Author: Rajat Biswas <rajatbiswas@google.com>
Date: Fri May 26 13:18:44 2023

Changing keys of remember block in SwipeToDismissBox

Bug: 280392104
Test: Manually tested

Relnote: "Changed keys of remember block in SwipeToDismissBox so that
new modifiers are created when content or background chnages."

Change-Id: Ib876c266c8ec9795e8f2c83a6c0a7e846b0ebc51

M wear/compose/compose-material/src/main/java/androidx/wear/compose/material/SwipeToDismissBox.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/MaterialDemos.kt
M wear/compose/integration-tests/demos/src/main/java/androidx/wear/compose/integration/demos/SwipeToDismissDemo.kt

https://android-review.googlesource.com/2606886

st...@google.com <st...@google.com> Jun 2, 2023 02:47PM

Marked as fixed.

pr...@google.com <pr...@google.com> #8Jun 21, 2023 08:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.wear.compose:compose-material:1.3.0-alpha01

IssueTracker