Extend PerfettoTrace.record to support custom configs [280460183]

Fixed

Feature Request

Status Update

No update yet.

Description

ke...@google.com

created issue #1

May 2, 2023 06:15PM

I am adding custom data sources to Perfetto which also need custom configs. E.g.:

$ cat perfetto-config.textproto
...
data_sources: {
    config {
        name: "android.surfaceflinger.transactions"
    }
}
data_sources: {
    config {
        name: "android.surfaceflinger.layers"
        surfaceflinger_layers_config: {
            mode: GENERATED
            flags: TRACE_INPUT
            flags: TRACE_BUFFERS
        }
    }
}
...

Could you extend or add a more generic variant of PerfettoTrace.record that takes a custom config as parameter?

Something along these lines should work for me:

import perfetto.protos.PerfettoConfig.TraceConfig

fun record(
    config: TraceConfig,
    traceCallback: ((PerfettoTrace) -> Unit)? = null,
    block: () -> Unit
): Unit

Thank you

Comments

ap...@google.com <ap...@google.com> #2May 8, 2023 06:52PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 2b7cb304f0a1acb9cd87f25cc190de5d6a8c5792
Author: Chris Craik <ccraik@google.com>
Date: Tue May 02 15:06:22 2023

Support fully custom Perfetto configs, text and binary.

Test: TrivialStartupBenchmark, tests in benchmark-common, benchmark-macro
Fixes: 280460183
Relnote: "Add support for fully custom Perfetto configs with PerfettoTrace.record"

Change-Id: If9d752af8dd395b903f7530f393b1bb0b3fb3441

M benchmark/benchmark-common/api/public_plus_experimental_current.txt
M benchmark/benchmark-common/build.gradle
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoHelperTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoCapture.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoCaptureWrapper.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoTrace.kt
M benchmark/benchmark-junit4/build.gradle
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AndroidxTracingTraceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureSweepTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt

https://android-review.googlesource.com/2579998

pr...@google.com <pr...@google.com> #3Jun 8, 2023 01:30AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha15
androidx.benchmark:benchmark-junit4:1.2.0-alpha15
androidx.benchmark:benchmark-macro:1.2.0-alpha15

Issue 280460183

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 8, 2023 06:52PM

pr...@google.com <pr...@google.com> #3Jun 8, 2023 01:30AM

Add comment

Issue metadata