Extend PerfettoTrace.record to support custom configs [280460183]

Fixed

Feature Request

Status Update

No update yet.

Description

ke...@google.com

created issue #1

May 2, 2023 06:15PM

I am adding custom data sources to Perfetto which also need custom configs. E.g.:

$ cat perfetto-config.textproto
...
data_sources: {
    config {
        name: "android.surfaceflinger.transactions"
    }
}
data_sources: {
    config {
        name: "android.surfaceflinger.layers"
        surfaceflinger_layers_config: {
            mode: GENERATED
            flags: TRACE_INPUT
            flags: TRACE_BUFFERS
        }
    }
}
...

Could you extend or add a more generic variant of PerfettoTrace.record that takes a custom config as parameter?

Something along these lines should work for me:

import perfetto.protos.PerfettoConfig.TraceConfig

fun record(
    config: TraceConfig,
    traceCallback: ((PerfettoTrace) -> Unit)? = null,
    block: () -> Unit
): Unit

Thank you

Comments

ap...@google.com <ap...@google.com> #2May 8, 2023 06:52PM

Marked as fixed.

The workaround I found so far is to use project.afterEvaluate {} to access the build types, as they are created only after Baseline Profile Gradle Plugin creates them:

Kotlin

android {
    buildTypes {
        release { ... }
        project.afterEvaluate {
            getByName("benchmarkRelease") { }
            getByName("nonMinifiedRelease") { }
        }
    }
}

Groovy

android {
    buildTypes {
        release { ... }
        project.afterEvaluate {
            benchmarkRelease { }
            nonMinifiedRelease { }
        }
    }
}

This way there are no redundant build variants created.

pr...@google.com <pr...@google.com> #3Jun 8, 2023 01:30AM

Attaching a sample project for convenience.

Issue 280460183

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2May 8, 2023 06:52PM

pr...@google.com <pr...@google.com> #3Jun 8, 2023 01:30AM

Add comment

Issue metadata