Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5534f4a73789b7cf56b5219efab704cb7fd056e0
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Feb 04 14:03:00 2021
Deletes deprecated Material, Foundation, and Ambient* related APIs
Also renames Ambients.kt and AndroidAmbients.kt to CompositionLocals.kt and AndroidCompositionLocals.kt
Fixes:
Test: updateApi
Relnote: "Deleted some previously deprecated APIs"
Change-Id: Ice5dae36591015a9d905b84b26cc02662385d831
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
D compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/ConstraintLayoutDemo.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/LayoutDemos.kt
D compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/ConstraintLayoutSample.kt
D compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/ConstraintLayoutTest.kt
D compose/foundation/foundation-layout/src/androidMain/kotlin/androidx/compose/foundation/layout/ConstraintLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/AlignmentLine.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Column.kt
D compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Flow.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Offset.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Row.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ListDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerFocusTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyFor.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/animation/AndroidFlingCalculator.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/kotlin/Kotlin.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/layout/Layout.kt
M compose/material/material-ripple/api/current.txt
M compose/material/material-ripple/api/public_plus_experimental_current.txt
M compose/material/material-ripple/api/restricted_current.txt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentAlpha.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentColor.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ElevationOverlay.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/runtime/runtime-saveable/api/current.txt
M compose/runtime/runtime-saveable/api/public_plus_experimental_current.txt
M compose/runtime/runtime-saveable/api/restricted_current.txt
D compose/runtime/runtime-saveable/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/Deprecated.kt
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/CompositionLocal.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
D compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectionMode.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.kt
https://android-review.googlesource.com/1575163
Branch: androidx-main
commit 5534f4a73789b7cf56b5219efab704cb7fd056e0
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Thu Feb 04 14:03:00 2021
Deletes deprecated Material, Foundation, and Ambient* related APIs
Also renames Ambients.kt and AndroidAmbients.kt to CompositionLocals.kt and AndroidCompositionLocals.kt
Fixes:
Test: updateApi
Relnote: "Deleted some previously deprecated APIs"
Change-Id: Ice5dae36591015a9d905b84b26cc02662385d831
M compose/foundation/foundation-layout/api/current.txt
M compose/foundation/foundation-layout/api/public_plus_experimental_current.txt
M compose/foundation/foundation-layout/api/restricted_current.txt
D compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/ConstraintLayoutDemo.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/LayoutDemos.kt
D compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/ConstraintLayoutSample.kt
D compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/ConstraintLayoutTest.kt
D compose/foundation/foundation-layout/src/androidMain/kotlin/androidx/compose/foundation/layout/ConstraintLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/AlignmentLine.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Column.kt
D compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Flow.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Offset.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Row.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ListDemos.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerFocusTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
D compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyFor.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/animation/AndroidFlingCalculator.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/kotlin/Kotlin.kt
M compose/integration-tests/docs-snippets/src/main/java/androidx/compose/integration/docs/layout/Layout.kt
M compose/material/material-ripple/api/current.txt
M compose/material/material-ripple/api/public_plus_experimental_current.txt
M compose/material/material-ripple/api/restricted_current.txt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentAlpha.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentColor.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ElevationOverlay.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/runtime/runtime-saveable/api/current.txt
M compose/runtime/runtime-saveable/api/public_plus_experimental_current.txt
M compose/runtime/runtime-saveable/api/restricted_current.txt
D compose/runtime/runtime-saveable/src/commonMain/kotlin/androidx/compose/runtime/savedinstancestate/Deprecated.kt
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/CompositionLocal.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
D compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/InspectionMode.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopPopup.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f06753ed29d67623b4061cb222717948d0a37ef7
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 13:16:53 2023
Add PagingSourceFactory interface
This functional interface allows creating a PagingSourceFactory by passing in a lambda that returns a PagingSource, or by creating a class that extends this interface. The factory can be passed into Pager as the pagingSourceFactory.
Test: ./gradlew paging:paging-common:test
Bug: 280655188
Relnote: "Added a new PagingSourceFactory functional interface. Override the invoke() method with an implementation that returns a new instance of PagingSource. This factory can be used to instantiate a Pager."
Change-Id: I3316590a0d667566edeb40d4e99e005cd6cee3ac
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/main/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
A paging/paging-common/src/main/kotlin/androidx/paging/PagingSourceFactory.kt
https://android-review.googlesource.com/2579310
Branch: androidx-main
commit f06753ed29d67623b4061cb222717948d0a37ef7
Author: Clara Fok <clarafok@google.com>
Date: Wed May 03 13:16:53 2023
Add PagingSourceFactory interface
This functional interface allows creating a PagingSourceFactory by passing in a lambda that returns a PagingSource, or by creating a class that extends this interface. The factory can be passed into Pager as the pagingSourceFactory.
Test: ./gradlew paging:paging-common:test
Bug: 280655188
Relnote: "Added a new PagingSourceFactory functional interface. Override the invoke() method with an implementation that returns a new instance of PagingSource. This factory can be used to instantiate a Pager."
Change-Id: I3316590a0d667566edeb40d4e99e005cd6cee3ac
M paging/paging-common/api/current.txt
M paging/paging-common/api/public_plus_experimental_current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/main/kotlin/androidx/paging/InvalidatingPagingSourceFactory.kt
A paging/paging-common/src/main/kotlin/androidx/paging/PagingSourceFactory.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 967c97f18d7f2a717222b09be6227f0f7dabb323
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 13:06:24 2023
Update documentation for asPagingSourceFactory API
Kdocs updated to reflec the API's migration from returning a lambda to returning a Class.
Test: n/a
Bug: 280655188
Change-Id: Ib3f9b5c9215ba9e5ee38d6b192e9858bbe080346
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
https://android-review.googlesource.com/2580094
Branch: androidx-main
commit 967c97f18d7f2a717222b09be6227f0f7dabb323
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 13:06:24 2023
Update documentation for asPagingSourceFactory API
Kdocs updated to reflec the API's migration from returning a lambda to returning a Class.
Test: n/a
Bug: 280655188
Change-Id: Ib3f9b5c9215ba9e5ee38d6b192e9858bbe080346
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 59e0f757ba85b81b800e6fb0d60dd25dd88bee54
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 12:52:34 2023
Expand asPagingSourceFactory API to singe list
In addition to Flow<List<Value>>.asPagingSourceFactory API, we added a List<Value>.asPagingSourceFactory. All PagingSoruces produced by this new API will load from the exact same static list of data. It supports multi-generational operations such as refresh, but it does not support any updates to the source data. Because it operates on a static list, collection is not required which removes the requirement for a coroutineScope.
Test: ./gradlew paging:paging-testing:test
Bug: 280655188
Relnote: "Added new API List<Value>.asPagingSourceFactory to get a factory that creates PagingSource instances that loads from the immutable list of data."
Change-Id: Id34d1361119413d0c19a054a2e23dd26241faa6f
M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt
https://android-review.googlesource.com/2580093
Branch: androidx-main
commit 59e0f757ba85b81b800e6fb0d60dd25dd88bee54
Author: Clara Fok <clarafok@google.com>
Date: Thu May 04 12:52:34 2023
Expand asPagingSourceFactory API to singe list
In addition to Flow<List<Value>>.asPagingSourceFactory API, we added a List<Value>.asPagingSourceFactory. All PagingSoruces produced by this new API will load from the exact same static list of data. It supports multi-generational operations such as refresh, but it does not support any updates to the source data. Because it operates on a static list, collection is not required which removes the requirement for a coroutineScope.
Test: ./gradlew paging:paging-testing:test
Bug: 280655188
Relnote: "Added new API List<Value>.asPagingSourceFactory to get a factory that creates PagingSource instances that loads from the immutable list of data."
Change-Id: Id34d1361119413d0c19a054a2e23dd26241faa6f
M paging/paging-testing/api/current.txt
M paging/paging-testing/api/public_plus_experimental_current.txt
M paging/paging-testing/api/restricted_current.txt
M paging/paging-testing/src/main/java/androidx/paging/testing/StaticListPagingSourceFactory.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/PagerFlowSnapshotTest.kt
M paging/paging-testing/src/test/kotlin/androidx/paging/testing/StaticListPagingSourceFactoryTest.kt
cl...@google.com
Fixed internally and will be available in paging 3.2.0-alpha06.
ju...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.paging:paging-common:3.2.0-alpha06androidx.paging:paging-testing:3.2.0-alpha06
Description
Improvements considered include:
1. Add an actual `PagingSourceFactory` class. Right now this factory concept exists in Paging3 merely as lambda of type `() -> PagingSource<Key, Value>`.
2. Making `asPagingSourceFactory` return this concrete class rather than a lambda