R8 on AGP 8 breaks Google Fit service [280659987]

Verified

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 4, 2023 06:54AM

After upgrade to AGP 8.0.0 (the fullmode is disabled). I faced an issue when creating a Google Fit session, here is crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
at com.google.android.gms.internal.fitness.zzfv.zza(com.google.android.gms:play-services-fitness@@21.1.0:1)
at com.google.android.gms.fitness.data.Session$Builder.setActivity(com.google.android.gms:play-services-fitness@@21.1.0:1)

Comments

ch...@google.com <ch...@google.com> #2May 4, 2023 08:41AM

Thanks for the report. Would it be possible for you to share a zip dump of the inputs to R8, including the app's class files, keep rules, etc.? This should enable us to reproduce the build.

You can generate this by running:

./gradlew assembleRelease --no-daemon -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/r8/dumps

sg...@google.com <sg...@google.com> May 4, 2023 03:07PM

Reassigned to ch...@google.com.

[Deleted User] <[Deleted User]> #3May 5, 2023 03:28AM

Hi, thanks for response, here they are

dump17016472426270.zip

61 MB

Download

proguard-rules.pro

6 KB

Download

ch...@google.com <ch...@google.com> #4May 8, 2023 11:28AM

Thanks for sharing. Looking at the code from the dump it is not immediately clear why this would fail with a NullPointerException. Would it be possible for you to also share the APK that is not working?

in...@appyhapps.nl <in...@appyhapps.nl> #5May 9, 2023 12:44PM

We experience the same problem after we upgraded to Gradle 8. Identical problem as reported in this ticket: with the setActivity call on a session:

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
at com.google.android.gms.internal.fitness.zzfv.zza(com.google.android.gms:play-services-fitness@@21.1.0:1)
at com.google.android.gms.fitness.data.Session$Builder.setActivity(com.google.android.gms:play-services-fitness@@21.1.0:1)

It happens for example when invoking:
val session = Session.Builder()
.setDescription("our description")
.setIdentifier("our package name")
.setActivity(FitnessActivities.SLEEP)
.setStartTime(startSleepTime, TimeUnit.MILLISECONDS)
.setEndTime(endSleepTime, TimeUnit.MILLISECONDS)
.build()

We tried it with both with R8 fullMode default enabled and with R8 full mode disabled, but in both cases the error occurs.

We also tested this with JavaVersion.VERSION_1_8 and with JavaVersion.VERSION_17 and in both cases the problem occurs.

In all cases it works fine with a debug build.

We we revert to gradle 7.4.2. the problem disappears.

Please let me know how we can help you with additional information.

Message last modified on May 9, 2023 12:52PM

ch...@google.com <ch...@google.com> #6May 9, 2023 12:52PM

Would it be possible for you to share a small project that reproduces this?

The dump shared in comment #3 is a debug build, which does not seem to reproduce the issue.

in...@appyhapps.nl <in...@appyhapps.nl> #7May 9, 2023 02:48PM

(I'm not the original poster) I made phone dump just after the crash, I'm not sure if this will help. I don't want to share it here, because then others can download it too. If you want the phone dump log, then please let me know how to share it with you.

A small project reproducing this issue is difficult, it requires the Google Fit integration.

I'm trying to create the code dumps for a release build, but I never use the gradlew command line and it runs with some errors, that I'm not familiar with. I will try it in another way.

Message last modified on May 9, 2023 03:07PM

in...@appyhapps.nl <in...@appyhapps.nl> #8May 9, 2023 04:43PM

Hi, in the Test1App.zip a very small project. Runs well when compiling as debug, the nullpointer exception occurs when running as release build. The only thing that it does is creating a Google Fit session with Sleep as activity (but it happens also with other activity types).

Please let me know if you need more information.

Test1App.zip

1.3 MB

Download

ap...@google.com <ap...@google.com> #9May 10, 2023 09:16AM

Project: r8
Branch: main

commit 6c720a541af1562d61ccb0cf0727df6da0d22ba6
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:15:30 2023

Fix removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: Ief4e51fcccba7e777f57efe9377ab20e89ca0554

M src/main/java/com/android/tools/r8/ir/code/ArrayPut.java
M src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79347

ap...@google.com <ap...@google.com> #10May 10, 2023 09:16AM

Project: r8
Branch: main

commit bed41a13debd0875e508353cf79c33c751e49a22
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:01:26 2023

Reproduce removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: I2bb641c28d6b107db2f3daefd4e7fedcf85cbde9

A src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79346

ap...@google.com <ap...@google.com> #11May 10, 2023 09:34AM

Project: r8
Branch: 8.0

commit 6392f0ec0142bd168635cb7b8b7610b343679288
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:28:06 2023

Version 8.0.46

Bug:

b/280659987

Change-Id: I98398113ef7db1971e7f91cddf0227d80f715313

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/79351

ap...@google.com <ap...@google.com> #12May 10, 2023 09:34AM

Project: r8
Branch: 8.0

commit b7985cfb00840d9997e05eb5fa5084df2a7699c4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:28:00 2023

Fix removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: Ief4e51fcccba7e777f57efe9377ab20e89ca0554

M src/main/java/com/android/tools/r8/ir/code/ArrayPut.java
M src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79350

ap...@google.com <ap...@google.com> #13May 10, 2023 09:34AM

Project: r8
Branch: 8.0

commit 38eb966d483268f8f310b741a2652a64adea7d24
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:27:54 2023

Reproduce removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: I2bb641c28d6b107db2f3daefd4e7fedcf85cbde9

A src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79349

ap...@google.com <ap...@google.com> #14May 10, 2023 10:20AM

Project: r8
Branch: 8.1

commit 1a4e130758d76eca543445eddae6b76e4550fc41
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:32:45 2023

Version 8.1.46

Bug:

b/280659987

Change-Id: Ife577927219199e5be967e1a7ad1bf7286214579

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/79354

ap...@google.com <ap...@google.com> #15May 10, 2023 10:20AM

Project: r8
Branch: 8.1

commit cc131e0e6d743f357d81802d701b698f1b8aea08
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:31:17 2023

Fix removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: Ief4e51fcccba7e777f57efe9377ab20e89ca0554

M src/main/java/com/android/tools/r8/ir/code/ArrayPut.java
M src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79353

ap...@google.com <ap...@google.com> #16May 10, 2023 10:20AM

Project: r8
Branch: 8.1

commit 1ea9424e831c7ba9f213df00ac2ae674ea092349
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed May 10 11:30:43 2023

Reproduce removal of live array-puts in presence of Assume instruction

Bug:

b/280659987

Change-Id: I2bb641c28d6b107db2f3daefd4e7fedcf85cbde9

A src/test/java/com/android/tools/r8/rewrite/arrays/ArrayPutsToArrayAliasTest.java

https://r8-review.googlesource.com/79352

sg...@google.com <sg...@google.com> May 10, 2023 10:27AM

Marked as fixed.

ch...@google.com <ch...@google.com> #17May 10, 2023 11:38AM

Verified by ch...@google.com.

Thanks for sharing the reproduction. This is now fixed in R8 8.0.46 and 8.1.46. R8 8.0.46 and 8.1.46 should make it into AGP 8.0.2 and AGP 8.1.0-beta4, respectively.

Until that is released you can build with R8 8.0.46 by making the following change to settings.gradle or settings.gradle.kts.

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:8.0.46")
        }
    }
}

in...@appyhapps.nl <in...@appyhapps.nl> #18May 10, 2023 11:44AM

Thanks a lot for your quick follow-up on this issue. Nice that it has been fixed. I tested it and it works fine now.

Issue 280659987

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2May 4, 2023 08:41AM

sg...@google.com <sg...@google.com> May 4, 2023 03:07PM

[Deleted User] <[Deleted User]> #3May 5, 2023 03:28AM

ch...@google.com <ch...@google.com> #4May 8, 2023 11:28AM

in...@appyhapps.nl <in...@appyhapps.nl> #5May 9, 2023 12:44PM

ch...@google.com <ch...@google.com> #6May 9, 2023 12:52PM

in...@appyhapps.nl <in...@appyhapps.nl> #7May 9, 2023 02:48PM

in...@appyhapps.nl <in...@appyhapps.nl> #8May 9, 2023 04:43PM

ap...@google.com <ap...@google.com> #9May 10, 2023 09:16AM

ap...@google.com <ap...@google.com> #10May 10, 2023 09:16AM

ap...@google.com <ap...@google.com> #11May 10, 2023 09:34AM

ap...@google.com <ap...@google.com> #12May 10, 2023 09:34AM

ap...@google.com <ap...@google.com> #13May 10, 2023 09:34AM

ap...@google.com <ap...@google.com> #14May 10, 2023 10:20AM

ap...@google.com <ap...@google.com> #15May 10, 2023 10:20AM

ap...@google.com <ap...@google.com> #16May 10, 2023 10:20AM

sg...@google.com <sg...@google.com> May 10, 2023 10:27AM

ch...@google.com <ch...@google.com> #17May 10, 2023 11:38AM

in...@appyhapps.nl <in...@appyhapps.nl> #18May 10, 2023 11:44AM

Add comment

Issue metadata