Status Update
Comments
jl...@google.com <jl...@google.com>
sg...@google.com <sg...@google.com>
mk...@google.com <mk...@google.com> #2
i donnot understand why is the data the same?
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
What steps are needed to reproduce this issue? Frequency of occurrence?
Which Android build are you using? (e.g. AP4A.241205.013.A1)
Which device did you use to reproduce this issue?
Can you confirm if this issue is reproducible on a Pixel/Nexus device?
Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.
Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:
Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.
Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.
ap...@google.com <ap...@google.com> #5
Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.
ap...@google.com <ap...@google.com> #6
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。
as for Android build,all versions have it.
I dont reprodouce this issue.
what may be the cause of this issue?please
ap...@google.com <ap...@google.com> #7
We have shared this with our product and engineering team and will update this issue with more information as it becomes available.
ap...@google.com <ap...@google.com> #8
Thanks for reporting this issue.
COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.
Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.
ap...@google.com <ap...@google.com> #9
We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.
ap...@google.com <ap...@google.com> #10
ap...@google.com <ap...@google.com> #11
Branch: 8.1
commit a4d0b14c28e75c2b203567e79b2b8d07cf500af0
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 10:31:27 2023
Add test for incorrect rewriting of StringBuilder
Bug:
Change-Id: Ia84b2b0f1f25ae87c739a4569c1fd3f57b25f95b
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #12
Branch: 4.0
commit 571f176890d5c2bfbea9e94ec54211c00a840fac
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 11:05:40 2023
Version 4.0.61
Bug:
Change-Id: Iea80b11eaa7b6546e1ab218626cbe04c10499f67
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #13
Branch: 4.0
commit 14bf5c7d692fb2a2a05e1b9e479dc62a848e8165
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 11:05:03 2023
Reland "Ensure marking phi root as escaping if operand is escaping"
This reverts commit 4b8928aecee9c51aa41de88f3d465317882db798.
Bug:
Change-Id: I9783be336e733131f7b0cc0d52e9d205e1c88826
M src/main/java/com/android/tools/r8/ir/optimize/string/StringBuilderAppendOptimizer.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #14
Branch: 4.0
commit 1b785c4718a01e7c6425d74f345f4a3e641c68ff
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 11:04:46 2023
Add test for incorrect rewriting of StringBuilder
Bug:
Change-Id: Ia84b2b0f1f25ae87c739a4569c1fd3f57b25f95b
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #15
Branch: 8.0
commit 4d08e6871bfda4b727253e16b9609e5066e9ef02
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 10:34:16 2023
Reland "Ensure marking phi root as escaping if operand is escaping"
This reverts commit 4b8928aecee9c51aa41de88f3d465317882db798.
Bug:
Change-Id: I9783be336e733131f7b0cc0d52e9d205e1c88826
M src/main/java/com/android/tools/r8/ir/optimize/string/StringBuilderAppendOptimizer.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #16
Branch: 8.0
commit 9c5b1bd79335b739e20bc4942e6b3bd705bf6369
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 10:34:07 2023
Add test for incorrect rewriting of StringBuilder
Bug:
Change-Id: Ia84b2b0f1f25ae87c739a4569c1fd3f57b25f95b
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #17
Branch: 4.0
commit 14bf5c7d692fb2a2a05e1b9e479dc62a848e8165
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 11:05:03 2023
Reland "Ensure marking phi root as escaping if operand is escaping"
This reverts commit 4b8928aecee9c51aa41de88f3d465317882db798.
Bug:
Change-Id: I9783be336e733131f7b0cc0d52e9d205e1c88826
M src/main/java/com/android/tools/r8/ir/optimize/string/StringBuilderAppendOptimizer.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
M src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
ap...@google.com <ap...@google.com> #18
Branch: 4.0
commit 1b785c4718a01e7c6425d74f345f4a3e641c68ff
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 16 11:04:46 2023
Add test for incorrect rewriting of StringBuilder
Bug:
Change-Id: Ia84b2b0f1f25ae87c739a4569c1fd3f57b25f95b
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandTest.java
A src/test/java/com/android/tools/r8/ir/optimize/string/StringBuilderWithEscapingPhiOperandThroughAssignSideEffectTest.java
Description
####################################################
Please provide all of the following information, otherwise we may not be able to route your bug report.
####################################################
1. Describe the bug or issue that you're seeing.
Compiling reduced barebones project in debuggable=false or release mode produces incorrect dex, where
last call to .append(Char) is missing from the resulting dex.
If simple Log.w with the resulting sb is uncommented, append reappears.
I'm attaching the isolated case sources. I guess issue is related to some d8/r8 optimizations related to StringBuilder.
This is reproducible in Android plugin 8.0.0 to 8.2.0-alpha-02 with:
Android Studio Flamingo | 2022.2.1 Patch 1
Build #AI-222.4459.24.2221.9971841, built on April 19, 2023
Runtime version: 17.0.6+0-17.0.6b802.4-9586694 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
up to:
Android Studio Hedgehog | 2023.1.1 Canary 2
Build #AI-231.6890.12.2311.10027519, built on April 28, 2023
Runtime version: 17.0.6+0-17.0.6b829.5-9884540 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.4
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 10
Metal Rendering is ON
Registry:
external.system.auto.import.disabled=true
debugger.new.tool.window.layout=true
ide.text.editor.with.preview.show.floating.toolbar=false
ide.experimental.ui=true
2. Attach log files from Android Studio
2A. In the IDE, select the Help..Collect Logs and Diagnostic Data menu option.
2B. Create a diagnostic report and save it to your local computer.
2C. Attach the report to this bug using the Add attachments button.
3. If you know what they are, write the steps to reproduce:
3A.
3B.
3C.
In addition to logs, please attach a screenshot or recording that illustrates the problem.
For more information on how to get your bug routed quickly, see
Build: AI-231.6890.12.2311.10027519, 202304280409
AI-231.6890.12.2311.10027519, JRE 17.0.6+0-17.0.6b829.5-9884540x64 JetBrains s.r.o., OS Mac OS X(aarch64) v12.4, screens 3456.0x2234.0, 5120.0x2880.0, 5120.0x2880.0; Retina
AS: Hedgehog | 2023.1.1 Canary 2
Kotlin plugin: 231-1.8.0-release-345-AS6890.12.2311.10027519
Android Gradle Plugin: 8.2.0-alpha02
Gradle: 8.0
Gradle JDK: JetBrains Runtime version 17.0.6
NDK: from local.properties: (not specified), latest from SDK: 25.2.9519653
CMake: from local.properties: (not specified), latest from SDK: 3.18.1-g262b901, from PATH: 3.25.0
```