Can QueryCallback continue to support SAM conversion? [281008549]

Fixed

Bug

Status Update

No update yet.

Description

be...@bookbub.com

created issue #1

May 5, 2023 06:21PM

Component used: room-runtime Version used: 2.5.1 Devices/Android versions reproduced on: N/A

After upgrading a project from Room 2.4.2 to 2.5.1, I noticed a new compilation failure when setting a QueryCallback on our Room database. Since this upgrade moved us to a Room version written in Kotlin for the first time, I have a theory about the cause. I've also added a minimal repro project where the first and second commits compare room 2.4.2 and 2.5.1. My theory is below.

We had been using a lambda for our callback, along the lines of:

builder.setQueryCallback({ sqlQuery, bindArgs ->
    Log.d("Room DB", "SQL Query: $sqlQuery SQL Args: $bindArgs")
  },
  Executors.newSingleThreadExecutor())

This worked, presumably, because the compiler performed a single-abstract-method (SAM) conversion and treated the lambda expression as an implementation of QueryCallback.onQuery.

Following the Room upgrade to Kotlin for its own code, I believe this conversion no longer occurs. Kotlin supports SAM conversions for Kotlin interfaces, but they must be declared as fun interface Foo rather than just interface Foo. As of 2.5.2, QueryCallback is just an interface.

This isn't blocking, strictly. We can instead construct an object implementing QueryCallback in place of the lambda:

object : QueryCallback {
  override fun onQuery(sqlQuery: String, bindArgs: List<Any?>) {
    Log.d("Room DB", "SQL Query: $sqlQuery SQL Args: $bindArgs")
  }
}

But in addition to being more verbose, I found I had to add a -Xjvm-default=enable compiler flag to our project so that the interface implementation would compile. Ideally we'd be able to continue relying on SAM conversion and write a lambda instead.

Comments

el...@google.com <el...@google.com> May 17, 2023 06:31PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2May 18, 2023 02:35PM

Related ticket: b/152046065

da...@google.com <da...@google.com> May 18, 2023 02:39PM

Marked as fixed.

pr...@google.com <pr...@google.com> #3Jun 21, 2023 08:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Nov 04 17:35:35 2020

Add Modifier.focusable

This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support

Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
Bug: 152525426
Bug: 162865824
Bug: 163423216
Test: added

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt

https://android-review.googlesource.com/1487281

Issue 281008549

Description

Issue summary

Comments

el...@google.com <el...@google.com> May 17, 2023 06:31PM

ap...@google.com <ap...@google.com> #2May 18, 2023 02:35PM

da...@google.com <da...@google.com> May 18, 2023 02:39PM

pr...@google.com <pr...@google.com> #3Jun 21, 2023 08:58PM

Add comment

Issue metadata