Material 3 ModalBottomSheet isn't dismissed if enableOnBackInvokedCallback is true [281967264]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 11, 2023 03:07PM

Jetpack Compose version: 2023.05.01 Jetpack Compose component used: material3 (1.1.0) Android Studio Build: #AI-222.4459.24.2221.9971841, built on April 19, 2023 Kotlin version: 1.8.21

Steps to Reproduce or Code Sample to Reproduce:

Add android:enableOnBackInvokedCallback="true" in the manifest
Run the ModalBottomSheet sample from here
Observe the bottom sheet isn't dismissed on back tap

I have a minimum reproducible example here: https://github.com/tfcporciuncula/material3-bottomsheet/tree/back (in the back branch)

Comments

6o...@gmail.com <6o...@gmail.com> #2Jul 14, 2023 09:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit c9cf25062fed6a75c01e6fb7bad692ad6320a6e9
Author: Leticia Santos <leticiars@google.com>
Date: Wed Dec 06 13:33:47 2023

[NavigationSuiteScaffold] Fixed navigation component filling entire screen when root surface has modifier.fillMaxSize

When using Surface with fillMaxSize it tries to fill its entire available space with the first composable it finds, but wrapping that composable in a Box prevents that.

Test: manually tested
Bug: 312664933
Change-Id: Ifd23d070ab09f1750384d42ef43a5dc252fac560

M compose/material3/material3-adaptive-navigation-suite/src/commonMain/kotlin/androidx/compose/material3/adaptive/navigation-suite/NavigationSuiteScaffold.kt

https://android-review.googlesource.com/2861890

ma...@google.com <ma...@google.com> #3Jul 14, 2023 11:18PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3-adaptive-navigation-suite:1.0.0-alpha02
androidx.compose.material3:material3-adaptive-navigation-suite-android:1.0.0-alpha02
androidx.compose.material3:material3-adaptive-navigation-suite-desktop:1.0.0-alpha02

eg...@gmail.com <eg...@gmail.com> #4Dec 13, 2023 08:49AM

Project: platform/frameworks/support
Branch: androidx-main

commit f6f510999615b25e0a1c118f1136a40bdef6f31f
Author: Leticia Santos <leticiars@google.com>
Date: Tue Jan 23 15:23:34 2024

[NavigationSuiteScaffold] Add some tests.

These tests are related to aosp/2861890

Test: self
Bug: 312664933
Change-Id: I63bda11216f0fc36927ce0b694b82490203ead03

A compose/material3/material3-adaptive-navigation-suite/src/androidInstrumentedTest/kotlin/androidx/compose/material3/adaptive-navigation-suite/NavigationSuiteScaffoldTest.kt

https://android-review.googlesource.com/2924390

ma...@google.com <ma...@google.com> Dec 13, 2023 07:06PM

Reassigned to dn...@google.com.

dn...@google.com <dn...@google.com> Dec 14, 2023 06:18PM

Accepted by dn...@google.com.

dn...@google.com <dn...@google.com> #5Jan 4, 2024 06:10PM

Marked as fixed.

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/2885946, and will improve the predictive back animation in https://android-review.googlesource.com/c/platform/frameworks/support/+/2863667.

ap...@google.com <ap...@google.com> #6Feb 13, 2024 07:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 699ee4fa3f47da2ccd52fb6b4628fc2d61cd5039
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 06 20:50:22 2023

Update Compose M3 ModalBottomSheet to support Predictive Back on U+

Bug: 281967264
Bug: 307969902
Bug: 304850357
Test: added screenshot tests
Relnote: "Update Compose M3 ModalBottomSheet to support Predictive Back on U+"
Change-Id: Iccf324cb6dfc7f4ea1fe413b69e035658282360d

A compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetScreenshotTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.android.kt
A compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/PredictiveBack.android.kt

https://android-review.googlesource.com/2863667

pr...@google.com <pr...@google.com> #7Feb 21, 2024 07:32PM