Material 3 ModalBottomSheet isn't dismissed if enableOnBackInvokedCallback is true [281967264]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 11, 2023 03:07PM

Jetpack Compose version: 2023.05.01 Jetpack Compose component used: material3 (1.1.0) Android Studio Build: #AI-222.4459.24.2221.9971841, built on April 19, 2023 Kotlin version: 1.8.21

Steps to Reproduce or Code Sample to Reproduce:

Add android:enableOnBackInvokedCallback="true" in the manifest
Run the ModalBottomSheet sample from here
Observe the bottom sheet isn't dismissed on back tap

I have a minimum reproducible example here: https://github.com/tfcporciuncula/material3-bottomsheet/tree/back (in the back branch)

Comments

6o...@gmail.com <6o...@gmail.com> #2Jul 14, 2023 09:52PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ma...@google.com <ma...@google.com> #3Jul 14, 2023 11:18PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

eg...@gmail.com <eg...@gmail.com> #4Dec 13, 2023 08:49AM

looks like in progress https://android-review.googlesource.com/c/platform/frameworks/support/+/2863667

ma...@google.com <ma...@google.com> Dec 13, 2023 07:06PM

Reassigned to dn...@google.com.

dn...@google.com <dn...@google.com> Dec 14, 2023 06:18PM

Accepted by dn...@google.com.

dn...@google.com <dn...@google.com> #5Jan 4, 2024 06:10PM

Marked as fixed.

Fixed in https://android-review.googlesource.com/c/platform/frameworks/support/+/2885946, and will improve the predictive back animation in https://android-review.googlesource.com/c/platform/frameworks/support/+/2863667.

ap...@google.com <ap...@google.com> #6Feb 13, 2024 07:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 699ee4fa3f47da2ccd52fb6b4628fc2d61cd5039
Author: Dan Nizri <dniz@google.com>
Date: Wed Dec 06 20:50:22 2023

Update Compose M3 ModalBottomSheet to support Predictive Back on U+

Bug: 281967264
Bug: 307969902
Bug: 304850357
Test: added screenshot tests
Relnote: "Update Compose M3 ModalBottomSheet to support Predictive Back on U+"
Change-Id: Iccf324cb6dfc7f4ea1fe413b69e035658282360d

A compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetScreenshotTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/SearchBar.android.kt
A compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/PredictiveBack.android.kt

https://android-review.googlesource.com/2863667

pr...@google.com <pr...@google.com> #7Feb 21, 2024 07:32PM