Material 3 ModalBottomSheet isn't dismissed if enableOnBackInvokedCallback is true [281967264]

Fixed

Bug

Status Update

No update yet.

Description

tf...@gmail.com

created issue #1

May 11, 2023 03:07PM

Jetpack Compose version: 2023.05.01 Jetpack Compose component used: material3 (1.1.0) Android Studio Build: #AI-222.4459.24.2221.9971841, built on April 19, 2023 Kotlin version: 1.8.21

Steps to Reproduce or Code Sample to Reproduce:

Add android:enableOnBackInvokedCallback="true" in the manifest
Run the ModalBottomSheet sample from here
Observe the bottom sheet isn't dismissed on back tap

I have a minimum reproducible example here: https://github.com/tfcporciuncula/material3-bottomsheet/tree/back (in the back branch)

Comments

6o...@gmail.com <6o...@gmail.com> #2Jul 14, 2023 09:52PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ma...@google.com <ma...@google.com> #3Jul 14, 2023 11:18PM

Thanks for the report!

eg...@gmail.com <eg...@gmail.com> #4Dec 13, 2023 08:49AM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ma...@google.com <ma...@google.com> Dec 13, 2023 07:06PM

Reassigned to dn...@google.com.

dn...@google.com <dn...@google.com> Dec 14, 2023 06:18PM

Accepted by dn...@google.com.

dn...@google.com <dn...@google.com> #5Jan 4, 2024 06:10PM

Marked as fixed.

deleted

ap...@google.com <ap...@google.com> #6Feb 13, 2024 07:29PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

pr...@google.com <pr...@google.com> #7Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha01
androidx.compose.material3:material3-android:1.3.0-alpha01
androidx.compose.material3:material3-desktop:1.3.0-alpha01