IssueTracker

Please note: This component is for the CameraX API used in Jetpack. Please DO NOT file Pixel Camera issues here.

Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.

// If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat) when you're experiencing the issue, preferably while the camera is still active.

CAMERAX VERSION 1.0.0.alpha06

CAMERA APPLICATION NAME AND VERSION: Vector (com.convoy.loaddoc) version 10.8.509

ANDROID OS BUILD NUMBER: OPPS27.91-99-9-15

DEVICE NAME: Motorola E5

DESCRIPTION: NullPointerException in cameraProvider.bindToLifecycle on devices that have no high resolution modes.
The problem is if `mImpl.getHighResolutionOutputSizes(format);` returns null (see code fragment below), it will still cache it, and the second invocation will retrieve the null and attempt to call clone(), crashing the app.
The `mCachedFormatHighResolutionOutputSizes.put(format, outputSizes);` line should be moved into the body of the if statement, and/or a null check should be added to the fetch before calling clone().

LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)
none

STEPS TO REPRODUCE:
1. Launch app and login
2. Start a workflow by clicking the + button in the bottom right
3. Find a camera icon and click it.
4. Go through the image capture sequence.
5. Click "add image" to add a second image next to the first
6. Click the image capture (shutter) button

OBSERVED RESULTS:
The app displays a crash alert

EXPECTED RESULTS:
The app should not crash

REPRODUCIBILITY: (5 of 5, 1 of 100, etc)

ADDITIONAL INFORMATION:

CODE FRAGMENTS (this will help us troubleshoot your issues):
@Nullable
    public Size[] getHighResolutionOutputSizes(int format) {
        if (mCachedFormatHighResolutionOutputSizes.containsKey(format)) {
            return mCachedFormatHighResolutionOutputSizes.get(format).clone();
        }

        Size[] outputSizes = mImpl.getHighResolutionOutputSizes(format);

        // High resolution output sizes can be null.
        if (outputSizes != null && outputSizes.length > 0) {
            outputSizes = mOutputSizesCorrector.applyQuirks(outputSizes, format);
        }

        mCachedFormatHighResolutionOutputSizes.put(format, outputSizes);
        return outputSizes != null ? outputSizes.clone() : null;
    }