Remove @SuppressLint("BanThreadSleep") and associated usage of Thread.sleep() from FledgeCtsDebuggableTest [282027269]

Assigned

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

May 11, 2023 06:01PM

`Thread.sleep()` is banned in Jetpack tests. Please migrate your test to a suitable callback mechanism or the test will be disabled.

Comments

np...@google.com <np...@google.com> #2May 12, 2023 03:55PM

Reassigned to ar...@google.com.

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Expected output
What is the expected output?

Current output
What is the current output?

np...@google.com <np...@google.com> #3May 12, 2023 04:00PM

How can you possibly need more information, i just told you the exact part of code causing the issue, and the code changes required to fix it!
Please read the description.

Expected output:
What is the expected output?
See attached "expected.webm" video in OP

Current output
What is the current output?
See attached "actual.webm" video in OP

np...@google.com <np...@google.com> #4May 12, 2023 04:02PM

1. Import attached project
2. Install and run on Android 5 (Lollipop) or above
3. Click FAB and see it fall below/behind the navigation bar once the Snackbar disappear

au...@google.com <au...@google.com> #5May 12, 2023 04:38PM

Could you please check the attached project as we couldn't extract the files from it.

ar...@google.com <ar...@google.com> #6May 12, 2023 05:43PM

Reassigned to ga...@google.com.

It's a RAR archive, there's no issue with it.
However you have problems extracting such, here's the same content as a ZIP archive.

ga...@google.com <ga...@google.com> #7May 12, 2023 06:11PM

Thank you for reporting this issue. We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ga...@google.com <ga...@google.com> #8Apr 4, 2024 07:41PM

Status: Won't Fix (Intended Behavior)

@ coordinator layout,

Please check this issue and provide your inputs.

au...@google.com <au...@google.com> #9Apr 4, 2024 07:50PM

Status: Assigned (reopened)

This is still an issue in 1.2.0. Looks like nobody at Google uses FABs with Snackbars in CoordinatorLayout? How can such obvious issue be still present after more than 3 years?

ga...@google.com <ga...@google.com> #10Apr 5, 2024 06:48AM

Reassigned to pr...@google.com.

This seems to work around the issue successfully:

snackbar.addCallback(object : Snackbar.Callback() {
    override fun onDismissed(transientBottomBar: Snackbar?, event: Int) {
        transientBottomBar?.removeCallback(this)
        Handler(Looper.getMainLooper()).post {
            coordinatorLayout?.requestApplyInsets()
        }
    }
})

ga...@google.com <ga...@google.com> #11Apr 5, 2024 06:51AM

@pr...@google.com This should be part of the work for JetPack test stabilization we need to complete in April (thanks @au...@google.com for the suggestions)

au...@google.com <au...@google.com> #12Apr 26, 2024 08:47PM

Are there any updates here?

pr...@google.com <pr...@google.com> #13Apr 27, 2024 11:07AM

Sorry for the delay. I have picked up this task in this iteration. Will be sending a fix soon.

au...@google.com <au...@google.com> #14Nov 5, 2024 11:59PM

Any updates here?

All of these usages of thread.sleep still exist?

https://cs.android.com/search?q=BanThreadSleep%20file:privacysandbox&sq=&ss=androidx%2Fplatform%2Fframeworks%2Fsupport