Status Update
Comments
re...@gmail.com <re...@gmail.com>
re...@gmail.com <re...@gmail.com> #2
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ad...@google.com <ad...@google.com>
ad...@google.com <ad...@google.com> #3
as...@google.com <as...@google.com> #4
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
re...@gmail.com <re...@gmail.com> #5
ad...@google.com <ad...@google.com> #6
The issue has been fixed and it will be available in a future build.
jl...@gmail.com <jl...@gmail.com> #7
as...@google.com <as...@google.com> #8
Re:
jl...@gmail.com <jl...@gmail.com> #9
I have a OnePlus 10Pro (NE2215) running Android 14. Happy to provide any additional info as needed.
as...@google.com <as...@google.com> #10
Re: #9 - It's possible OnePlus hasn't picked up the relevant fix in their builds, since it went into the branch a little while after the initial Android 14 branch cut. For Pixel devices, Google has typically released builds with collections of fixes roughly quarterly, and the source for those changes are released to partners as well as publicly in the AOSP source, but each OEM seems to follow their own schedule for whether/when they put these incremental fixes in their builds that get pushed to users.
You might try contacting OnePlus to ask about their schedule for releasing incremental fixes. For this issue, the most relevant commit is this one:
Description
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)
What type of Android issue is this? User Interface, Display, or Rendering issue
When did this happen?
May 12, 2023 10:00 AM GMT-06:00
What steps would let us observe this issue?
1. AOD turns off after initial connection to WIRED Android Auto. I have to press the power button to turn the screen on. This is NOT the expected behavior.
AOD turns off after initial connection to WIRELESS Android Auto. I have to press the power button to turn the screen on. This is NOT the expected behavior.
AOD turns off after a notification is received, while connected to Android Auto, wired or wireless. I have to press the power button to turn the screen on. This is NOT the expected behavior.
AOD does NOT turn off after silent notification is received, while connected to Android Auto, wired or wireless. This IS the expected behavior.
Android Auto on the vehicle's head unit does work as expected, while connected, no issues there.
This issue has been present since the initial release of Android 13. I did a factory reset after receiving the Android 13 update, but the issue was still present. The issue is still present now in Android 14 beta 2. In the meantime, I've disabled "Wake screen for notifications", under Display -> Lock screen. While it doesn't solve the problem, at least my screen doesn't just black out on me. Still waiting for a permanent fix.
What did you expect to happen?
I expect the screen (AOD) to stay on after the initial connection to Android Auto, either wired or wireless. I expect the screen (AOD) to stay on after receiving notifications. I shouldn't have to use the power button to turn the screen back on.
What actually happened?
The screen (AOD) turns off after the initial connection to Android Auto. The screen (AOD) turns off after receiving notifications. I shouldn't have to use the power button to turn the screen back on.
How often has this happened?
Every time
What was the effect of this issue on your device usage, such as lost time or work?
High
Additional comments
I reported the issue to the Android Auto team. They emailed me back in regards to my bug report. From the email:
"The team has reviewed the bug report and found that the issue is with the Android System UI and not with Android Auto. We suggest contacting the device support for further assistance on this. Thanks"
Debugging information
Google Play services
com.google.android.gms
Version 231613044 (23.16.13 (190400-527363516))
System App (Updated)
Android System WebView
com.google.android.webview
Version 567252433 (113.0.5672.24)
System App (Updated)
Network operator: SaskTel
SIM operator: SaskTel
Filed by Android Beta Feedback. Version (Updated): 2.34-betterbug.external_20230413_RC05 (DOGFOOD)
To learn more about our feedback process, please visit