Clarify failures on devices misconfigured for tracing/compilation [282191686]

Fixed

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

May 12, 2023 05:48PM

Since fixes are slow to roll out, we should have benchmark clearly tell people they're using unsupported emulators if they run into the following bugs:

b/272339637 b/244619933

For the tracing issue, if perfetto capture start fails, do something like:

if (!File("/sys/kernel/debug/tracing/trace_marker").exists() && !File("/sys/kernel/tracing/trace_marker").exists()) {
    val deviceType = DeviceInfo.isEmulator ? "emulator" : "device"
    throw IllegalStateException("This $deviceType system image is misconfigured, and doesn't support tracing. Try a different $deviceType (or updating, if possible).")
}

And add something similar for the compilation failure.

Comments

cc...@google.com <cc...@google.com> #2May 12, 2023 05:50PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ma...@google.com <ma...@google.com> Jun 6, 2023 07:19PM

Accepted by ma...@google.com.

cc...@google.com <cc...@google.com> #3Jun 6, 2023 08:13PM

yea i'll take it.

ma...@google.com <ma...@google.com> Jun 13, 2023 05:44PM

Assigned to ma...@google.com.

cc...@google.com <cc...@google.com> Jun 13, 2023 05:45PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #4Jul 15, 2023 12:00AM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ap...@google.com <ap...@google.com> #5Jul 17, 2023 05:45PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

cc...@google.com <cc...@google.com> Jul 17, 2023 08:07PM

Marked as fixed.

na...@google.com <na...@google.com> #6Jul 26, 2023 06:38PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)