Remove or stabilize perfetto-common dependency to enable benchmark to go to beta/stable [282199917]

Duplicate

of 288257859

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

May 12, 2023 06:50PM

No description yet.

Comments

jg...@google.com <jg...@google.com> #2May 16, 2023 12:41PM

Depending on the timelines for pushing Benchmark 1.2 stable, we have two options for androidx.tracing.tracing-perfetto:

Include cold start tracing and key-value pair logging (required for logging the Reason for Recomposition)
Release what we currently have as stable (after doing a minimum amount of renames and API reviews).

Approach 1 will result in less churn as we won't have to 'fork' the library while working on Reason for Recomposition. Forking is a bit cumbersome while in Beta (once a release branch is cut it only involves cherry-picking).

ap...@google.com <ap...@google.com> #3Jun 15, 2023 06:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7c4083b2b6533c511407144bf2343b3ead73369f
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 17:19:21 2023

Clean-up after tracing-perfetto-common rename

Cleaning up a comment after tracing-perfetto-common rename to
tracing-perfetto-handshake has landed.

Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: Ib6681fa293e140b3ee555db0adcd56c07fc20a21

M tracing/tracing-perfetto-handshake/src/main/java/androidx/tracing/perfetto/handshake/protocol/Protocol.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/internal/handshake/protocol/Protocol.kt

https://android-review.googlesource.com/2626593

ap...@google.com <ap...@google.com> #4Jun 16, 2023 09:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7355109a67c537000ba3517779b2669dfee14e3e
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 18:57:03 2023

Making Tracing Perfetto SDK APIs consistent

Making Tracing Perfetto SDK APIs consistent with android.os.Trace

Part of a WIP refactoring. Not intended as the final API.

Relnote: "Making Tracing Perfetto SDK APIs consistent with
android.os.Trace"

Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: I73ba07ca6cc4bd2b6519553c395fe9075a49fe75

M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt
M compose/runtime/runtime-tracing/src/main/java/androidx/compose/runtime/tracing/ComposeTracingInitializer.kt
M tracing/tracing-perfetto/api/current.txt
M tracing/tracing-perfetto/api/restricted_current.txt
M tracing/tracing-perfetto/src/androidTest/java/androidx/tracing/perfetto/test/TracingTest.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/StartupTracingInitializer.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/Trace.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/TracingReceiver.kt

https://android-review.googlesource.com/2626594

cc...@google.com <cc...@google.com> #5Jul 13, 2023 08:42PM

Status: Duplicate of

288257859

tracing perfetto is going to beta together with Benchmark, so marking as dupe of that tracking bug.

na...@google.com <na...@google.com> #6Jul 18, 2023 05:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-beta01
androidx.tracing:tracing-perfetto:1.0.0-beta01
androidx.tracing:tracing-perfetto-handshake:1.0.0-beta01

Issue 282199917