Status Update
Comments
jg...@google.com <jg...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 44c49090d5f4727e1dc6f883b4345dc0ac487254
Author: Adam Powell <adamp@google.com>
Date: Fri Aug 28 09:02:47 2020
Set MonotonicFrameClock for composition scopes
Install the Recomposer's broadcast frame clock as the CoroutineContext's
MonotonicFrameClock for CoroutineScopes created from composition. This
includes both the launchInComposition and rememberCoroutineScope APIs.
This fixes a bug where users of the withFrameNanos API family would see
the wrong MonotonicFrameClock, leading to animation jank as the ordering
of Choreographer callbacks for the recomposer and the animation with
regard to one another was inconsistent. Installing the Recomposer's clock
into the context allows the Recomposer to control this timing.
Fixes: 166778123
Test: SuspendingEffectsTests.kt
Relnote: "CompositionCoroutineScope no longer implements
MonotonicFrameClock. Callers of withFrameNanos should import the top-level
function explicitly."
Change-Id: Icb642e00a670c235f26d11e6549b4222b2b4c2fb
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/SuspendingEffectsTests.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/SuspendingEffects.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.kt
https://android-review.googlesource.com/1413685
Branch: androidx-master-dev
commit 44c49090d5f4727e1dc6f883b4345dc0ac487254
Author: Adam Powell <adamp@google.com>
Date: Fri Aug 28 09:02:47 2020
Set MonotonicFrameClock for composition scopes
Install the Recomposer's broadcast frame clock as the CoroutineContext's
MonotonicFrameClock for CoroutineScopes created from composition. This
includes both the launchInComposition and rememberCoroutineScope APIs.
This fixes a bug where users of the withFrameNanos API family would see
the wrong MonotonicFrameClock, leading to animation jank as the ordering
of Choreographer callbacks for the recomposer and the animation with
regard to one another was inconsistent. Installing the Recomposer's clock
into the context allows the Recomposer to control this timing.
Fixes: 166778123
Test: SuspendingEffectsTests.kt
Relnote: "CompositionCoroutineScope no longer implements
MonotonicFrameClock. Callers of withFrameNanos should import the top-level
function explicitly."
Change-Id: Icb642e00a670c235f26d11e6549b4222b2b4c2fb
M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/androidAndroidTest/kotlin/androidx/compose/runtime/SuspendingEffectsTests.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/SuspendingEffects.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 7c4083b2b6533c511407144bf2343b3ead73369f
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 17:19:21 2023
Clean-up after tracing-perfetto-common rename
Cleaning up a comment after tracing-perfetto-common rename to
tracing-perfetto-handshake has landed.
Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: Ib6681fa293e140b3ee555db0adcd56c07fc20a21
M tracing/tracing-perfetto-handshake/src/main/java/androidx/tracing/perfetto/handshake/protocol/Protocol.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/internal/handshake/protocol/Protocol.kt
https://android-review.googlesource.com/2626593
Branch: androidx-main
commit 7c4083b2b6533c511407144bf2343b3ead73369f
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 17:19:21 2023
Clean-up after tracing-perfetto-common rename
Cleaning up a comment after tracing-perfetto-common rename to
tracing-perfetto-handshake has landed.
Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: Ib6681fa293e140b3ee555db0adcd56c07fc20a21
M tracing/tracing-perfetto-handshake/src/main/java/androidx/tracing/perfetto/handshake/protocol/Protocol.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/internal/handshake/protocol/Protocol.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 7355109a67c537000ba3517779b2669dfee14e3e
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 18:57:03 2023
Making Tracing Perfetto SDK APIs consistent
Making Tracing Perfetto SDK APIs consistent with android.os.Trace
Part of a WIP refactoring. Not intended as the final API.
Relnote: "Making Tracing Perfetto SDK APIs consistent with
android.os.Trace"
Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: I73ba07ca6cc4bd2b6519553c395fe9075a49fe75
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt
M compose/runtime/runtime-tracing/src/main/java/androidx/compose/runtime/tracing/ComposeTracingInitializer.kt
M tracing/tracing-perfetto/api/current.txt
M tracing/tracing-perfetto/api/restricted_current.txt
M tracing/tracing-perfetto/src/androidTest/java/androidx/tracing/perfetto/test/TracingTest.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/StartupTracingInitializer.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/Trace.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/TracingReceiver.kt
https://android-review.googlesource.com/2626594
Branch: androidx-main
commit 7355109a67c537000ba3517779b2669dfee14e3e
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Jun 15 18:57:03 2023
Making Tracing Perfetto SDK APIs consistent
Making Tracing Perfetto SDK APIs consistent with android.os.Trace
Part of a WIP refactoring. Not intended as the final API.
Relnote: "Making Tracing Perfetto SDK APIs consistent with
android.os.Trace"
Bug: 282199917
Test: PerfettoSdkHandshakeTest
Change-Id: I73ba07ca6cc4bd2b6519553c395fe9075a49fe75
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
M benchmark/benchmark/src/androidTest/java/androidx/benchmark/benchmark/PerfettoSdkOverheadBenchmark.kt
M compose/runtime/runtime-tracing/src/main/java/androidx/compose/runtime/tracing/ComposeTracingInitializer.kt
M tracing/tracing-perfetto/api/current.txt
M tracing/tracing-perfetto/api/restricted_current.txt
M tracing/tracing-perfetto/src/androidTest/java/androidx/tracing/perfetto/test/TracingTest.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/StartupTracingInitializer.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/Trace.kt
M tracing/tracing-perfetto/src/main/java/androidx/tracing/perfetto/TracingReceiver.kt
na...@google.com <na...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.2.0-beta01
androidx.tracing:tracing-perfetto:1.0.0-beta01
androidx.tracing:tracing-perfetto-handshake:1.0.0-beta01
Description
No description yet.