Missing `key` parameter for `GlanceModifier.clickable` [282445798]

Fixed

Bug

Status Update

No update yet.

Description

fa...@gmail.com

created issue #1

May 15, 2023 08:52AM

Component used: Glance-widget Version used: beta01 Devices/Android versions reproduced on: various devices

One of the two overloads of GlanceModifier.clickable accepts a lambda () -> Unit which uses it to create an Action as action(block). action accepts an optional key value; clickable should accept an optional key as well, as a parameter, to pass to action.

This is important because using GlanceModifier.clickable without an explicit key, could lead to unexpected behaviors.

Example: Observing a Flow emitting a, b, c, where every item is used in the same order to create a clickable item, the actions will be incorrect, when the Flow then emits c, a, b, unless we create an action with an explicit key to identify the item

Comments

za...@google.com <za...@google.com> May 15, 2023 08:06PM

Reassigned to wv...@google.com.

wv...@google.com <wv...@google.com> May 31, 2023 01:56PM

Accepted by wv...@google.com.

wv...@google.com <wv...@google.com> Jun 6, 2023 11:59PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Jun 6, 2023 11:59PM

To provide some context , R8 removes code that is not referenced directly at runtime.

It is a known issue in kotlinx serialization where serializable classes & types are shrunk/obfuscated when not referenced directly. Mitigation includes custom proguard rules to keep all classes marked with @Serializable.

In the context of navigation + kotlinx serialization, we will have to look into whether navigation can viably prevent this shrinkage/obfuscation.

In the mean time, we will be adding a lint rule to remind users to use @Keep.

na...@google.com <na...@google.com> #3Jul 26, 2023 05:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4940c45ab1632128129bfb64b4fd42320b081c92
Author: Clara Fok <clarafok@google.com>
Date: Mon Sep 16 13:04:40 2024

Add navigation-common lint for Keep annotation

We need to make sure that Enums that are used as nav arguments in type-safe routes are annotated with @Keep. The e
ntry point to locating said Enums are rotue declarations that contains Enum arguments.

Since the entry point is essentially the same lint location for linting @Serializable annotation, this lint uses the same detector but expands upon it.

Test: ./gradlew navigation:navigation-common-lint:test
Bug:358687142
Change-Id: I2b46fbc3b5be6251d89e902e315f50f20c46ce19

M navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/NavigationCommonIssueRegistry.kt
M navigation/navigation-common-lint/src/main/java/androidx/navigation/common/lint/TypeSafeDestinationMissingAnnotationDetector.kt
A navigation/navigation-common-lint/src/test/java/androidx/navigation/common/lint/MissingKeepAnnotationDetectorTest.kt

https://android-review.googlesource.com/3270115

Issue 282445798