Fixed
Status Update
Comments
za...@google.com <za...@google.com>
wv...@google.com <wv...@google.com>
wv...@google.com <wv...@google.com>
ap...@google.com <ap...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
na...@google.com <na...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
Component used: Glance-widget Version used: beta01 Devices/Android versions reproduced on: various devices
One of the two overloads of
GlanceModifier.clickable
accepts a lambda() -> Unit
which uses it to create an Action asaction(block)
.action
accepts an optionalkey
value;clickable
should accept an optionalkey
as well, as a parameter, to pass toaction
.This is important because using
GlanceModifier.clickable
without an explicitkey
, could lead to unexpected behaviors.Example: Observing a
Flow
emittinga, b, c
, where every item is used in the same order to create a clickable item, the actions will be incorrect, when theFlow
then emitsc, a, b
, unless we create an action with an explicitkey
to identify the item