IssueTracker

This is a platform behavior change.

b/236862874 is related.

Any progress?

Thanks for the comment#1 report. The bug in how those older versions of the framework dispatch insets does make handling insets difficult. It's on our roadmap for early 2025 to prepare an AndroidX-side workaround.

This issue is also stopping us from being able to support edge-to-edge in Android 15. Given it's a enforced requirement for targeting Android 15, couldn't this be prioritised higher? Companies like us have hundreds of screens to fix so waiting until 2025 for a workaround is going to be tough work.

Maybe you can create a static method, com.your.company.ViewGroupCompat#installCompatInsetsDispatch, like this: https://android-review.googlesource.com/c/platform/frameworks/support/+/3310617/2/core/core/src/main/java/androidx/core/view/ViewGroupCompat.java ?

After creating the method, you need to call ViewGroupCompat.installCompatInsetsDispatch(getWindow().getDecorView()) in onCreate() of your activity to make the behavior compatible with API 30+.

When the new library with the API is released, you can replace com.your.company.ViewGroupCompat with androidx.core.view.ViewGroupCompat.

Wow quick response, thanks! I just tried applying that workaround to our root view and can confirm it fixes the issue. (Also FYI there's a typo in the PR; "comsumed")

I'm getting a crash when using new version of ktx-core 1.16.0-alpha01 with fixed ViewCompat and ViewGroupCompat on API < 30. This is related to FragmentContainerView:

java.lang.NullPointerException: Parameter specified as non-null is null: method androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener, parameter listener
	at androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener(Unknown Source:2)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:255)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.dispatchApplyWindowInsets(ViewGroupCompat.java:264)
	at androidx.core.view.ViewGroupCompat.lambda$installCompatInsetsDispatch$0(ViewGroupCompat.java:218)
	at androidx.core.view.ViewGroupCompat$$ExternalSyntheticLambda1.onApplyWindowInsets(D8$$SyntheticClass:0)
	at android.view.View.dispatchApplyWindowInsets(View.java:10499)
	at android.view.ViewGroup.dispatchApplyWindowInsets(ViewGroup.java:7191)
	at android.view.ViewRootImpl.dispatchApplyInsets(ViewRootImpl.java:1925)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2030)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1721)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7598)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:966)
	at android.view.Choreographer.doCallbacks(Choreographer.java:790)
	at android.view.Choreographer.doFrame(Choreographer.java:725)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:951)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Re comment#13:

I think the @NonNull annotation of androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener has been removed since If694a3b70bf84f03c95d67d20e58485135ab7d86 which has been included since androidx.fragment 1.4.0-alpha09.

Do you mind upgrading your androidx.fragment version to 1.4.0-alpha09 or above? The latest version is 1.8.5.

This bug has been fixed by I111590881991b94e5cd5f2100bf88dd4468bc781 since core#1.16.0-alpha01. Let's mark it as fixed.

See: https://developer.android.com/jetpack/androidx/releases/core#1.16.0-alpha01

I'm sure I was using the latest androidx.fragment 1.8.5. It can be reproduced here, could you check it?

Ah, you are right. It still requires a non-null object since the required type is not OnApplyWindowInsetsListener? but OnApplyWindowInsetsListener.

    public override fun setOnApplyWindowInsetsListener(listener: OnApplyWindowInsetsListener) {
        applyWindowInsetsListener = listener
    }

Hi Jeremy,

Do you mind checking why androidx.fragment.app.FragmentContainerView.setOnApplyWindowInsetsListener requires a non-null parameter? The restriction was added in this CL.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link:      https://android-review.googlesource.com/3443279

Change the nullability of setOnApplyWindowInsetsListener

Change the nullability of setOnApplyWindowInsetsListener 
 
Since setOnApplyWindowInsetsListener overrides a method from the View 
class which is in java and has no nullability, we did not know the 
proper nullability. 
 
It seems there are cases when the inset listener could indeed be null, 
so we can make that nullable now. 
 
RelNote: "FragmentContainerView's `setOnApplyWindowInsetsListener` 
override now takes a null listener." 
Test: All tests pass 
Bug: 282790626 
 
Change-Id: I575f0b5da72d096b14393afd9819ab66e061b002

Hey Tiger,

I made it nullable again. We will release this in the next couple of weeks or so.

Thank you Jeremy.

Since comment#13 is an issue different from comment#1, and it will be fixed by a new version of androidx.core as mentioned at comment#19, let's close this issue for now.

If the issue mentioned at comment#13 still happens, please feel free to file a new bug for it.

Any update on this to fix the crashing? Also does this new API will also fix the callback not being triggered after configuration change (orientation) for Android Tablet running on Android 21? We noticed another fragmented behavior between phone at tablet size devices where the setOnApplyWindowInsetsListener callback is not being triggered in Fragments after configuration change.

Activity (callback is being triggered on both phone and tablet after configuration change)

            ViewCompat.setOnApplyWindowInsetsListener(root) { _: View, insets: WindowInsetsCompat ->
                
                // Return WindowInsetsCompat.CONSUMED if you don't want the window insets to keep passing down
                // to descendant views including all views of Fragment(s) under this Activity
                insets
            }

Fragment with Jetpack Navigation (callback is being triggered regardless of Android version on phone size device after configuration change, but not on tablet running on Android 21)

            ViewCompat.setOnApplyWindowInsetsListener(root) { _: View, insets: WindowInsetsCompat ->
                
                // Return WindowInsetsCompat.CONSUMED if you don't want the window insets to keep passing down
                // to descendant views including all views of Fragment(s) under this Activity
                WindowInsetsCompat.CONSUMED
            }

Also hoping this to get fixed by this new API.

Any chance this issue gets higher priority? It's a shame that Google is forcing developers to migrate to Android 15 and setup edge-to-edge while still having critical compatibility issues with older Android versions even in apps with relatively modern stack (Fragment + Compose)

Hi Jeremy,

Do you have any update about the new release?

Build cut is this Wednesday and it will be released next week as part of Fragment 1.8.6.

OMG! Why is updatePadding API removed from Core KTX 1.16.0-beta01? It is the recommended approach to update padding in the docs. Its removal was not even mentioned in the release note and where did the ViewGroupCompat.installCompatInsetsDispatch(rootView) go? What is happening in the Android API?