AGP 8.0.1 release package jacoco instrument does not take effect [283015405]

Fixed

Bug

NeedsInfo

Status Update

No update yet.

Description

co...@gmail.com

created issue #1

May 17, 2023 02:17AM

AGP version: 8.0.1
buildTypes {
release {
minifyEnabled true
testCoverageEnabled true
....
}
}
I set minifyEnabled & testCoverageEnabled as true, but jacoco instrument does not take effect, and obfuscation also did not work.

buildTypes {
release {
minifyEnabled true
enableAndroidTestCoverage true
....
}
}
I set minifyEnabled & enableAndroidTestCoverage as true, obfuscation does work, but jacoco instrument does not take effect.

Comments

mk...@google.com <mk...@google.com> #2May 17, 2023 06:55AM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

co...@ringcentral.com <co...@ringcentral.com> #3May 18, 2023 02:26AM

Comment has been deleted.

Message last modified on May 18, 2023 02:27AM

co...@gmail.com <co...@gmail.com> #4May 18, 2023 02:29AM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

ha...@google.com <ha...@google.com> May 18, 2023 06:12PM

Assigned to an...@google.com.

an...@immobiliare.it <an...@immobiliare.it> #5May 21, 2023 01:18PM

jb...@google.com What is the update on this?

Message last modified on May 21, 2023 01:18PM

je...@google.com <je...@google.com> May 24, 2023 05:59PM

Reassigned to ga...@google.com.

ga...@google.com <ga...@google.com> #6May 25, 2023 03:00PM

Reassigned to lu...@google.com.

What is the status of this item?

lu...@google.com <lu...@google.com> #7May 25, 2023 03:51PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

co...@ringcentral.com <co...@ringcentral.com> #8May 29, 2023 03:04AM

Any ETA on next release?

sa...@gmail.com <sa...@gmail.com> #9Jun 28, 2023 06:59AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

Message last modified on Jun 28, 2023 07:03AM

aa...@gmail.com <aa...@gmail.com> #10Jul 5, 2023 02:02AM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

nl...@163.com <nl...@163.com> #11Jul 5, 2023 02:09AM

Hi, is there any update to this issue? Thanks.

co...@gmail.com <co...@gmail.com> #12Oct 16, 2023 08:11AM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

lu...@google.com <lu...@google.com> Oct 26, 2023 01:07PM

Reassigned to am...@google.com.

am...@google.com <am...@google.com> #13Oct 26, 2023 02:12PM

Yeah, still not fixed --'

am...@google.com <am...@google.com> #14Oct 27, 2023 05:43PM

Marked as fixed.

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

an...@google.com <an...@google.com> #15Nov 2, 2023 09:04PM

Any updates on this? The help for this command clearly states this argument is supported.

co...@gmail.com <co...@gmail.com> #16Nov 28, 2023 01:19AM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

co...@gmail.com <co...@gmail.com> #17Nov 30, 2023 01:05AM

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

hy...@foxmail.com <hy...@foxmail.com> #18Jan 25, 2024 12:16PM

I use AGP 8.3.0-beta02 when isMinifyEnabled=true is set ,other library module jacoco instrument does not take effect app.build

buildTypes {
        release {
            isMinifyEnabled = true
            proguardFiles("proguard-rules/release.pro")
            enableAndroidTestCoverage = true
           }
}

other module

    buildTypes {
        release {
            isMinifyEnabled = false
            enableAndroidTestCoverage=true
            proguardFiles(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro")
        }
....
}

cu...@gmail.com <cu...@gmail.com> #19Mar 6, 2024 12:44PM

this issue also exists when use AGP 7.4.2, is there any workaround to fix it under AGP 7.4.2?

di...@gmail.com <di...@gmail.com> #20May 31, 2024 07:56AM

I have a question：why enableAndroidTestCoverage does not work when isMinifyEnabled=true in AGP7.4.2
create(BuildTypes.JACOCO).apply {
```
isMinifyEnabled = true
testCoverage {
enableAndroidTestCoverage = true
enableUnitTestCoverage = true
}
```
}

ho...@hotmail.com <ho...@hotmail.com> #21Sep 4, 2024 09:50AM

Is there any way to make isMinifyEnabled(true) and jacoco work together?

ho...@hotmail.com <ho...@hotmail.com> #22Sep 13, 2024 03:02AM

Not work with AS(2023.2.1 Canary 12) + AGP (8.3.0-alpha12), any one tried?

------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 12
Android Gradle Plugin 8.3.0-alpha12

Message last modified on Sep 13, 2024 03:02AM