Full screen search bar is unintuitive - consider using a dialog [283311462]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

May 18, 2023 10:05PM

The current implementation uses the same component for the unexpanded search bar and the expanded search view. This makes it hard to use the search bar in the middle of other content, since you have to ensure not to accidentally pass constraints that prevent it from being full screen.

Making the full-screen search view into a dialog would avoid most of these issues.

If there is enough interest (by +1-ing this issue), we could explore the possibility of using this approach.

Comments

ma...@google.com <ma...@google.com> Aug 13, 2024 06:17PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Dec 12, 2024 01:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Dec 12, 2024 01:56PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3214040

Introduce SearchBarState

Expand for full commit details

Introduce SearchBarState 
 
This is part 1 of the search bar refactor. A new 
InputField overload has been added to use this state. 
Other component refactors will come in later CLs. 
 
Bug: b/283311462 
Test: n/a 
Relnote: n/a 
Change-Id: Ibb563b25de5ba76cec7612655b9b632c5f0e99d4

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt

Hash: 4f31090de77bee9f8e1e355e78125b8228e0985b
Date: Fri Aug 09 02:31:50 2024

ap...@google.com <ap...@google.com> #4Dec 12, 2024 01:56PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3366418

Implement predictive back for new search bar

Expand for full commit details

Implement predictive back for new search bar 
 
Bug: b/283311462 
Test: n/a 
Relnote: n/a 
Change-Id: I648ba8a49694d73240761148699ac18caa561210

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt

Hash: bef358ef0860a739cb8af6cd390c6a48c3d8907e
Date: Tue Nov 19 23:08:41 2024

ap...@google.com <ap...@google.com> #5Jan 29, 2025 07:08PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3460540

Publish new search bar APIs.

Expand for full commit details

Publish new search bar APIs. 
 
Samples have also been updated. 
 
Bug: b/261496232, b/263130999, b/283311462, b/350916229, b/352872248 
Test: manually + existing unit/screenshot tests 
Relnote: """New search bar APIs: 
  * Collapsed search bars and expanded search "views" are now 
    separate composables. 
  * `SearchBar` represents a search bar in the collapsed state. 
  * `ExpandedFullScreenSearchBar` and `ExpandedDockedSearchBar` 
    represent the search bar in the expanded state. These open 
    in a new window. 
  * `SearchBarState` to control the state of the search bar 
  * `TopSearchBar` to add insets handling and scroll behavior 
  * New overload of `InputField` which uses `SearchBarState` 
  """ 
Change-Id: Ie0723015eddd66c82f420481dc6f366a7e26f4a8

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/SearchBarSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt

Hash: 2c46cabd287091ae4a47a7309f2f3eb19930c754
Date: Tue Jan 21 18:19:22 2025

ma...@google.com <ma...@google.com> Jan 29, 2025 07:50PM

Marked as fixed.

pr...@google.com <pr...@google.com> #6Feb 12, 2025 06:40PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha08
androidx.compose.material3:material3-android:1.4.0-alpha08
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha08
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha08
androidx.core:core-viewtree:1.0.0-rc01

xe...@gmail.com <xe...@gmail.com> #7Feb 13, 2025 04:25PM

Will this be tweaked to be able to use it according to the M3 Design? Search View Appearing.

In the current version animation does not work correctly without TopSearchBar.

ma...@google.com <ma...@google.com> #8Feb 13, 2025 04:30PM

Can you elaborate on what you mean? The animation is dependent on where the search bar is on the screen, so if you want an animation like in the design guidelines, it has to be placed at the top like TopSearchBar provides.

Issue 283311462

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Aug 13, 2024 06:17PM

ap...@google.com <ap...@google.com> #2Dec 12, 2024 01:56PM

ap...@google.com <ap...@google.com> #3Dec 12, 2024 01:56PM

ap...@google.com <ap...@google.com> #4Dec 12, 2024 01:56PM

ap...@google.com <ap...@google.com> #5Jan 29, 2025 07:08PM

ma...@google.com <ma...@google.com> Jan 29, 2025 07:50PM

pr...@google.com <pr...@google.com> #6Feb 12, 2025 06:40PM

xe...@gmail.com <xe...@gmail.com> #7Feb 13, 2025 04:25PM

ma...@google.com <ma...@google.com> #8Feb 13, 2025 04:30PM

Add comment

Issue metadata