Status Update
Comments
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Implement full screen search bar using dialog
Expand for full commit details
Implement full screen search bar using dialog
Overview of new components:
* SearchBar - visually equivalent to previous overload, except does not
apply the padding/window insets of a top bar.
* CollapsedSearchBar - One half of SearchBar. Just a text field wrapped
in a Surface.
* FullScreenSearchBarLayout - private implementation. Equivalent to
existing SearchBarImpl + SearchBarLayout but slightly cleaned up.
Predictive back support will be added in future CL.
* ExpandedFullScreenSearchBar - FullScreenSearchBarLayout wrapped in a dialog.
Bug: b/283311462
Test: n/a
Relnote: n/a
Change-Id: I71145c5528a2c0c5ee97eca75dda0904ea91108b
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: 7ccfa611287f4388caf0b0224b4b662e9a5f44af
Date: Tue Nov 19 22:59:52 2024
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Introduce SearchBarState
Expand for full commit details
Introduce SearchBarState
This is part 1 of the search bar refactor. A new
InputField overload has been added to use this state.
Other component refactors will come in later CLs.
Bug: b/283311462
Test: n/a
Relnote: n/a
Change-Id: Ibb563b25de5ba76cec7612655b9b632c5f0e99d4
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: 4f31090de77bee9f8e1e355e78125b8228e0985b
Date: Fri Aug 09 02:31:50 2024
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Implement predictive back for new search bar
Expand for full commit details
Implement predictive back for new search bar
Bug: b/283311462
Test: n/a
Relnote: n/a
Change-Id: I648ba8a49694d73240761148699ac18caa561210
Files:
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: bef358ef0860a739cb8af6cd390c6a48c3d8907e
Date: Tue Nov 19 23:08:41 2024
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Publish new search bar APIs.
Expand for full commit details
Publish new search bar APIs.
Samples have also been updated.
Bug: b/261496232, b/263130999, b/283311462, b/350916229, b/352872248
Test: manually + existing unit/screenshot tests
Relnote: """New search bar APIs:
* Collapsed search bars and expanded search "views" are now
separate composables.
* `SearchBar` represents a search bar in the collapsed state.
* `ExpandedFullScreenSearchBar` and `ExpandedDockedSearchBar`
represent the search bar in the expanded state. These open
in a new window.
* `SearchBarState` to control the state of the search bar
* `TopSearchBar` to add insets handling and scroll behavior
* New overload of `InputField` which uses `SearchBarState`
"""
Change-Id: Ie0723015eddd66c82f420481dc6f366a7e26f4a8
Files:
- M
compose/material3/material3/api/current.txt
- M
compose/material3/material3/api/restricted_current.txt
- M
compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
- M
compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/SearchBarSamples.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/SearchBarScreenshotTest.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SearchBar.kt
Hash: 2c46cabd287091ae4a47a7309f2f3eb19930c754
Date: Tue Jan 21 18:19:22 2025
ma...@google.com <ma...@google.com>
pr...@google.com <pr...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha08
androidx.compose.material3:material3-android:1.4.0-alpha08
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha08
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha08
androidx.core:core-viewtree:1.0.0-rc01
xe...@gmail.com <xe...@gmail.com> #7
Will this be tweaked to be able to use it according to the M3 Design?
In the current version animation does not work correctly without TopSearchBar
.
ma...@google.com <ma...@google.com> #8
Can you elaborate on what you mean? The animation is dependent on where the search bar is on the screen, so if you want an animation like in the design guidelines, it has to be placed at the top like TopSearchBar
provides.
Description
The current implementation uses the same component for the unexpanded search bar and the expanded search view. This makes it hard to use the search bar in the middle of other content, since you have to ensure not to accidentally pass constraints that prevent it from being full screen.
Making the full-screen search view into a dialog would avoid most of these issues.
If there is enough interest (by +1-ing this issue), we could explore the possibility of using this approach.