Full screen search bar is unintuitive - consider using a dialog [283311462]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

May 18, 2023 10:05PM

The current implementation uses the same component for the unexpanded search bar and the expanded search view. This makes it hard to use the search bar in the middle of other content, since you have to ensure not to accidentally pass constraints that prevent it from being full screen.

Making the full-screen search view into a dialog would avoid most of these issues.

If there is enough interest (by +1-ing this issue), we could explore the possibility of using this approach.

Comments

ma...@google.com <ma...@google.com> Aug 13, 2024 06:17PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Dec 12, 2024 01:56PM

We recently landed stability improvements and bugfixes in aosp/2258262 and will stabilize ModalBottomSheetLayout following a few release cycles. We are still evaluating the future API of BottomSheetScaffold and are expecting it to stay experimental for a bit more while we migrate it to Swipeable V2.

ap...@google.com <ap...@google.com> #3Dec 12, 2024 01:56PM

@jossiwolf is this on track for 1.6 or moved out to 1.7?

ap...@google.com <ap...@google.com> #4Dec 12, 2024 01:56PM

Currently slated for 1.7

ap...@google.com <ap...@google.com> #5Jan 29, 2025 07:08PM

Bumping to P1 as it is been a long while since we need to land this.

ma...@google.com <ma...@google.com> Jan 29, 2025 07:50PM

Marked as fixed.

pr...@google.com <pr...@google.com> #6Feb 12, 2025 06:40PM

Do we expect this to land by EOW? It's in the SLO chaselist now and very on fire.

xe...@gmail.com <xe...@gmail.com> #7Feb 13, 2025 04:25PM

Hi jossiwolf, is this part of alpha02?

ma...@google.com <ma...@google.com> #8Feb 13, 2025 04:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit e299b64fa3574b44e745173f406bc3b49e1d47f7
Author: Jossi Wolf <jossiwolf@google.com>
Date: Mon Nov 27 19:34:32 2023

[M2] Stabilize ModalBottomSheetLayout

Relnote: Material (2) modal bottom sheets have been promoted from experimental to stable. Deprecated constructors have been removed. The animation spec is now a tween spec in accordance with guidelines.
Fixes: 278692145, 266780235, 261409034
Test: Added modalBottomSheet_show_animatesToHalfExpandedFirstAndToExpandedAfter
Change-Id: Ic53f4fe7c7183569cb7322c8f56f571be5316be0

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetStateTest.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/ModalBottomSheetTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt

https://android-review.googlesource.com/2852687