IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date:   Wed Jul 05 07:26:46 2023

    Convert APIs using PointF to use Float instead
   
    PointF is a convenient mechanism for passing around x.y values
    representing 2D points. But there are downsides, including:
    - Converting to PointF: You may not have the data in PointF form
    to begin with, so using an API which takes PointF requires converting
    the data  to that form (including allocating a PointF object every time)
    - Mutability: Point structures can be mutated internally, causing
    unpredictability in what that mutation means. Should the library
    react to those changes? Ignore them? Do defensive copies (requiring
    even more allocations)? Using primitive types like Float make the
    behavior more obvious (by making the data inherently immutable).
    - Allocations: Whenever we use object types, there are necessarily
    allocations on the Java heap for them. This puts pressure on the GC
    at both allocation and collection time. Given the amount of points
    being passed around (especially at morph creation time, when curves
    are being split and created), this causes a lot of PointF objects to
    be allocated (even temporarily). Using Float avoids that problem.
   
    Also fixed bug with unclosed paths causing discontinuity at the
    start/end point.
   
    Bug: 276466399
    Bug: 290254314
    Test: integration and unit tests pass
    Relnote: PointF parameters changed to Float pairs
    Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M       graphics/graphics-shapes/api/current.txt
M       graphics/graphics-shapes/api/restricted_current.txt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M       graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M       graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M       graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M       graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

PointF was the main (possibly only) mutability issue, marking this as fixed

This modification allowed half of this. Even i applied shape, it's not clipping the whole window. Please check the attached files for code and result.