Support changing DropdownMenu's shape [283654243]

Fixed

Feature Request

Status Update

No update yet.

Description

af...@gmail.com

created issue #1

May 22, 2023 12:47AM

Jetpack Compose version: 1.4.3 Jetpack Compose component used: androidx.compose.material Android Studio Build: #AI-231.7864.76.2311.10114981 (Android Studio Hedgehog | 2023.1.1 Canary 4) Kotlin version: 1.8.21

DropdownMenu and ExposedDropdownMenu in compose.material and compose.material3 don't provide a way to change the shape of the menu. This seems inconsistent with the non-Compose Material theming for menus where it’s possible to change the cornerSize.

Comments

mi...@outlook.com <mi...@outlook.com> #2Oct 3, 2023 09:03AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

al...@gmail.com <al...@gmail.com> #3Dec 4, 2023 02:52PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

ap...@google.com <ap...@google.com> #4Jan 23, 2024 07:42PM

Marked as fixed.

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ma...@google.com <ma...@google.com> Jan 23, 2024 07:46PM

Reassigned to ma...@google.com.

pr...@google.com <pr...@google.com> #5Feb 21, 2024 07:32PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

hi...@kuwaitnet.email <hi...@kuwaitnet.email> #6Jun 27, 2024 01:08PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

Thu Jun 27 2024 18:34:16 GMT+0530 (India Standard Time).png

87 KB

View

Download

Thu Jun 27 2024 18:35:53 GMT+0530 (India Standard Time).png

33 KB

View

Download

fa...@gmail.com <fa...@gmail.com> #7Oct 23, 2024 05:12PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

Message last modified on Oct 23, 2024 05:13PM

mp...@gmail.com <mp...@gmail.com> #8Nov 11, 2024 02:52PM

Thank you, I'll try it and check.

ma...@google.com <ma...@google.com> #9Nov 11, 2024 03:44PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.