Crash with Verification error on Android 12+ [283715197]

Fixed

Bug

Status Update

No update yet.

Description

ku...@gmail.com

created issue #1

May 22, 2023 10:39AM

# compiler: R8
# compiler_version: 8.1.48

First - Verification error reported by system after APK installation

Verification error in void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a)
void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a): [0x12] 
void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a): [0x12] register v2 has type Precise Reference: y0.b but expected Unresolved Reference: com.foo.bar.AdapterContract
void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a) failed to verify: void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a): [0x15] copyRes1 v2<- result0 type=Conflict

App crases on Android 12+

FATAL EXCEPTION: main
Process: com.example.myapplication, PID: 4086
java.lang.VerifyError: Verifier rejected class com.foo.bar.TestViewController: void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a) failed to verify: void com.foo.bar.TestViewController.updateContentState(com.foo.bar.a): [0x15] copyRes1 v2<- result0 type=Conflict (declaration of 'com.foo.bar.TestViewController' appears in /data/app/~~hYH_X5ICv_uxbaCCMrXfwQ==/com.example.myapplication-h_u08qil7FvRYQKJlO2K9A==/base.apk)
    	at com.example.myapplication.MainActivity.onCreate(SourceFile:4)
    	at android.app.Activity.performCreate(Activity.java:8305)
    	at android.app.Activity.performCreate(Activity.java:8284)
    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1417)
    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3626)
    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3782)
    	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
    	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2307)
    	at android.os.Handler.dispatchMessage(Handler.java:106)
    	at android.os.Looper.loopOnce(Looper.java:201)
    	at android.os.Looper.loop(Looper.java:288)
    	at android.app.ActivityThread.main(ActivityThread.java:7872)
    	at java.lang.reflect.Method.invoke(Native Method)
    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Cullprit changes was merged between 8.1.0-dev and 8.1.1-dev tag commits.

RejectionErrorSample.zip

117 KB

Download

Comments

mk...@google.com <mk...@google.com> May 22, 2023 01:16PM

Reassigned to mk...@google.com.

ku...@gmail.com <ku...@gmail.com> #2May 24, 2023 07:11AM

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

mk...@google.com <mk...@google.com> #3May 24, 2023 11:41AM

the fractional part of the location data is exactly the same.

mk...@google.com <mk...@google.com> #4May 24, 2023 01:18PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

ku...@gmail.com <ku...@gmail.com> #5May 24, 2023 04:32PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

ap...@google.com <ap...@google.com> #6May 25, 2023 01:07PM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please

ap...@google.com <ap...@google.com> #7May 25, 2023 01:07PM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ku...@gmail.com <ku...@gmail.com> #8May 26, 2023 10:48AM

Thanks for reporting this issue.

COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.

Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.

mk...@google.com <mk...@google.com> #9May 26, 2023 10:49AM

We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.

ap...@google.com <ap...@google.com> #10May 26, 2023 11:55AM

Thank you very much! it is very useful to me . It solved my confusion.

ap...@google.com <ap...@google.com> #11May 30, 2023 08:28AM

Project: r8
Branch: 8.1

commit ca69ebf831445b1d059cc3fa7ef4d14e27b50b9d
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 30 09:18:58 2023

Version 8.1.51

Bug:

b/283715197

Change-Id: If935ca69028331d97c0f65ab99fecec43f3e8ef1

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/79883

ap...@google.com <ap...@google.com> #12May 30, 2023 08:28AM

Project: r8
Branch: 8.1

commit abc153927e0ce7b644f3b514aeb834a9da09d0ff
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 30 09:18:47 2023

Check for member type to be of array type

Bug:

b/283715197

Change-Id: Iae3cc98b8a5f5d5eaeb49bf652c0bc4c652c4baf

M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java

https://r8-review.googlesource.com/79882

ap...@google.com <ap...@google.com> #13May 30, 2023 08:28AM

Project: r8
Branch: 8.1

commit 483f2aaf857ccf4c83fd2b5e66169d0f9499c416
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 30 09:18:34 2023

Only generate FilledNewArray when puts match the concrete array type

Bug:

b/283715197

Change-Id: Ie24d90160cceeecd790a5074d8dbcbac116fb58e

M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/TestParameters.java
M src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java

https://r8-review.googlesource.com/79881

ap...@google.com <ap...@google.com> #14May 30, 2023 08:28AM

Project: r8
Branch: 8.1

commit 274db01d37ff28da61a304070e9457192a488999
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue May 30 09:18:22 2023

Add tests for rewriting subtypes into FilledNewArray

Bug:

b/283715197

Change-Id: I24d847474f604ce7f0b95b3592a2c57faf1b19fe

M src/test/java/com/android/tools/r8/TestParameters.java
A src/test/java/com/android/tools/r8/rewrite/arrays/FilledArrayDataRemoveCheckCastTest.java
M src/test/java/com/android/tools/r8/utils/codeinspector/CfInstructionSubject.java
M src/test/java/com/android/tools/r8/utils/codeinspector/DexInstructionSubject.java
M src/test/java/com/android/tools/r8/utils/codeinspector/InstructionSubject.java

https://r8-review.googlesource.com/79880

mk...@google.com <mk...@google.com> #15Jun 1, 2023 06:53AM

Verified by mk...@google.com.

This was fixed after landing: https://googleplex-android-review.git.corp.google.com/c/platform/prebuilts/r8/+/23489252

mk...@google.com <mk...@google.com> #16Jun 8, 2023 10:52AM

For our own purposes, the fix in ART is here: https://android-review.git.corp.google.com/c/platform/art/+/2438373

This can not be seen externally.

sg...@google.com <sg...@google.com> #17Jun 8, 2023 10:58AM

The public URL for the Art fix is: https://android-review.googlesource.com/c/platform/art/+/2438373.

ku...@gmail.com <ku...@gmail.com> #18Jun 16, 2023 06:54PM

Hey, guys! Crash still reproduced on Sample Project with fresh R8 8.1.53

mk...@google.com <mk...@google.com> #19Jun 19, 2023 11:42AM

Thanks for reporting back that this is still an issue. I've tested and could also see the same issue. I did do a check before submitting 8.1.51 but must either have used the D8 or an incorrect emulator.

The issue here is the check:

return clazz.isInterface() || valueType.isClassType(elementType);

Ordinarily, type-checking is weakened for interface types due other strange issues and since I found no issues testing it I included it. The fix needs to be:

return valueType.isClassType(elementType);

Will update the code and do a new cherry-pick to the 8.1 branch.

ap...@google.com <ap...@google.com> #20Jun 20, 2023 08:39AM

Project: r8
Branch: main

commit 3232b654f8432d9f8cc0a501afdc2bed8bbde0ec
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Jun 20 10:37:25 2023

Disallow simplifying arrays to interface types if not exact type match

Bug:

b/283715197

Change-Id: Ie11bc1f834f3e30d23ae584ade0e006241e4b54b

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java

https://r8-review.googlesource.com/80811

mk...@google.com <mk...@google.com> #21Jun 20, 2023 11:38AM

Status: Assigned (reopened)

Checked that running with 3232b654f8432d9f8cc0a501afdc2bed8bbde0ec resolves the issue by adding :

maven {
    url 'https://storage.googleapis.com/r8-releases/raw/main'
}

and

buildscript {
    dependencies {
        classpath("com.android.tools:r8:3232b654f8432d9f8cc0a501afdc2bed8bbde0ec")
    }
}

The APP now runs without throwing the error

# compiler: R8
# compiler_version: main
# min_api: 24
# compiler_hash: 3232b654f8432d9f8cc0a501afdc2bed8bbde0ec
# common_typos_disable
# {"id":"com.android.tools.r8.mapping","version":"2.2"}
# pg_map_id: 9ef8888
# pg_map_hash: SHA-256 9ef88884af70a1da33707ec31626367b52a37d290c9c8aadf9cd4dc008816dfd

Will merge this new CL to 8.1

ap...@google.com <ap...@google.com> #22Jun 20, 2023 07:56PM

Project: r8
Branch: 8.1

commit 7672aa5bcf2694b8576739355c8d59e3eec08e28
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Jun 20 16:10:28 2023

Version 8.1.55

Bug:

b/283715197

Change-Id: I2fcada1fcb73437993a602f1b52f907ac58b93e2

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/80882

ap...@google.com <ap...@google.com> #23Jun 20, 2023 07:56PM

Project: r8
Branch: 8.1

commit b9c2cae08b1245442fcdc86373dd8164c61f4557
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Jun 20 16:10:16 2023

Disallow simplifying arrays to interface types if not exact type match

Bug:

b/283715197

Change-Id: Ie11bc1f834f3e30d23ae584ade0e006241e4b54b

M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
M src/test/java/com/android/tools/r8/rewrite/arrays/SimplifyArrayConstructionTest.java

https://r8-review.googlesource.com/80881

ap...@google.com <ap...@google.com> #24Jun 20, 2023 08:00PM

Project: r8
Branch: 8.1

commit 892155436bed60c4f2f7672d4993950e7b342bd9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Jun 20 16:18:51 2023

Version 8.1.56

Bug:

b/283715197

Change-Id: Ic845063045a560c9be152873092d50a6fd7c9ece

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/80884

mk...@google.com <mk...@google.com> Jul 3, 2023 10:20AM

Marked as fixed.

Issue 283715197

Description

Issue summary

Comments

mk...@google.com <mk...@google.com> May 22, 2023 01:16PM

ku...@gmail.com <ku...@gmail.com> #2May 24, 2023 07:11AM

mk...@google.com <mk...@google.com> #3May 24, 2023 11:41AM

mk...@google.com <mk...@google.com> #4May 24, 2023 01:18PM

ku...@gmail.com <ku...@gmail.com> #5May 24, 2023 04:32PM

ap...@google.com <ap...@google.com> #6May 25, 2023 01:07PM

ap...@google.com <ap...@google.com> #7May 25, 2023 01:07PM

ku...@gmail.com <ku...@gmail.com> #8May 26, 2023 10:48AM

mk...@google.com <mk...@google.com> #9May 26, 2023 10:49AM

ap...@google.com <ap...@google.com> #10May 26, 2023 11:55AM

ap...@google.com <ap...@google.com> #11May 30, 2023 08:28AM

ap...@google.com <ap...@google.com> #12May 30, 2023 08:28AM

ap...@google.com <ap...@google.com> #13May 30, 2023 08:28AM

ap...@google.com <ap...@google.com> #14May 30, 2023 08:28AM

mk...@google.com <mk...@google.com> #15Jun 1, 2023 06:53AM

mk...@google.com <mk...@google.com> #16Jun 8, 2023 10:52AM

sg...@google.com <sg...@google.com> #17Jun 8, 2023 10:58AM

ku...@gmail.com <ku...@gmail.com> #18Jun 16, 2023 06:54PM

mk...@google.com <mk...@google.com> #19Jun 19, 2023 11:42AM

ap...@google.com <ap...@google.com> #20Jun 20, 2023 08:39AM

mk...@google.com <mk...@google.com> #21Jun 20, 2023 11:38AM

ap...@google.com <ap...@google.com> #22Jun 20, 2023 07:56PM

ap...@google.com <ap...@google.com> #23Jun 20, 2023 07:56PM

ap...@google.com <ap...@google.com> #24Jun 20, 2023 08:00PM

mk...@google.com <mk...@google.com> Jul 3, 2023 10:20AM

Add comment

Issue metadata