dex-startup-optimization results in java.lang.VerifyError: Rejecting class [284334258]

Verified

Bug

Status Update

No update yet.

Description

il...@gmail.com

created issue #1

May 26, 2023 11:56AM

Hello team! I'm trying to play around with startup profiles and dex-startup-optimization, but the final build results in the next exception. Any ideas on how can we debug and troubleshoot it?

FATAL EXCEPTION: main
Process: xxx, PID: 5246
java.lang.VerifyError: Rejecting class xxx.yyyApplication that attempts to sub-type erroneous class mQ (declaration of 'xxx.yyyApplication' appears in /data/app/~~yrjjUPjOxBs5lFDKXXNxhA==/xxx-06TuSPwE6KLgPDzMFRrjlA==/base.apk)
	at java.lang.Class.newInstance(Native Method)
	at android.app.AppComponentFactory.instantiateApplication(AppComponentFactory.java:76)
	at androidx.core.app.CoreComponentFactory.instantiateApplication(SourceFile:1)
	at android.app.Instrumentation.newApplication(Instrumentation.java:1243)
	at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1458)
	at android.app.LoadedApk.makeApplicationInner(LoadedApk.java:1395)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6732)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2129)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7884)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Caused by: java.lang.VerifyError: Verifier rejected class mQ: void mQ.<init>() failed to verify: void mQ.<init>(): [0x0] 'this' arg must be initialized
 void mQ.a() failed to verify: void mQ.a(): [0x0] Expected initialization on uninitialized reference Reference: mQ (declaration of 'mQ' appears in /data/app/~~yrjjUPjOxBs5lFDKXXNxhA==/xxx-06TuSPwE6KLgPDzMFRrjlA==/base.apk)
	... 16 more

Devices/Android versions reproduced on: Pixel 6 Pro

Env:

Android Studio Hedgehog | 2023.1.1 Canary 5
Build #AI-231.7864.76.2311.10195651, built on May 24, 2023
Runtime version: 17.0.6+0-b2043.56-10027231 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 16

Deps:

com.android.tools.build:gradle:8.2.0-alpha05
com.android.test version 8.2.0-alpha05
org.jetbrains.kotlin.android version 1.9.0-Beta
androidx.baselineprofile version 1.2.0-alpha14
com.android.application version 8.2.0-alpha05
com.google.devtools.ksp version 1.9.0-Beta-1.0.11

experimentalProperties["android.experimental.art-profile-r8-rewriting"] = true
experimentalProperties["android.experimental.r8.dex-startup-optimization"] = true

Comments

ra...@google.com <ra...@google.com> #2May 26, 2023 07:41PM

for example, many different devices return the same longitude and latitude.such as : longitude is 121.474000 and latitude is 31.230001.
i donnot understand why is the data the same?

ch...@google.com <ch...@google.com> #3May 30, 2023 06:41AM

Reassigned to ch...@google.com.

the fractional part of the location data is exactly the same.

il...@gmail.com <il...@gmail.com> #4May 30, 2023 01:19PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which Android build are you using? (e.g. AP4A.241205.013.A1)

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Please provide a sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

ch...@google.com <ch...@google.com> #5May 31, 2023 06:54PM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

ap...@google.com <ap...@google.com> #6Jun 1, 2023 08:38AM

I only aply permission android.permission.ACCESS_COARSE_LOCATION.I use android.location.Location in the program.
for example,we hava 100 users.
20 users returned the same location information, longitude is 121.474000 and latitude is 31.230001。
30 users returned the same location information, longitude is 122.474000 and latitude is 32.230001。
15 users returned the same location information, longitude is 120.474000 and latitude is 30.230001。

as for Android build,all versions have it.
I dont reprodouce this issue.

what may be the cause of this issue?please

ap...@google.com <ap...@google.com> #7Jun 1, 2023 08:38AM

We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ch...@google.com <ch...@google.com> #8Jun 1, 2023 08:57AM

Verified by ch...@google.com.

Thanks for reporting this issue.

COARSE_LOCATION typically takes location information from the nearby cell tower. If many users are near the same cell tower, each of those users will be given the same position. Using a FINE position will give much more detailed information.

Also, in certain areas, for privacy reasons, a less-exact location will be given, and that less-exact location might be identical for many users. Again, a fine-location configuration will return more precise location data.

il...@gmail.com <il...@gmail.com> #9Jun 1, 2023 09:46AM

We believe with reference to the above comment, your query has been answered, hence closing the bug. Please feel free to re-open the issue in the future if desired.

ap...@google.com <ap...@google.com> #10Jun 1, 2023 10:26AM

Thank you very much! it is very useful to me . It solved my confusion.

ap...@google.com <ap...@google.com> #11Jun 1, 2023 10:26AM

Project: r8
Branch: 8.1

commit 6ffe085ffe3dca175ac081e15578632fb664047d
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 01 10:54:13 2023

Fix inadequate force inlining with startup profile

Bug:

b/284334258

Change-Id: Idc8fbd95cd3973401d47b3c9182cfbe28b0abbb8

M src/main/java/com/android/tools/r8/features/FeatureSplitBoundaryOptimizationUtils.java
M src/test/java/com/android/tools/r8/startup/ForceInlineAfterVerticalClassMergingStartupTest.java

https://r8-review.googlesource.com/80064

ap...@google.com <ap...@google.com> #12Jun 1, 2023 10:26AM

Project: r8
Branch: 8.1

commit 625220633518a12c5d97f7888a3616bea959c0a4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Thu Jun 01 10:54:03 2023

Reproduce inadequate force inlining with startup profile

Bug:

b/284334258

Change-Id: I2e1b46e672d54294882de7fdaf9ee5c2fb4a5a26

A src/test/java/com/android/tools/r8/startup/ForceInlineAfterVerticalClassMergingStartupTest.java

https://r8-review.googlesource.com/80063

ra...@google.com <ra...@google.com> #13Jun 2, 2023 06:20PM

Can you please try using a new R8 version in the build to see if that resolves your issue ? You should be able to do something like:

pluginManagement {
    buildscript {
        repositories {
            google()
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw/main")
            }
        }
        dependencies {
            // https://r8.googlesource.com/r8/+log/refs/heads/main
            classpath("com.android.tools:r8:7cfc5b65a937a35a9f5b8afa1cdccb1fb1ee03c4")
        }
    }
    // ...
}

il...@gmail.com <il...@gmail.com> #14Jun 5, 2023 07:22AM

Hi! Yes, the issue is now resolved with the newest R8 revisions. Thank you!

sg...@google.com <sg...@google.com> #15Jun 6, 2023 09:15AM

Thanks for trying out the latest main revision. The fix is merged to the release branch for 8.1, so you should consider using:

pluginManagement {
    buildscript {
        repositories {
            google()
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            // https://r8.googlesource.com/r8/+log/refs/heads/8.1
            classpath("com.android.tools:r8:8.1.53")
        }
    }
    // ...
}

bi...@gmail.com <bi...@gmail.com> #16Nov 5, 2023 08:26AM

Tão querendo minha conta